View Issue Details

Related ChangesetsJump to NotesJump to History
IDProjectCategoryView StatusDate SubmittedLast Update
0001735Slicer4Module Annotationspublic2012-02-18 08:562017-06-07 23:27
Reporterinorton Assigned Tonicole  
PrioritynormalSeveritytweakReproducibilityalways
Status closedResolutionfixed 
Product Version 
Target VersionSlicer 4.3.0Fixed in VersionSlicer 4.3.0 
Summary0001735: Annotation widget does not maintain collapsed state after refresh.
Description

ss1: CAVITY list is collapsed, seeding list is active
ss2: i added a new fiducial point, and CAVITY list has expanded.

TagsNo tags attached.

Relationships

related to 0002840 closedsankhesh when add new hierarchy nodes, they're collapsed in the tree view by default 
related to 0002557 closedsankhesh Models hierarchy: whenever the eye is clicked on a node complex hierarchy, the whole interface refreshes collapsing all nodes 

Activities

2012-02-18 08:56

 

ss1.png (373,566 bytes)
ss1.png (373,566 bytes)

2012-02-18 08:56

 

ss2.png (391,075 bytes)
ss2.png (391,075 bytes)
nicole

nicole

2012-03-03 12:49

administrator   ~0003770

This is due to the expandAll call in qMRMLAnnotationTreeView::setMRMLScene, which is called from refreshTree when an annotation node is added. I'll see if I can find a better way to get the tree to update while maintaining the collapsed state of hierarchies.
finetjul

finetjul

2012-03-03 13:01

administrator   ~0003771

Should there be a check that if the scene is the same, then setMRMLScene is a no-op ?
-> return if (newScene == currentScene)
nicole

nicole

2012-03-03 13:11

administrator   ~0003772

I tried that, then the hierarchies never expand. I have to double check how it's working in the models module.
nicole

nicole

2012-12-26 12:14

administrator   ~0007585

Should be fixed as of svn 21531 (it required a few changes to the base classes and a pattern to follow from the Models module, see related bugs).
http://viewvc.slicer.org/viewvc.cgi/Slicer4?view=revision&revision=21531
jcfr

jcfr

2014-03-06 04:53

administrator   ~0010767

Closing resolved issues that have not been updated in more than 3 months

Related Changesets

Slicer: 2145-support-for-installing-extension-from-file 47b664f3

2012-12-26 17:13:04

naucoin

Details Diff 		BUG: stop the annotation tree view from auto expanding lists

Don't use calling setMRMLScene on the tree view to refresh the tree,
as it resets the expand level on the tree view, only call it when
the scene is different.
This stopped the auto added top level all annotations list and the fiducials/ruler
list nodes from expanding, so invoke an event from the logic when those default
hierarchy nodes are added to trigger the tree to expand them (using the
Expanded value on the hierarchy node).
Also expand the hierarchy node when it's added by the user via the add
hierarchy button.

Fixes issue 0001735


git-svn-id: http://svn.slicer.org/Slicer4/trunk@21531 3bd1e089-480b-0410-8dfb-8563597acbee
mod - Modules/Loadable/Annotations/GUI/qSlicerAnnotationModuleWidget.cxx Diff File
mod - Modules/Loadable/Annotations/GUI/qSlicerAnnotationModuleWidget.h Diff File
mod - Modules/Loadable/Annotations/Logic/vtkSlicerAnnotationModuleLogic.cxx Diff File
mod - Modules/Loadable/Annotations/Logic/vtkSlicerAnnotationModuleLogic.h Diff File

Issue History

Date Modified Username Field Change
2012-02-18 08:56 inorton New Issue
2012-02-18 08:56 inorton Status new => assigned
2012-02-18 08:56 inorton Assigned To => nicole
2012-02-18 08:56 inorton File Added: ss1.png
2012-02-18 08:56 inorton File Added: ss2.png
2012-03-03 12:49 nicole Note Added: 0003770
2012-03-03 13:01 finetjul Note Added: 0003771
2012-03-03 13:11 nicole Note Added: 0003772
2012-08-20 10:01 nicole Target Version => Slicer 4.2.5
2012-08-21 09:39 jcfr Target Version Slicer 4.2.5 => Slicer 4.3.0
2012-12-26 11:54 nicole Relationship added related to 0002840
2012-12-26 11:55 nicole Relationship added related to 0002557
2012-12-26 12:14 nicole Note Added: 0007585
2012-12-26 12:14 nicole Status assigned => resolved
2012-12-26 12:14 nicole Fixed in Version => Slicer 4.3.0
2012-12-26 12:14 nicole Resolution open => fixed
2014-03-06 04:53 jcfr Note Added: 0010767
2014-03-06 04:54 jcfr Status resolved => closed
2017-06-07 23:27 Changeset attached => Slicer 2145-support-for-installing-extension-from-file 47b664f3