View Issue Details

Related ChangesetsJump to NotesJump to History
IDProjectCategoryView StatusDate SubmittedLast Update
0002767Slicer4Core: Extensionspublic2012-11-16 05:172017-06-07 23:27
Reporterfedorov Assigned Tojcfr  
PrioritynormalSeverityminorReproducibilityhave not tried
Status closedResolutionfixed 
Product Version 
Target VersionSlicer 4.2.2-1Fixed in VersionSlicer 4.2.2-1 
Summary0002767: Extension test pass despite of "error: Application does NOT exists []"
Description

See http://slicer-devel.65872.n3.nabble.com/Critical-Dashboard-Win7-launcher-issues-tt4026842.html

// ---------------------
Hi,

Please look at this entry:
http://slicer.cdash.org/testDetails.php?test=3107890&build=47492

Here's the output of this test that "Passed". There are many tests
passing like this on today's dashboard (for Reporting, SlicerRT,
LongitudinalPETCT). I think all of those are python. I do not know
when this started happening.

error: Application does NOT exists []
Usage
Slicer [options]

Options
--launcher-help Display help
--launcher-version Show launcher version information
--launcher-verbose Verbose mode
--launch Specify the application to launch
--launcher-detach Launcher will NOT wait for the
application to finish
--launcher-no-splash Hide launcher splash
--launcher-timeout Specify the time in second before
the launcher kills the application. -1 means no timeout (default: -1)
--launcher-dump-environment Launcher will print environment
variables to be set, then exit
--launcher-additional-settings Additional settings file to consider
--launcher-generate-template Generate an example of setting file

TagsNo tags attached.

Activities

fedorov

fedorov

2012-11-16 05:23

developer   ~0007277

One more detail: this seems to be happening on 4.2 extensions dashboard. On the nightly dashboard, I do not see this issue.
jcfr

jcfr

2012-11-16 09:35

administrator   ~0007292

For some reason, the launcher settings have been improperly generated. I fixed them by re-running the target "SlicerConfigureLauncherSettings"... so that the error does not happen.

I also identified the reason explaining the error wasn't reported. The launcher wasn't reporting an EXIT_FAILURE error code in case of missing application. This is captured by the following issue: https://github.com/commontk/AppLauncher/issues/35
fedorov

fedorov

2012-11-16 09:41

developer   ~0007294

JC, we probably need to add an issue to create a set of tests that would test the testing framework that would emulate various conditions of a failing test (exception, segfault, missing file).

Another idea is to have the framework return "fail" by default, unless there is explicit "success" from the test. It would be much better to have false negatives than false positives, as in this case!
jcfr

jcfr

2012-11-16 09:49

administrator   ~0007295

There is already some test to exercise the framework:

https://github.com/Slicer/Slicer/blob/master/Applications/SlicerApp/Testing/Python/SlicerTestingExitFailureTest.py

https://github.com/Slicer/Slicer/blob/master/Applications/SlicerApp/Testing/Python/SlicerTestingExitSuccessTest.py

https://github.com/Slicer/Slicer/blob/master/Applications/SlicerApp/Testing/Python/SlicerUnitTestTest.py

https://github.com/Slicer/Slicer/blob/master/Applications/SlicerApp/Testing/Python/SlicerUnitTestWithErrorsTest.py

This problem is specific to the launcher, a 41th test will be added to the launcher test suite :)
See http://my.cdash.org/index.php?project=CTKAppLauncher
jcfr

jcfr

2012-11-16 10:58

administrator   ~0007300

Issue re-targeted for 4.2.2. It doesn't make sens to update the launcher version today.
jcfr

jcfr

2012-11-20 09:21

administrator   ~0007328

Launcher itself has been fixed. See https://github.com/commontk/AppLauncher/commit/12090723b40d60430ddb77a5bf2cfedad4c56d10
and https://github.com/commontk/AppLauncher/issues/35

Next week will have to release version 0.1.10 and update External_CTKAppLauncher.cmake
jcfr

jcfr

2012-12-06 14:31

administrator   ~0007433

Fixed in:
trunk: http://viewvc.slicer.org/viewvc.cgi/Slicer4?view=revision&revision=21482
4.2 branch: http://viewvc.slicer.org/viewvc.cgi/Slicer4?view=revision&revision=21489
jcfr

jcfr

2017-06-07 23:27

administrator   ~0014677

Fix committed to 2145-support-for-installing-extension-from-file branch.

Related Changesets

Slicer: 2145-support-for-installing-extension-from-file e6fb116c

2012-12-06 19:23:59

jcfr

Details Diff 		ENH: Support per user per revision extensions settings

There is now a clear distinction between:
- userSettings -> i.e. ~/.config/NA-MIC/Slicer.ini
- revisionUserSettings -> i.e. ~/.config/NA-MIC/Slicer-<revision>.ini

The following slicer settings are now revision specific:
- Extensions/ManagerEnabled
- Extensions/ServerUrl
- Extensions/InstallPath
- Modules/AdditonalPath
- Modules/IgnoreModules

Additionally, the launcher version has also been updated to be able to
consider settings associated with a user, application and revision. This is
captured by the new parameter APPLICATION_REVISION, ORGANIZATION_DOMAIN,
ORGANIZATION_NAME and USER_ADDITIONAL_SETTINGS_FILEBASENAME passed to the CMake
function "ctkAppLauncherConfigure".

qSlicerCoreApplication API has also been extended and now includes methods
like:
- QSettings* userSettings() [settings() method is deprecated and kept for backward compatibility]
- QSettings* revisionUserSettings()
- QString launcherRevisionUserSettingsFilePath()
- QString slicerUserSettingsFilePath()
- QString slicerRevisionUserSettingsFilePath()

In addition to the settings, the extensions install path is also revision
specific, it means that it's now possible to have multiple version of slicer
running with different set of extensions.

Fixes 0002791, 0002143, 0002720, 0002533


Since the version of the launcher is updated, launcher will return EXIT_FAILURE
also when no application is been set in the launcher settings.

Fixes 0002767

git-svn-id: http://svn.slicer.org/Slicer4/trunk@21482 3bd1e089-480b-0410-8dfb-8563597acbee
mod - Applications/SlicerApp/CMakeLists.txt Diff File
mod - Applications/SlicerApp/Main.cxx Diff File
mod - Applications/SlicerApp/qSlicerAppMainWindow.cxx Diff File
mod - Base/Logic/Testing/vtkSlicerApplicationLogicTest1.cxx Diff File
mod - Base/Logic/vtkSlicerApplicationLogic.cxx Diff File
mod - Base/Logic/vtkSlicerApplicationLogic.h Diff File
mod - Base/QTApp/qSlicerApplicationHelper.cxx Diff File
mod - Base/QTCLI/qSlicerCLIModuleFactoryHelper.cxx Diff File
mod - Base/QTCore/Testing/Cxx/qSlicerCoreApplicationTest1.cxx Diff File
mod - Base/QTCore/Testing/Cxx/qSlicerExtensionsManagerModelTest.cxx Diff File
mod - Base/QTCore/Testing/Data/Input/19615-macosx-amd64-CLIExtensionTemplate-svn19615-2012-03-18.tar.gz Diff File
mod - Base/QTCore/Testing/Data/Input/19615-macosx-amd64-LoadableExtensionTemplate-svn19615-2012-03-18.tar.gz Diff File
mod - Base/QTCore/Testing/Data/Input/19615-macosx-amd64-ScriptedLoadableExtensionTemplate-svn19615-2012-03-18.tar.gz Diff File
mod - Base/QTCore/Testing/Data/Input/19615-macosx-amd64-SuperBuildLoadableExtensionTemplate-svn19615-2012-03-18.tar.gz Diff File
mod - Base/QTCore/qSlicerCoreApplication.cxx Diff File
mod - Base/QTCore/qSlicerCoreApplication.h Diff File
mod - Base/QTCore/qSlicerCoreApplication_p.h Diff File
mod - Base/QTCore/qSlicerCoreCommandOptions.cxx Diff File
mod - Base/QTCore/qSlicerCoreCommandOptions.h Diff File
mod - Base/QTCore/qSlicerExtensionsManagerModel.cxx Diff File
mod - Base/QTCore/qSlicerExtensionsManagerModel.h Diff File
mod - Base/QTCore/qSlicerLoadableModuleFactory.cxx Diff File
mod - Base/QTGUI/qSlicerExtensionsManagerDialog.cxx Diff File
mod - Base/QTGUI/qSlicerScriptedLoadableModuleFactory.cxx Diff File
mod - Base/QTGUI/qSlicerSettingsExtensionsPanel.cxx Diff File
mod - Base/QTGUI/qSlicerSettingsGeneralPanel.cxx Diff File
mod - Base/QTGUI/qSlicerSettingsModulesPanel.cxx Diff File
mod - CMake/SlicerConfig.cmake.in Diff File
mod - CMake/UseSlicer.cmake.in Diff File
mod - CMake/vtkSlicerConfigure.h.in Diff File
mod - CMakeLists.txt Diff File
mod - Modules/Loadable/Colors/qSlicerColorsModule.cxx Diff File
mod - Modules/Scripted/Scripts/DICOM.py Diff File
mod - SuperBuild.cmake Diff File
mod - SuperBuild/External_CTK.cmake Diff File
mod - SuperBuild/External_CTKAPPLAUNCHER.cmake Diff File

Issue History

Date Modified Username Field Change
2012-11-16 05:17 jcfr New Issue
2012-11-16 05:17 jcfr Status new => assigned
2012-11-16 05:17 jcfr Assigned To => jcfr
2012-11-16 05:17 jcfr Reporter jcfr => fedorov
2012-11-16 05:17 jcfr Target Version => Slicer 4.2.1
2012-11-16 05:23 fedorov Note Added: 0007277
2012-11-16 09:35 jcfr Note Added: 0007292
2012-11-16 09:41 fedorov Note Added: 0007294
2012-11-16 09:49 jcfr Note Added: 0007295
2012-11-16 10:58 jcfr Target Version Slicer 4.2.1 => Slicer 4.2.2
2012-11-16 10:58 jcfr Note Added: 0007300
2012-11-20 09:21 jcfr Note Added: 0007328
2012-12-06 14:31 jcfr Note Added: 0007433
2012-12-06 14:31 jcfr Status assigned => resolved
2012-12-06 14:31 jcfr Fixed in Version => Slicer 4.2.2
2012-12-06 14:31 jcfr Resolution open => fixed
2013-09-11 12:27 fedorov Status resolved => closed
2017-06-07 23:27 jcfr Changeset attached => Slicer 2145-support-for-installing-extension-from-file e6fb116c
2017-06-07 23:27 jcfr Note Added: 0014677