View Issue Details
ID | Project | Category | View Status | Date Submitted | Last Update |
---|---|---|---|---|---|
0002720 | Slicer4 | Core: Extensions | public | 2012-11-01 14:54 | 2017-06-07 23:27 |
Reporter | pieper | Assigned To | jcfr | ||
Priority | normal | Severity | block | Reproducibility | always |
Status | closed | Resolution | fixed | ||
Product Version | Slicer 4.2.0 | ||||
Target Version | Slicer 4.2.2-1 | Fixed in Version | Slicer 4.2.2-1 | ||
Summary | 0002720: can't install extensions on windows | ||||
Description | Hi Jc - FYI - on windows I needed to change the permission on the launcher I'll file a bug report :) | ||||
Tags | No tags attached. | ||||
2012-11-01 14:54
|
|
Published a toy project that will be used to reproduce and fix the problem. See https://github.com/jcfr/2720-install-writable-file |
|
Even after explicitly setting user/group/world read/write permissions [1], file is not installed with appropriate permission. [1] https://github.com/jcfr/2720-install-writable-file/commit/da9cf93765d15a588e175be95b745b6ed157d292 Will have to investigate how NSIS could be tune directly. May be signing the package could help. See [2] [2] http://stackoverflow.com/questions/10581570/setting-the-uac-publisher-field-for-a-nsis-installer |
|
Confirm/Check if extension works anyway |
|
Waiting to get the verisign key that will allow to sign the application / package |
|
I tested on a different windows 7 machine (not the one where I changed the permission of the settings file). I can confirm: 1) that the error message about not being able to write to the settings file does still occur when installing an extension. 2) that the extension works in spite of the error message. Given that the desired functionality works, perhaps it's better to either (a) avoid changing the permissions on the settings file since it requires signing the app or (b) store the information about extensions in the user's local data store. An advantage of (b) is that different users on the same machine could have their own extension installed. |
|
Thanks for checking. For simple extension, having the launcher settings updated is not an issue. Indeed, the required paths are set by the application:
Keeping the path updated within the launcher settings has the advantages of providing an easy way to find out which paths are used and allow to start terminal with the proper environment. For more complex extension (I am thinking about SlicerRT), not having the launcher settings updated is probably an issue since path containing additional libraries are not set by the application. (/path/to/module/lib/Slicer-4.2/) Finally, let's note that having per user launcher setting is captured by issue 0002143. The idea, would be to keep the path settings in one file that would be used by both the launcher and the application. (On mac there are no launcher but the path could be read from a launcher settings file). It would bring consistency. Our sysadmin Matt should provide me with the key to sign both app and installer later today. [1] https://github.com/Slicer/Slicer/blob/master/Base/QTCLI/qSlicerCLIExecutableModuleFactory.cxx#L54 |
|
Considering that:
I re-targeted the issue. |
|
Fixed in: |
|
Closing resolved issues that have not been updated in more than 3 months |
|
Fix committed to 2145-support-for-installing-extension-from-file branch. |
|
Slicer: 2145-support-for-installing-extension-from-file e6fb116c 2012-12-06 19:23:59 Details Diff |
ENH: Support per user per revision extensions settings There is now a clear distinction between: - userSettings -> i.e. ~/.config/NA-MIC/Slicer.ini - revisionUserSettings -> i.e. ~/.config/NA-MIC/Slicer-<revision>.ini The following slicer settings are now revision specific: - Extensions/ManagerEnabled - Extensions/ServerUrl - Extensions/InstallPath - Modules/AdditonalPath - Modules/IgnoreModules Additionally, the launcher version has also been updated to be able to consider settings associated with a user, application and revision. This is captured by the new parameter APPLICATION_REVISION, ORGANIZATION_DOMAIN, ORGANIZATION_NAME and USER_ADDITIONAL_SETTINGS_FILEBASENAME passed to the CMake function "ctkAppLauncherConfigure". qSlicerCoreApplication API has also been extended and now includes methods like: - QSettings* userSettings() [settings() method is deprecated and kept for backward compatibility] - QSettings* revisionUserSettings() - QString launcherRevisionUserSettingsFilePath() - QString slicerUserSettingsFilePath() - QString slicerRevisionUserSettingsFilePath() In addition to the settings, the extensions install path is also revision specific, it means that it's now possible to have multiple version of slicer running with different set of extensions. Fixes 0002791, 0002143, 0002720, 0002533 Since the version of the launcher is updated, launcher will return EXIT_FAILURE also when no application is been set in the launcher settings. Fixes 0002767 git-svn-id: http://svn.slicer.org/Slicer4/trunk@21482 3bd1e089-480b-0410-8dfb-8563597acbee |
||
mod - Applications/SlicerApp/CMakeLists.txt | Diff File | ||
mod - Applications/SlicerApp/Main.cxx | Diff File | ||
mod - Applications/SlicerApp/qSlicerAppMainWindow.cxx | Diff File | ||
mod - Base/Logic/Testing/vtkSlicerApplicationLogicTest1.cxx | Diff File | ||
mod - Base/Logic/vtkSlicerApplicationLogic.cxx | Diff File | ||
mod - Base/Logic/vtkSlicerApplicationLogic.h | Diff File | ||
mod - Base/QTApp/qSlicerApplicationHelper.cxx | Diff File | ||
mod - Base/QTCLI/qSlicerCLIModuleFactoryHelper.cxx | Diff File | ||
mod - Base/QTCore/Testing/Cxx/qSlicerCoreApplicationTest1.cxx | Diff File | ||
mod - Base/QTCore/Testing/Cxx/qSlicerExtensionsManagerModelTest.cxx | Diff File | ||
mod - Base/QTCore/Testing/Data/Input/19615-macosx-amd64-CLIExtensionTemplate-svn19615-2012-03-18.tar.gz | Diff File | ||
mod - Base/QTCore/Testing/Data/Input/19615-macosx-amd64-LoadableExtensionTemplate-svn19615-2012-03-18.tar.gz | Diff File | ||
mod - Base/QTCore/Testing/Data/Input/19615-macosx-amd64-ScriptedLoadableExtensionTemplate-svn19615-2012-03-18.tar.gz | Diff File | ||
mod - Base/QTCore/Testing/Data/Input/19615-macosx-amd64-SuperBuildLoadableExtensionTemplate-svn19615-2012-03-18.tar.gz | Diff File | ||
mod - Base/QTCore/qSlicerCoreApplication.cxx | Diff File | ||
mod - Base/QTCore/qSlicerCoreApplication.h | Diff File | ||
mod - Base/QTCore/qSlicerCoreApplication_p.h | Diff File | ||
mod - Base/QTCore/qSlicerCoreCommandOptions.cxx | Diff File | ||
mod - Base/QTCore/qSlicerCoreCommandOptions.h | Diff File | ||
mod - Base/QTCore/qSlicerExtensionsManagerModel.cxx | Diff File | ||
mod - Base/QTCore/qSlicerExtensionsManagerModel.h | Diff File | ||
mod - Base/QTCore/qSlicerLoadableModuleFactory.cxx | Diff File | ||
mod - Base/QTGUI/qSlicerExtensionsManagerDialog.cxx | Diff File | ||
mod - Base/QTGUI/qSlicerScriptedLoadableModuleFactory.cxx | Diff File | ||
mod - Base/QTGUI/qSlicerSettingsExtensionsPanel.cxx | Diff File | ||
mod - Base/QTGUI/qSlicerSettingsGeneralPanel.cxx | Diff File | ||
mod - Base/QTGUI/qSlicerSettingsModulesPanel.cxx | Diff File | ||
mod - CMake/SlicerConfig.cmake.in | Diff File | ||
mod - CMake/UseSlicer.cmake.in | Diff File | ||
mod - CMake/vtkSlicerConfigure.h.in | Diff File | ||
mod - CMakeLists.txt | Diff File | ||
mod - Modules/Loadable/Colors/qSlicerColorsModule.cxx | Diff File | ||
mod - Modules/Scripted/Scripts/DICOM.py | Diff File | ||
mod - SuperBuild.cmake | Diff File | ||
mod - SuperBuild/External_CTK.cmake | Diff File | ||
mod - SuperBuild/External_CTKAPPLAUNCHER.cmake | Diff File |
Date Modified | Username | Field | Change |
---|---|---|---|
2012-11-01 14:54 | pieper | New Issue | |
2012-11-01 14:54 | pieper | Status | new => assigned |
2012-11-01 14:54 | pieper | Assigned To | => jcfr |
2012-11-01 14:54 | pieper | File Added: Screen Shot 2012-11-01 at 6.48.02 PM.png | |
2012-11-01 15:37 | jcfr | Relationship added | related to 0002533 |
2012-11-05 12:42 | jcfr | Note Added: 0007062 | |
2012-11-05 13:37 | jcfr | Note Added: 0007065 | |
2012-11-06 09:44 | jcfr | Note Added: 0007076 | |
2012-11-07 17:40 | jcfr | Note Added: 0007117 | |
2012-11-07 17:40 | jcfr | Status | assigned => feedback |
2012-11-13 06:29 | pieper | Note Added: 0007181 | |
2012-11-13 06:41 | jcfr | Note Added: 0007182 | |
2012-11-13 06:44 | jcfr | Relationship added | related to 0002143 |
2012-11-15 08:36 | jcfr | Target Version | Slicer 4.2.1 => Slicer 4.2.2 |
2012-11-15 08:50 | jcfr | Note Added: 0007247 | |
2012-12-06 14:33 | jcfr | Note Added: 0007437 | |
2012-12-06 14:33 | jcfr | Status | feedback => resolved |
2012-12-06 14:33 | jcfr | Fixed in Version | => Slicer 4.2.2 |
2012-12-06 14:33 | jcfr | Resolution | open => fixed |
2012-12-06 14:35 | jcfr | Relationship added | related to 0002822 |
2014-03-06 04:53 | jcfr | Note Added: 0010760 | |
2014-03-06 04:55 | jcfr | Status | resolved => closed |
2017-06-07 23:27 | jcfr | Changeset attached | => Slicer 2145-support-for-installing-extension-from-file e6fb116c |
2017-06-07 23:27 | jcfr | Note Added: 0014675 |