View Issue Details

IDProjectCategoryView StatusLast Update
0002717Slicer4Module Markupspublic2014-03-06 04:58
Reporterfinetjul Assigned Tonicole  
PrioritynormalSeverityfeatureReproducibilityhave not tried
Status closedResolutionfixed 
Product VersionSlicer 4.2.0 
Target VersionSlicer 4.3.0Fixed in VersionSlicer 4.3.0 
Summary0002717: Add shortcuts for annotations
Description

Here are some ideas for shortcuts:

  • in persistent mode, right click to stop being in persistent mode
  • some key (or right button?) to start a drop mode. Example of a workflow: I'm dropping 1 fiducial, then I want to rotate the view, and want to drop another fiducial without having to go to the Annotations toolbar.

In 3D view, maybe the Control key controls the mouse mode. Once the key is down, the place mode is down, and the next click (while having control down) drops a point. If the user release the key, then the place mode is off.

TagsNo tags attached.

Relationships

has duplicate 0001877 closednicole key binding to place fiducial 

Activities

nicole

nicole

2013-07-09 08:18

administrator   ~0008949

Last edited: 2013-07-18 13:23

Markups module adds the 'p' key to place a fiducial (currently only enabled if in place mode).

nicole

nicole

2013-07-18 13:24

administrator   ~0009133

In persistent mode, do you want a right click to leave persistent mode, leaving you in place mode (one more left click will place a fiducial and then it will go back to view transform mode), or do you want a right click to take you out of place mode, leaving persistent mode enabled for the next time place mode is entered?

finetjul

finetjul

2013-07-18 13:30

administrator   ~0009134

I believe 2nd option makes more sense to me (-> right click takes you out of place mode leaving persistent mode enabled for next time)

nicole

nicole

2013-07-18 14:16

administrator   ~0009137

Last edited: 2013-07-19 06:25

A quick test shows that using the right button release event is clashing with the seed widget, the seeds aren't getting unlocked properly after place mode is exited, and I'm often getting a seed "sticking" to the mouse, stuck in move mode. I'll probably have to use a shortcut key instead.

Another quick test shows that this worked well on the Annotations seed widget on linux, while not working with the Markups seed widget on Mac - more testing needed.

nicole

nicole

2013-08-23 11:12

administrator   ~0009573

I got the right click to stop place mode working in the Markups module (in 3D only so far though), as of svn 22317[1]. p key will place them under the mouse pointer while in persistent mode as well. Let me know if you need more keyboard shortcuts. I do plan to add the d key to delete fiducials when the mouse is over them.

[1] http://viewvc.slicer.org/viewvc.cgi/Slicer4?view=revision&revision=22317

finetjul

finetjul

2013-08-23 12:50

administrator   ~0009583

Whatever we decide, I think we should be consistent between the 2D and the 3D view.

Maybe the right click I suggested is not a good solution as it would clash with the zoom.
How about the Escape key instead ? Or maybe simply define a QAction that controls the "place" state (on/off).

Here is a suggestion (here I suggest that we don't use more than 1 key (p?) for all the fiducials):

  • 'p' down and release (no action between down and release): toggle place mode
  • 'p' down + left click: drop an annotation (whatever is the currently selected annotation in the mouse toolbar ) even if we are not in "place" mode
  • 'p' down + 'del' (or backspace): deletes the last annotation dropped
  • 'p' down + ... + escape : cancel the actions when 'p' was down (it's bonus! :-P )
  • right click (down and release) on a fiducial: open the Annotations/Markup module and select the point.
  • 'del' down and release over fiducial: delete the fiducial
nicole

nicole

2013-08-23 13:01

administrator   ~0009585

There has to be a key press without mouse click to place fiducials, as precise placement sometimes requires that the mouse not be moved even by accident when pressing the mouse button. The p key was used in Slicer3 which is is why I went back to it.

Other than that, I don't have strong feelings one way or another, maybe open up the discussion to the users list?

jcfr

jcfr

2014-03-06 04:56

administrator   ~0010837

Closing resolved issues that have not been updated in more than 3 months

Issue History

Date Modified Username Field Change
2012-11-01 07:46 finetjul New Issue
2012-11-01 07:46 finetjul Status new => assigned
2012-11-01 07:46 finetjul Assigned To => nicole
2013-07-09 08:18 nicole Note Added: 0008949
2013-07-09 08:18 nicole Category Module Annotations => Module Markups
2013-07-18 13:23 nicole Note Edited: 0008949
2013-07-18 13:24 nicole Note Added: 0009133
2013-07-18 13:30 finetjul Note Added: 0009134
2013-07-18 14:16 nicole Note Added: 0009137
2013-07-19 06:25 nicole Note Edited: 0009137
2013-07-19 06:25 nicole Note Edited: 0009137
2013-08-23 11:12 nicole Note Added: 0009573
2013-08-23 11:12 nicole Status assigned => resolved
2013-08-23 11:12 nicole Fixed in Version => Slicer 4.3.0
2013-08-23 11:12 nicole Resolution open => fixed
2013-08-23 11:20 nicole Relationship added has duplicate 0001877
2013-08-23 12:50 finetjul Note Added: 0009583
2013-08-23 13:01 nicole Note Added: 0009585
2014-03-06 04:56 jcfr Note Added: 0010837
2014-03-06 04:58 jcfr Status resolved => closed