View Issue Details

IDProjectCategoryView StatusLast Update
0002276Slicer4Core: Building (CMake, Superbuild)public2012-07-27 15:23
Reporterjcfr Assigned Tojcfr  
PrioritynormalSeverityminorReproducibilityhave not tried
Status closedResolutionfixed 
Product Version 
Target VersionSlicer 4.2.0Fixed in VersionSlicer 4.2.0 
Summary0002276: Fix numpy build error where gfortran is installed
Description

See http://slicer-devel.65872.n3.nabble.com/Error-compiling-NUMPY-tp4025345p4025389.html

TagsNo tags attached.

Relationships

related to 0002280 closedjcfr Numpy - Do not expect developer to uninstall g77 
related to 0002249 closedjcfr numpy.linalg.det does not work 

Activities

jcfr

jcfr

2012-06-28 11:16

administrator   ~0004975

From Hans - June 28 2012

FYI:

I think I figured it out but for a different reason than previously
mentioned.

http://projects.scipy.org/numpy/ticket/182
-set(ENV{LDFLAGS} "@CMAKE_LINKER_FLAGS@ @CMAKE_LINKER_FLAGS_RELEASE@")
+set(ENV{LDFLAGS} "") ## NOTE THIS MUST BE BLANK OR THE FORTRAN COMPILER
FAILS!

Perhaps both items need to be done.

Hans

mccormic

mccormic

2012-06-28 11:56

developer   ~0004977

I was struggling with this issue, too, and I think Hans solution is correct. This regression only occurred after those environmental variables were set. The following patch fixes the problem for me:

https://github.com/thewtex/Slicer/tree/2276-numpy-clpack-link

fedorov

fedorov

2012-06-28 11:59

developer   ~0004978

Reassigning to Matt, as he has already branched the fix.

fedorov

fedorov

2012-06-28 12:00

developer   ~0004979

oops, Matt is not a "developer" ..

mccormic

mccormic

2012-06-28 12:26

developer   ~0004980

Hans has a fix here:

https://github.com/hjmjohnson/Slicer/commit/8cd337234c8ac9405eb5e74aabe80dd21bc4c194

although it does not work yet for me, as commented inline related to the fortran setup.

I appreciate the new developer role, but I'm punting to Hans so he gets credit for resolving the issue.

jcfr

jcfr

2012-06-29 12:29

administrator   ~0004996

See http://viewvc.slicer.org/viewvc.cgi/Slicer4?view=revision&revision=20520

jcfr

jcfr

2012-06-29 12:29

administrator   ~0004997

See http://viewvc.slicer.org/viewvc.cgi/Slicer4?view=revision&revision=20523,
http://viewvc.slicer.org/viewvc.cgi/Slicer4?view=revision&revision=20524,
http://viewvc.slicer.org/viewvc.cgi/Slicer4?view=revision&revision=20525,
and http://viewvc.slicer.org/viewvc.cgi/Slicer4?view=revision&revision=20526

jcfr

jcfr

2012-06-29 15:49

administrator   ~0005004

From Steve - June 29 2012:

CMake Error at /usr/local/share/cmake-2.8/Modules/CMakeFortranInformation.cmake:27 (GET_FILENAME_COMPONENT):

get_filename_component called with incorrect number of arguments
Call Stack (most recent call first):
SuperBuild/External_NUMPY.cmake:4 (enable_language)

CMake/SlicerMacroCheckExternalProjectDependency.cmake:56 (include)
SuperBuild.cmake:127 (SlicerMacroCheckExternalProjectDependency)
CMakeLists.txt:449 (include)

Errors occurred during the last pass
CMake Version 2.8.8

jcfr

jcfr

2012-06-29 19:14

administrator   ~0005011

COMP: Do not use Fortran compiler on windows

See http://viewvc.slicer.org/viewvc.cgi/Slicer4?view=revision&revision=20534

fedorov

fedorov

2012-06-30 06:55

developer   ~0005012

Trying to configure clean Slicer checkout, I have the error below. Snow Leopard, cmake 2.8.8, Qt 4.7.4.

CMake Error at /Users/fedorov/local/share/cmake-2.8/Modules/CMakeDetermineFortranCompiler.cmake:31
(MESSAGE):
Could not find compiler set in environment variable FC:

CMAKE_Fortran_COMPILER-NOTFOUND.
Call Stack (most recent call first):
SuperBuild/External_NUMPY.cmake:11 (enable_language)
CMake/SlicerMacroCheckExternalProjectDependency.cmake:56 (include)
SuperBuild.cmake:127 (SlicerMacroCheckExternalProjectDependency)
CMakeLists.txt:449 (include)

CMake Error: Error required internal CMake variable not set, cmake may be not be built correctly.
Missing variable is:
CMAKE_Fortran_COMPILER_ENV_VAR

CMake Error: Could not find cmake module
file:/Users/fedorov/Slicer/Slicer4-SuperBuild/CMakeFiles/CMakeFortranCompiler.cmake

fedorov

fedorov

2012-06-30 06:56

developer   ~0005013

svn r20534

jcfr

jcfr

2012-06-30 23:31

administrator   ~0005018

Could somebody try the topic I referenced in this note: http://www.na-mic.org/Bug/view.php?id=2249#c5017

fedorov

fedorov

2012-07-01 14:01

developer   ~0005021

JC, I tested with https://github.com/jcfr/Slicer/tree/2249-fix-numpy-runtime-issue.

There was no numpy configuration problem with cmake. gcc 4.2.1, Snow Leopard.

Should we keep this issue open until that branch is merged into Slicer svn trunk?

jcfr

jcfr

2012-07-01 14:36

administrator   ~0005027

Thanks for checking, this is very helpful. Will be checking that it works on Windows .. and will be integrating the change.

As soon as I integrate into the trunk, I will be resolving the issue.

jcfr

jcfr

2012-07-01 18:30

administrator   ~0005031

Fixed in r20539
See http://viewvc.slicer.org/viewvc.cgi/Slicer4?view=revision&revision=20539

Issue History

Date Modified Username Field Change
2012-06-28 10:53 jcfr New Issue
2012-06-28 10:53 jcfr Status new => assigned
2012-06-28 10:53 jcfr Assigned To => jcfr
2012-06-28 10:53 jcfr Assigned To jcfr => fedorov
2012-06-28 10:53 jcfr Target Version => Slicer 4.2.0 - Sept 1st 2012
2012-06-28 11:16 jcfr Note Added: 0004975
2012-06-28 11:56 mccormic Note Added: 0004977
2012-06-28 11:59 fedorov Note Added: 0004978
2012-06-28 12:00 fedorov Note Added: 0004979
2012-06-28 12:02 jcfr Assigned To fedorov => mccormic
2012-06-28 12:26 mccormic Note Added: 0004980
2012-06-28 12:26 mccormic Assigned To mccormic => hjmjohnson
2012-06-29 12:29 jcfr Note Added: 0004996
2012-06-29 12:29 jcfr Note Added: 0004997
2012-06-29 12:31 jcfr Relationship added related to 0002280
2012-06-29 12:32 jcfr Status assigned => resolved
2012-06-29 12:32 jcfr Fixed in Version => Slicer 4.2.0 - Sept 1st 2012
2012-06-29 12:32 jcfr Resolution open => fixed
2012-06-29 15:49 jcfr Note Added: 0005004
2012-06-29 19:14 jcfr Note Added: 0005011
2012-06-30 06:55 fedorov Note Added: 0005012
2012-06-30 06:55 fedorov Status resolved => feedback
2012-06-30 06:55 fedorov Resolution fixed => reopened
2012-06-30 06:56 fedorov Note Added: 0005013
2012-06-30 23:30 jcfr Relationship added related to 0002249
2012-06-30 23:31 jcfr Note Added: 0005018
2012-06-30 23:31 jcfr Status feedback => resolved
2012-06-30 23:31 jcfr Resolution reopened => fixed
2012-07-01 14:01 fedorov Assigned To hjmjohnson => jcfr
2012-07-01 14:01 fedorov Note Added: 0005021
2012-07-01 14:01 fedorov Status resolved => feedback
2012-07-01 14:01 fedorov Resolution fixed => reopened
2012-07-01 14:36 jcfr Note Added: 0005027
2012-07-01 18:30 jcfr Note Added: 0005031
2012-07-01 18:30 jcfr Status feedback => resolved
2012-07-01 18:30 jcfr Resolution reopened => fixed
2012-07-27 15:23 jcfr Status resolved => closed