View Issue Details
ID | Project | Category | View Status | Date Submitted | Last Update |
---|---|---|---|---|---|
0002249 | Slicer4 | Core: Scripting (Wrapping, Python) | public | 2012-06-22 05:48 | 2012-08-16 12:28 |
Reporter | bmoloney | Assigned To | jcfr | ||
Priority | normal | Severity | major | Reproducibility | always |
Status | closed | Resolution | fixed | ||
Product Version | Slicer 4.1.0 | ||||
Target Version | Slicer 4.2.0 | Fixed in Version | Slicer 4.2.0 | ||
Summary | 0002249: numpy.linalg.det does not work | ||||
Description | This occurs in my own build, but also the 4.1 binary release.
| ||||
Tags | No tags attached. | ||||
I also installed nose and tried running the numpy test suite. This seems to show multiple issues in numpy.linalg and actually crashes while running these tests. The relevant output: test_cdouble (test_linalg.TestCond2) ... ERROR |
|
After investigating, it resumes it is pointless to compile CLAPACK and build numpy against it. Indeed, the modules "blas_lite.c" and "dlapack_lite.c" already bundle part of CLAPACK that are required by "linalg" numpy module. While looking for the root cause of the problem, I also realized that CLAPACK can't be linked against numpy. The "f2c.h" bundled within clapack-3.2.1-CMAKE.tgz is different from the "f2c.h" available in "numpy/linalg" folder. For example, the typedefs used to specify "integer" or "uinteger" are different. In clapack/INCLUDE/f2c.h => "integer" is defined as "long int" Within the python module "lapack_litemodule.c", we can read that the function signature used to specify the function to link against is of the form: extern int foo_(char arg1, char arg2, int *n) whereas in CLapack, the same function is defined as: int foo_(char arg1, char arg2, integer *n) // integer being "long int" This difference in type was causing the error reported in the bug. This apply at least from numpy 1.4.1 to 1.6.2 The following topic resolved the issue on linux: https://github.com/jcfr/Slicer/tree/2249-fix-numpy-runtime-issue Note: Will have to test it on both windows and macosx. Associated commit: https://github.com/jcfr/Slicer/commit/fd21352c9212f64c5a1b40b2f3356e3a0f5dc17f On linux 64bit (Ubuntu 10.04), the following numpy test suite run without => nose version 1.1.2
OK (KNOWNFAIL=4, SKIP=12) Details (package by package)
OK
OK
OK
OK
OK
OK (KNOWNFAIL=4, SKIP=11)
OK
OK
OK (SKIP=1)
OK
OK |
|
bmoloney> Would be great if you could try the topic I referenced in the previous note. Thanks |
|
Tested with https://github.com/jcfr/Slicer/tree/2249-fix-numpy-runtime-issue. I followed the steps in the original report, and there was no error.
|
|
I also tried to do the nose tests, but that did not work: [fedorov@bear nose-1.1.2] pwd
|
|
Andriy> Edit ~/nose.cfg and remove the like having "with doc test". That should do it. |
|
The file I had to edit was nose-1.1.2/setup.cfg [fedorov@bear Slicer-Superbuild] ./python-build/bin/python
OK (KNOWNFAIL=4, SKIP=1)
OK (SKIP=1)
OK
OK
OK
OK (KNOWNFAIL=4)
OK
OK
OK
OK |
|
Fixed in r20539 |
|
Dear issue reporter, Good news :) Slicer developers SOLVED the problem you reported - YOU now need to VERIFY and CLOSE this issue. |
|
Sorry for my delayed response. I can confirm the issue is resolved now. Thanks so much for the hard work! |
|
Date Modified | Username | Field | Change |
---|---|---|---|
2012-06-22 05:48 | bmoloney | New Issue | |
2012-06-22 05:48 | bmoloney | Status | new => assigned |
2012-06-22 05:48 | bmoloney | Assigned To | => jcfr |
2012-06-22 07:58 | bmoloney | Note Added: 0004908 | |
2012-06-30 23:21 | jcfr | Note Added: 0005017 | |
2012-06-30 23:23 | jcfr | Note Edited: 0005017 | |
2012-06-30 23:30 | jcfr | Relationship added | related to 0002276 |
2012-06-30 23:32 | jcfr | Note Added: 0005019 | |
2012-06-30 23:32 | jcfr | Status | assigned => feedback |
2012-06-30 23:39 | jcfr | Relationship added | duplicate of 0002193 |
2012-07-01 14:03 | fedorov | Note Added: 0005022 | |
2012-07-01 14:19 | fedorov | Note Added: 0005024 | |
2012-07-01 14:34 | jcfr | Note Added: 0005025 | |
2012-07-01 14:41 | fedorov | Note Added: 0005028 | |
2012-07-01 18:29 | jcfr | Note Added: 0005029 | |
2012-07-01 18:29 | jcfr | Status | feedback => resolved |
2012-07-01 18:29 | jcfr | Fixed in Version | => Slicer 4.2.0 - Sept 1st 2012 |
2012-07-01 18:29 | jcfr | Resolution | open => fixed |
2012-07-01 18:30 | jcfr | Target Version | => Slicer 4.2.0 - Sept 1st 2012 |
2012-07-27 15:42 | jcfr | Note Added: 0005411 | |
2012-08-16 12:28 | bmoloney | Note Added: 0005561 | |
2012-08-16 12:28 | bmoloney | Status | resolved => closed |