View Issue Details

Jump to NotesJump to History
IDProjectCategoryView StatusDate SubmittedLast Update
0002180Slicer4Core: GUIpublic2012-06-10 14:002012-07-30 07:18
Reporterfinetjul Assigned Tocrmullin  
PrioritynormalSeverityfeatureReproducibilityN/A
Status closedResolutionfixed 
Product VersionSlicer 4.1.0 
Target VersionSlicer 4.2.0Fixed in VersionSlicer 4.2.0 
Summary0002180: Remove "home" module from toolbar
Description

The modules in the favorite module toolbar can be configured, which means that the special icon for the "Home" module is not useful anymore. In addition, the home icon doesn't really represent the module itself, it's own icon should be used instead. It's better to remove it completely from the UI.
However, the functionality should be kept: the home module is the module that shows up at Slicer startup. It should still be possible to choose the home module from the Application settings.

TagsNo tags attached.

Relationships

related to 0002161 closedcrmullin Adding CLI modules to favorite modules list does not work 

Activities

jcfr

jcfr

2012-06-10 14:26

administrator   ~0004796

Sounds good to me.
crmullin

crmullin

2012-06-11 06:15

developer   ~0004802

Here's a draft:
https://github.com/chrismullins/Slicer/commit/8e25e77755b8ac16d6dbaa3461bf05ef3d8486d4

This commit simply removes "Home" as an option in the module toolbar. However, one may still choose the default module in the application settings, but the label has been renamed.

I considered possibly renaming some of the methods regarding home such as setHomeModuleCurrent(), etc., but the concept of the default module upon opening slicer being the "home" module remains intact so I didn't.
jcfr

jcfr

2012-06-29 16:07

administrator   ~0005005

Chris> Do you receive github notification ? Few notes have been added to this topic, make sure to consider them and re-push a new topic. Thanks
crmullin

crmullin

2012-06-30 14:23

developer   ~0005015

I receive them on my other google account, thanks for the reminder.

https://github.com/chrismullins/Slicer/commit/249401bdb133d7175575b69a09ab125f7104a3ef
crmullin

crmullin

2012-07-02 09:41

developer   ~0005036

Commit message changed:
https://github.com/chrismullins/Slicer/commit/4f5fec44e2206ae7f963311052bb8ffd46d0495c
finetjul

finetjul

2012-07-02 09:46

administrator   ~0005037

technically it's an "ENH" not a "BUG"
crmullin

crmullin

2012-07-02 10:45

developer   ~0005038

Right.

https://github.com/chrismullins/Slicer/commit/0fbca98a299c2d4857dbdd37cce82c1e762e8756
crmullin

crmullin

2012-07-02 13:49

developer   ~0005046

Fixed in r20547
See http://viewvc.slicer.org/viewvc.cgi/Slicer4?view=revision&revision=20547
jcfr

jcfr

2012-07-27 15:40

administrator   ~0005391

Dear issue reporter,

Good news :) Slicer developers SOLVED the problem you reported - YOU now need to VERIFY and CLOSE this issue.

Issue History

Date Modified Username Field Change
2012-06-10 14:00 finetjul New Issue
2012-06-10 14:00 finetjul Status new => assigned
2012-06-10 14:00 finetjul Assigned To => crmullin
2012-06-10 14:07 finetjul Summary Remove "home" module => Remove "home" module from toolbar
2012-06-10 14:07 finetjul Description Updated
2012-06-10 14:08 finetjul Relationship added related to 0002161
2012-06-10 14:26 jcfr Note Added: 0004796
2012-06-11 06:15 crmullin Note Added: 0004802
2012-06-29 16:07 jcfr Note Added: 0005005
2012-06-29 16:07 jcfr Status assigned => feedback
2012-06-29 16:09 jcfr ETA none => < 1 day
2012-06-29 16:09 jcfr Target Version => Slicer 4.2.0 - Sept 1st 2012
2012-06-30 14:23 crmullin Note Added: 0005015
2012-07-02 09:41 crmullin Note Added: 0005036
2012-07-02 09:46 finetjul Note Added: 0005037
2012-07-02 10:45 crmullin Note Added: 0005038
2012-07-02 13:49 crmullin Note Added: 0005046
2012-07-02 13:49 crmullin Status feedback => resolved
2012-07-02 13:49 crmullin Fixed in Version => Slicer 4.2.0 - Sept 1st 2012
2012-07-02 13:49 crmullin Resolution open => fixed
2012-07-27 15:40 jcfr Note Added: 0005391
2012-07-30 07:18 finetjul Status resolved => closed