View Issue Details

Jump to NotesJump to History
IDProjectCategoryView StatusDate SubmittedLast Update
0002115Slicer4Core: Building (CMake, Superbuild)public2012-05-23 15:282013-08-27 11:37
Reporterjcfr Assigned Tojcfr  
PrioritynormalSeverityminorReproducibilityhave not tried
Status closedResolutionfixed 
Product Version 
Target VersionSlicer 4.3.0Fixed in VersionSlicer 4.3.0 
Summary0002115: Mechanism to customize Slicer package name depending on build option
Description

Use case:
If we want to be able to build and upload both ITKv3 and ITKv4 slicer packages, the corresponding package name will have to be different.

TagsITKv4

Relationships

child of 0002007 closedjcfr Build against ITKv4 and remove ITKv3 
child of 0002371 closedcrmullin Update factory ITKv4 nightly script to enable packaging 

Activities

jcfr

jcfr

2012-07-27 11:59

administrator   ~0005280

See http://viewvc.slicer.org/viewvc.cgi/Slicer4?view=revision&revision=20707
and http://viewvc.slicer.org/viewvc.cgi/Slicer4?view=revision&revision=20708

The variable allowing to customize the package name is now exposed. Still need to expose a CMake option allow to append a prefix to it.
jcfr

jcfr

2012-07-27 15:54

administrator   ~0005427

The idea would be to for example have an advanced build option named:

Slicer_PACKAGE_NAME_SUFFIX

This option would then be used to change line 77 of SlicerCPack.cmake [1] into:

set(CPACK_PACKAGE_NAME ${${Slicer_MAIN_PROJECT}_APPLICATION_NAME}${Slicer_PACKAGE_NAME_SUFFIX})

[1] http://viewvc.slicer.org/viewvc.cgi/Slicer4/trunk/CMake/SlicerCPack.cmake?annotate=20708&pathrev=20708#l77
crmullin

crmullin

2012-08-03 14:48

developer   ~0005498

Last edited: 2012-08-03 15:12

On my machine, this generates a package from CPack called Slicer-ITKv4-4.1.0-2012-08-01-linux-amd64.tar.gz

https://github.com/chrismullins/Slicer/commit/de97af99e4842a5d0ffa9fe6f485a9d6bc6f39cf
jcfr

jcfr

2012-12-16 14:01

administrator   ~0007507

When will will transition to ITKv4, we will switch completely and won't have to maintain to set of packages.

Issue History

Date Modified Username Field Change
2012-05-23 15:28 jcfr New Issue
2012-05-23 15:28 jcfr Status new => assigned
2012-05-23 15:28 jcfr Assigned To => jcfr
2012-05-23 15:28 jcfr Relationship added child of 0002007
2012-05-23 15:29 jcfr Target Version => Slicer 4.3.0
2012-05-27 08:32 jcfr Target Version Slicer 4.3.0 => Slicer 4.2.0 - Sept 1st 2012
2012-07-27 11:59 jcfr Note Added: 0005280
2012-07-27 15:54 jcfr Note Added: 0005427
2012-07-27 16:03 jcfr Relationship added child of 0002371
2012-08-03 14:48 crmullin Note Added: 0005498
2012-08-03 15:12 crmullin Note Edited: 0005498
2012-08-20 10:11 jcfr Target Version Slicer 4.2.0 - Feature freeze Sept 1st 2012 => Slicer 4.2.5
2012-08-21 09:40 jcfr Target Version Slicer 4.2.5 => Slicer 4.3.0
2012-11-30 09:35 jcfr Tag Attached: ITKv4
2012-12-16 14:01 jcfr Note Added: 0007507
2012-12-16 14:01 jcfr Status assigned => resolved
2012-12-16 14:01 jcfr Fixed in Version => Slicer 4.2.3
2012-12-16 14:01 jcfr Resolution open => fixed
2013-02-12 09:40 jcfr Fixed in Version Slicer 4.2.3 => Slicer 4.3.0
2013-08-27 11:37 jcfr Status resolved => closed