View Issue Details

IDProjectCategoryView StatusLast Update
0001398Slicer4Core: GUIpublic2017-11-22 10:11
Reporterpieper Assigned Topinter  
PrioritynormalSeverityminorReproducibilityalways
Status closedResolutionfixed 
Product Version 
Target VersionSlicer 4.4.0Fixed in VersionSlicer 4.4.0 
Summary0001398: Edit Properties... doesn't exist everywhere
Description

In slicer3, the NodeSelector included an Edit Properties menu item so that you could easily get, for example, to the Volumes module from the Slice Controller.

This seems to be missing from the corresponding qMRMLComboBox in slicer4 and would be useful to add back.

The Edit Properties option does exist in the Data Module right click menu, but recently stopped working, probably due to the capitalization changes in the module - see output below.

Additional Information

The module "transforms" has not been registered.
The following modules have been registered: ("Cameras", "SliceController", "Transforms", "Data", "Colors", "EventBroker", "VolumeRendering", "CropVolume", "SceneViews", "Annotations", "Models", "TractographyFiducialSeeding", "Tractography", "Welcome", "TractographyDisplay", "Volumes", "LabelStatistics", "PerformanceTests", "Endoscopy", "SampleData", "DICOM2FullBrainTractography", "DataProbe", "DICOM", "Editor")

TagsNo tags attached.

Relationships

related to 0002109 closedpinter Edit properties in Data module does not switch to the correct object 

Activities

finetjul

finetjul

2011-09-09 04:35

administrator   ~0002951

"Edit properties..." in Data module is fixed in r18002:
http://viewvc.slicer.org/viewvc.cgi/Slicer4?view=revision&revision=18002

Concerning the option of having "Edit properties..." in every node selector, that requires that qMRMLNodeComboBox knows about the application, which it doesn't in qMRMLWidgets.
One way of fixing it is to create qSlicerNodeComboBox in QtGUI.
For RSNA ?

pieper

pieper

2011-09-09 04:42

administrator   ~0002952

Agreed, it's not an RSNA priority. Just wanted to get this into the system.

To avoid the 'knowing about the application' issue, I think we need some kind of factory like mechanism - so that modules can register their ability to operate on or edit certain node types (much like file extensions or mime types get registered with a file browser). That way the qMRMLNodeComboBox can be kept generic.

finetjul

finetjul

2011-09-09 04:48

administrator   ~0002954

I agree with the "modules can register their ability to operate on or edit certain node types". Right now it's a hack in qSlicerApplication.

finetjul

finetjul

2012-05-23 11:17

administrator   ~0004581

Note to developer: some work has been done already to make room for qSlicerModuleManager to receive that work.
a) Modules should register their nodes in qSlicerModuleManager, and
b) qSlicerApplication::nodeModule should be moved into qSlicerModuleManager.

Icons for each node type could also be registered here as well. Or maybe in vtkMRMLApplicationLogic to be accessible from qMRMLWidgets (especially. qMRMLSceneModel::updateItemFromNode() which can give an icon to items in qMRMLNodeComboBox )

nicole

nicole

2013-08-21 11:53

administrator   ~0009541

Additional request:
In the nodeTypeLabel() method of the node combo box, it calls GetTagByClassName on the mrml scene to generate the label. This can lead to not user friendly strings in the GUI since it's using the XML node tag defined by the MRML nodes. I'd like to see an additional method on vtkMRMLNode that can be called instead of GetNodeTagName, such as GetNodeLabelName that can return a human readable string for use in the GUI.

pinter

pinter

2014-02-25 11:13

developer   ~0010637

According to the discussion
https://www.assembla.com/spaces/slicerrt/wiki/20140225_Slicer_hangout_about_subject_hierarchy
the Edit properties feature will be provided by the subject hierarchy plugin mechanism

pinter

pinter

2014-06-30 13:41

developer   ~0012113

Subject hierarchy plugins expose an Edit properties feature that is to be implemented in every "role plugin" (see http://www.slicer.org/slicerWiki/index.php/Documentation/Labs/SubjectHierarchy#Plugin_types).
The plugins implemented in Slicer core (Volumes, Models, Markups) contain this feature and the future plugins handling other types also should. Suggestions for plugins are welcome (so far SceneViews was requested)

pinter

pinter

2017-11-22 10:11

developer   ~0015434

This issue has been fixed in two ways

Issue History

Date Modified Username Field Change
2011-09-08 04:35 pieper New Issue
2011-09-08 04:35 pieper Status new => assigned
2011-09-08 04:35 pieper Assigned To => finetjul
2011-09-09 04:35 finetjul Note Added: 0002951
2011-09-09 04:42 pieper Note Added: 0002952
2011-09-09 04:48 finetjul Note Added: 0002954
2011-09-09 04:48 finetjul Target Version => Slicer 4.0 post RSNA
2012-05-23 11:06 lassoan Relationship added related to 0002109
2012-05-23 11:17 finetjul Note Added: 0004581
2012-10-22 07:36 jcfr Target Version Slicer 4.0.1 => Slicer 4.3.0
2013-08-09 04:30 finetjul Target Version Slicer 4.3.0 => Slicer 4.4.0
2013-08-21 11:53 nicole Note Added: 0009541
2014-02-25 11:13 pinter Note Added: 0010637
2014-03-06 10:35 nicole Assigned To finetjul => pinter
2014-06-30 13:41 pinter Note Added: 0012113
2014-06-30 13:41 pinter Status assigned => resolved
2014-06-30 13:41 pinter Fixed in Version => Slicer 4.4.0
2014-06-30 13:41 pinter Resolution open => fixed
2017-11-22 09:16 pinter Status resolved => closed
2017-11-22 10:11 pinter Note Added: 0015434