View Issue Details

IDProjectCategoryView StatusLast Update
0001376Slicer4Core: Packagingpublic2014-03-31 23:56
Reporterpieper Assigned Tocrmullin  
PriorityhighSeverityminorReproducibilityalways
Status closedResolutionduplicate 
PlatformwindowsOSOS Version
Product Version 
Target VersionSlicer 4.4.0Fixed in VersionSlicer 4.4.0 
Summary0001376: logo is missing from windows installed launcher
Description

Back in June the logo was there, but now it's missing. See screen shot.

TagsNo tags attached.

Relationships

duplicate of 0001156 closedjcfr Slicer launcher to embed Slicer icon 
related to 0001603 closedcrmullin The windows installer does not show the slicer logo 

Activities

2011-08-29 05:22

 

pieper

pieper

2011-08-29 05:23

administrator   ~0002836

If it matters, this was the 32 bit nightly build installed on a 64 bit windows 7 machine.

jcfr

jcfr

2012-06-25 15:33

administrator   ~0004935

Test and integrate to Slicer the work done by Benjamin.
See https://github.com/benjaminlong/Resedit

Since Benjaming will be leaving at the end of the week, would be great if you could have a look before Friday. That way you could ask him quesions.

Thanks
Jc

crmullin

crmullin

2012-06-27 07:06

developer   ~0004946

Just talked with Ben about this: was your intention to have it integrated within the applauncher? It seems like ResEdit could be downloaded, built, and run during the build of Slicer.

jcfr

jcfr

2012-06-27 07:19

administrator   ~0004947

It should be integrated into Slicer build system, ResEdit is somewhat independent of the AppLauncher itself.

In a nutshell, on windows only Slicer superbuild will download ResEdit binary (ResEdit should be a dependency of the launcher)

A convenient CMake macro or function provided by resEdit would allow to "patch" the launcher executable so that it include the slice icon.

The development of the macro can be done outside of Slicer tree.

Macro could be named:

resedit_update_executable_icon(executable_path icon
_path)

Let me know if you have any other question.
Thanks
Jc

pieper

pieper

2013-01-22 13:06

administrator   ~0007719

For reference, this is how the slicer3 launcher icons were set (only runs on windows)

http://viewvc.slicer.org/viewvc.cgi/Slicer3/trunk/Utilities/Launcher/win32-icons.tcl?revision=15041&view=markup

pieper

pieper

2013-07-04 13:20

administrator   ~0008844

It would be great to see this fixed for the 4.3 release.

jcfr

jcfr

2014-03-31 23:55

administrator   ~0011494

Last edited: 2014-03-31 23:57

Closing this issue. Duplicate of 0001156

Issue History

Date Modified Username Field Change
2011-08-29 05:22 pieper New Issue
2011-08-29 05:22 pieper Status new => assigned
2011-08-29 05:22 pieper Assigned To => jcfr
2011-08-29 05:22 pieper File Added: rdesktop - fisk.bwh.harvard.edu_108.png
2011-08-29 05:23 pieper Note Added: 0002836
2012-02-01 10:14 finetjul Relationship added related to 0001603
2012-06-25 15:33 jcfr Note Added: 0004935
2012-06-25 15:33 jcfr Assigned To jcfr => crmullin
2012-06-25 15:35 jcfr Relationship replaced has duplicate 0001603
2012-06-27 07:06 crmullin Note Added: 0004946
2012-06-27 07:19 jcfr Note Added: 0004947
2012-10-22 07:35 jcfr Assigned To crmullin => jcfr
2012-10-22 07:35 jcfr Target Version Slicer 4.0.0 => Slicer 4.2.0 - coming release
2012-10-22 14:27 jcfr Target Version Slicer 4.2.0 - coming release => Slicer 4.3.0
2012-10-22 14:27 jcfr Relationship replaced related to 0001603
2013-01-22 12:52 jcfr Assigned To jcfr => crmullin
2013-01-22 12:52 jcfr Priority normal => high
2013-01-22 13:06 pieper Note Added: 0007719
2013-01-24 15:13 jcfr Relationship added has duplicate 0001156
2013-07-04 13:20 pieper Note Added: 0008844
2013-08-30 12:46 jcfr Target Version Slicer 4.3.0 => Slicer 4.3.1
2013-10-04 00:52 jcfr Target Version Slicer 4.3.1 => Slicer 4.3.2
2014-03-06 10:15 nicole Target Version Slicer 4.3.2 => Slicer 4.4.0
2014-03-31 23:55 jcfr Note Added: 0011494
2014-03-31 23:55 jcfr Relationship replaced duplicate of 0001156
2014-03-31 23:55 jcfr Duplicate ID 0 => 1156
2014-03-31 23:55 jcfr Status assigned => resolved
2014-03-31 23:55 jcfr Fixed in Version => Slicer 4.4.0
2014-03-31 23:55 jcfr Resolution open => fixed
2014-03-31 23:55 jcfr Status resolved => closed
2014-03-31 23:56 jcfr Resolution fixed => duplicate
2014-03-31 23:57 jcfr Note Edited: 0011494