View Issue Details

IDProjectCategoryView StatusLast Update
0000076Slicer3Base Codepublic2008-12-03 08:37
Reporterleue Assigned Topieper  
PrioritynormalSeverityminorReproducibilityalways
Status closedResolutionfixed 
Summary0000076: Slice index not being set correctly for output of command line module
Description

This is a bit complicated, so please bear with me: I have a command line module that accepts set of slices and emits a single 2D slice. If I set up a 2D display window to view the input slices and offset the slice (using the slider) so that the slice index is not zero, then when my command line module finishes and the 2D window switches to display the output 2D slice from the command-line module, the image index does not switch to zero as it should. (It should be zero because the output of the module is only a single 2D slice, and therefore it only has slice index zero. However, the 2D window still shows the non-zero slice index from when it was displaying one of the input slices, and so the output single slice does not display.

To fix it, I have to click the slice slider to the right of its drag handle, and then click the slider to the left of the drag handle to reset the index to zero. The handle can't be dragged because the number of slices is only 1.

Additional Information

The solution should be to look at the number of slices in the incoming data set, and to reset the slice index to something sensible (like the center image) if the current slice index is out of range.

I see this problem on Windows XP, SP2, but I suspect it is present in all builds.

TagsNo tags attached.

Activities

pieper

pieper

2007-08-15 12:21

administrator   ~0000107

Yes, a single slice is a special case that may not be handled right. I'll have a look at it.

pieper

pieper

2008-05-30 11:16

administrator   ~0000349

This is related to the problem with tkScale.

http://sourceforge.net/tracker/index.php?func=detail&aid=1899040&group_id=12997&atid=112997

Absent a fix to tk, probably we'll need to replace the scale widget with something else.

pieper

pieper

2008-06-09 05:47

administrator   ~0000357

This bug (or a similar one) also can cause the editor to apply an operation to the incorrect slice. I.e. one slice above or below the currently visible slice.

pwainwright

pwainwright

2008-06-11 06:56

reporter   ~0000359

The patch to vtkSlicerSliceControllerWidget::ProcessWidgetEvents is buggy and has broken the scale widget completely. It no longer calls this->SliceLogic->SetSliceOffset when moved.

It seems to be comparing the value before and after rounding, rather than the new value of the scale and the value of GetSliceOffset()! I'm not certain what is supposed to happen here...

pieper

pieper

2008-06-11 07:27

administrator   ~0000360

Sorry about that - I left a half-patch checked in last night. I just checked in what I hope is the fix. We'll see!

pieper

pieper

2008-12-03 08:37

administrator   ~0000479

I believe this is fixed now. I can load a single slice image and it shows up with a 0 offset (and the slider cannot be moved).

Issue History

Date Modified Username Field Change
2007-06-05 08:49 leue New Issue
2007-08-15 12:21 pieper Note Added: 0000107
2007-08-15 12:21 pieper Assigned To => pieper
2007-08-15 12:21 pieper Status new => assigned
2008-05-30 11:16 pieper Note Added: 0000349
2008-06-09 05:47 pieper Note Added: 0000357
2008-06-11 06:56 pwainwright Note Added: 0000359
2008-06-11 07:27 pieper Note Added: 0000360
2008-12-03 08:37 pieper Note Added: 0000479
2008-12-03 08:37 pieper Status assigned => closed
2008-12-03 08:37 pieper Resolution open => fixed