View Issue Details

Jump to NotesJump to History
IDProjectCategoryView StatusDate SubmittedLast Update
0004424Slicer4Module DICOMpublic2017-08-25 21:352017-08-26 20:24
Reporterfedorov Assigned Tolassoan  
PrioritynormalSeverityblockReproducibilityalways
Status closedResolutionfixed 
Product VersionSlicer 4.7.0 
Target VersionFixed in Version 
Summary0004424: DICOM db directory can be created in non-writeable location when starting Slicer for the first time
Description

if Slicer is run for the first time, the setting
value for DatabaseDirectory will be empty, leading to setting of the
directory location to a non-writeable (on mac) /Applications (current
directory for the Slicer app)

The default to current working directory is in CTK here:

https://github.com/commontk/CTK/blob/master/Libs/DICOM/Widgets/ctkDICOMBrowser.cpp#L236-L241

promptForDatabaseDirectory() is called after DICOMWidget is created, so it falls back to default: https://github.com/Slicer/Slicer/blame/master/Modules/Scripted/DICOMLib/DICOMWidgets.py#L81-L84

Inside promptForDatabaseDirectory(), there is no check for DatabaseDirectory setting being None: https://github.com/Slicer/Slicer/blob/master/Modules/Scripted/DICOMLib/DICOMWidgets.py#L504

Steps To Reproduce

Remove Slicer settings, start Slicer, check DICOM directory location.

TagsNo tags attached.

Activities

fedorov

fedorov

2017-08-25 22:26

developer   ~0015084

wip in https://github.com/Slicer/Slicer/pull/782
fedorov

fedorov

2017-08-26 20:24

developer   ~0015085

resolved in https://github.com/Slicer/Slicer/commit/5f013eefb1698aeb0c2c60db60cc0018620fd694

Issue History

Date Modified Username Field Change
2017-08-25 21:35 fedorov New Issue
2017-08-25 21:35 fedorov Status new => assigned
2017-08-25 21:35 fedorov Assigned To => pieper
2017-08-25 22:26 fedorov Note Added: 0015084
2017-08-26 20:23 fedorov Assigned To pieper => lassoan
2017-08-26 20:24 fedorov Note Added: 0015085
2017-08-26 20:24 fedorov Status assigned => closed
2017-08-26 20:24 fedorov Resolution open => fixed