I think the easiest will be to stub out the LHA support in our own fork. That way we don't need to change the factory clang, which is likely to have other side effects.

@jcfr if you agree I can do take care of this.

to having our own fork of libarchive and just turn off this format.

Agreed. Since this is related to older compiler and we will move the build to a newer system soon, disabling LHA is the way to go.

Thanks for your help. Would be great if you could submit a patch.

Here is the convention for Slicer specific branches on our fork. See https://www.slicer.org/wiki/Documentation/Nightly/Developers/Versioning#Patches_for_tagged_release

Let me know if you have any questions,
Jc

@dzenanz Could you confirm that the current Slicer trunk also build on your workstation ?

Thanks for the pointers - I'll try to work on it this afternoon or maybe this weekend. Of course if anyone else wants to take this on feel free! I hope it's just this one issue.

Just to confirm Jc the factory is still using the version of clang as described in [1] and [2]? Independent of libarchive we'll probably be wanting to update that at some point. Have we tested if it works with vtk8, c++11, and Qt5?

[1] https://www.slicer.org/wiki/Documentation/Nightly/Developers/Factory

[2] http://slicer-devel-archive.65872.n3.nabble.com/MacOSX-factory-build-Transitioning-from-hybrid-quot-llvm-g-quot-to-quot-clang-quot-Update-to-Qt-4-8-6-tt4032198.html#a4032199

if anyone else wants to take this on feel free!

I will have a look later this morning and keep you posted

factory is still using the version of clang as described in [1] and [2]

Yes

Have we tested if it works with vtk8, c++11, and Qt5?

Slicer will be moved to a newer macOS. We testing this build on "factory-south" instead of "factory"

Fix integrated in r26206
See http://viewvc.slicer.org/viewvc.cgi/Slicer4?view=revision&revision=26206 and https://github.com/Slicer/libarchive/commit/e8a11f40901212f5d25e2f03938c5410aa9f6a3c

Thanks Jc!

You are welcome.

Note: I have only tested on Linux and MacOSX. And I am confident it will not break windows.

If there are issues, I will follow up on Monday