View Issue Details

Jump to NotesJump to History
IDProjectCategoryView StatusDate SubmittedLast Update
0004384Slicer4Core: Segmentationpublic2017-06-14 03:472017-06-17 16:11
Reporterpinter Assigned Topinter  
PrioritynormalSeverityminorReproducibilityalways
Status closedResolutionfixed 
Product VersionSlicer 4.7.0 
Target VersionSlicer 4.7.0Fixed in VersionSlicer 4.7.0 
Summary0004384: Switch to None effect in Segment Editor when entering into markup placement mode
Description

When the user is editing, and wants to place a markup, then they need to disable the active segment editor effect first. However, by clicking the markup placement button, they already expressed that instead of using the effect, they want to place a markup. So disabling the effect in this case would make sense.

TagsNo tags attached.

Activities

lassoan

lassoan

2017-06-16 20:46

developer   ~0014900

Fixed in r26102
pinter

pinter

2017-06-17 05:48

developer   ~0014902

Thanks a lot Andras!

One minor comment and a question:
Why do we need the interactionNodeChanged function in AbstractScriptedSegmentEditorEffect.py? It has a scriptedEffect member which is the C++ implementation. That's how we call all the API functions, and interactionNodeChanged is the one exception now.
I think instead of interactionNodeChanged a better name would be interactionNodeModified. Changed suggests that the node pointer itself is different. It seems to be connected to the singleton node's Modified event.

I've updated and started a build, will close after testing. Thanks!
lassoan

lassoan

2017-06-17 09:26

developer   ~0014903

Good points - fixed both in r26104.
pinter

pinter

2017-06-17 16:11

developer   ~0014904

Thank you! It works well too, I'm closing the issue.

Issue History

Date Modified Username Field Change
2017-06-14 03:47 pinter New Issue
2017-06-14 03:47 pinter Status new => assigned
2017-06-14 03:47 pinter Assigned To => pinter
2017-06-16 20:46 lassoan Status assigned => resolved
2017-06-16 20:46 lassoan Resolution open => fixed
2017-06-16 20:46 lassoan Fixed in Version => Slicer 4.7.0
2017-06-16 20:46 lassoan Note Added: 0014900
2017-06-16 20:47 lassoan Target Version Slicer 4.8.1 => Slicer 4.7.0
2017-06-17 05:48 pinter Note Added: 0014902
2017-06-17 09:26 lassoan Note Added: 0014903
2017-06-17 16:11 pinter Status resolved => closed
2017-06-17 16:11 pinter Note Added: 0014904