View Issue Details

Jump to NotesJump to History
IDProjectCategoryView StatusDate SubmittedLast Update
0004380Slicer4Core: Building (CMake, Superbuild)public2017-06-10 13:102017-06-13 14:21
Reporterdzenanz Assigned Tojcfr  
PrioritynormalSeverityblockReproducibilityalways
Status closedResolutionfixed 
PlatformVisual Studio 2013 x64OSWindowsOS Version7
Product VersionSlicer 4.7.0 
Target VersionFixed in VersionSlicer 4.7.0 
Summary0004380: Slicer does not build (CMake error duplicate ELSE)
Description

Excerpt from the build log:

11> CMake Error at cmake/UnitTests.cmake:271 (else):
11> A duplicate ELSE command was found inside an IF block.
11> Call Stack (most recent call first):
11> CMakeLists.txt:587 (include)

Additional Information

Content of buildDir\python\cmake\UnitTests.cmake (line 266-273):

list(APPEND unittests "test_pep277")
if(PY_VERSION_PATCH LESS 12)
list(APPEND unittests "test_pep292")
else()
list(APPEND unittests "test_string")
else()
endif()
list(APPEND unittests "test_pep352")

TagsNo tags attached.

Activities

dzenanz

dzenanz

2017-06-10 13:12

developer   ~0014732

CMake version: 3.9.0-rc2
dzenanz

dzenanz

2017-06-10 13:35

developer   ~0014733

Probably caused by this PR:
https://gitlab.kitware.com/cmake/cmake/merge_requests/594
lassoan

lassoan

2017-06-13 00:59

developer   ~0014800

Thanks for reporting this.
Does removing the second else() fixes the issue (do tests still pass)?
Could you send a pull request with the fix?
dzenanz

dzenanz

2017-06-13 09:02

developer   ~0014803

I assume there would be no problems when the second else is removed. I don't know where should I make the change/pull request (I kind of remember that Python is extracted from a zip file). Pointing me where the change should take place is half a solution.
lassoan

lassoan

2017-06-13 11:00

developer   ~0014808

This is the repository, you can send a pull request there:
https://github.com/python-cmake-buildsystem/python-cmake-buildsystem
jcfr

jcfr

2017-06-13 11:56

administrator   ~0014810

Thanks for the report.

This should be fixed after this PR is integrated and Slicer updated. See https://github.com/python-cmake-buildsystem/python-cmake-buildsystem/pull/186
jcfr

jcfr

2017-06-13 13:12

administrator   ~0014812

Fixed by r26086
See http://viewvc.slicer.org/viewvc.cgi/Slicer4?view=revision&revision=26086

Issue History

Date Modified Username Field Change
2017-06-10 13:10 dzenanz New Issue
2017-06-10 13:10 dzenanz Status new => assigned
2017-06-10 13:10 dzenanz Assigned To => jcfr
2017-06-10 13:12 dzenanz Note Added: 0014732
2017-06-10 13:35 dzenanz Note Added: 0014733
2017-06-13 00:59 lassoan Note Added: 0014800
2017-06-13 09:02 dzenanz Note Added: 0014803
2017-06-13 11:00 lassoan Note Added: 0014808
2017-06-13 11:56 jcfr Note Added: 0014810
2017-06-13 13:12 jcfr Status assigned => resolved
2017-06-13 13:12 jcfr Resolution open => fixed
2017-06-13 13:12 jcfr Fixed in Version => Slicer 4.7.0
2017-06-13 13:12 jcfr Note Added: 0014812
2017-06-13 14:21 dzenanz Status resolved => closed