View Issue Details
| ID | Project | Category | View Status | Date Submitted | Last Update |
|---|---|---|---|---|---|
| 0004323 | Slicer4 | Module DICOM | public | 2017-01-09 09:40 | 2017-06-08 01:51 |
| Reporter | fepegar | Assigned To | pieper | ||
| Priority | normal | Severity | minor | Reproducibility | always |
| Status | closed | Resolution | fixed | ||
| Platform | Linux | OS | Ubuntu | OS Version | 14.04 |
| Product Version | Slicer 4.6.1 | ||||
| Target Version | Fixed in Version | Slicer 4.7.0 | |||
| Summary | 0004323: "Close" button missing from DICOM module | ||||
| Description | When I open the DICOM browser, I have to close it with Alt+F4 because the "close" button is not visible. "Minimize" is also missing, but "maximize/restore" is still there. | ||||
| Tags | No tags attached. | ||||
|
I see that same behavior on linux. But not on Mac or Windows. Must be something about the way dialog boxes from Qt interact with the X11 window managers. I have no idea how to fix the issue, but I do note that unless you have "persistent browser" enabled on the dicom browser it will go away when you exit the DICOM module. I suspect this is a good enough workaround for most uses? |
|
|
Hi Steve, I'm glad you could reproduce. When I enable "Browser persistent" I don't see the behavior you commented. Also, I guess that if the window is maximized it'll be difficult to switch to a different module. |
|
|
I don't see a way to change this behavior without a re-write of the browser top level container (maybe make it not be a dialog on linux or something). Maybe someone who knows more about linux window managers can suggest something. As-is the usability seems workable to me, even if not optimal: the window can be maximized/unmaximized as needed. And it is only visible in the DICOM module by default, but can be pinned to stay open with the "Browser persistent" option. |
|
|
On further investigation I found this also was a problem with the Metadata dialog and there was no way to close it. |
|
|
This adds close button to both widgets: http://viewvc.slicer.org/viewvc.cgi/Slicer4?view=revision&revision=26047 |
|
|
Import 2017-06-07 23:51:09: master be0c09f1 2017-05-25 13:11:57 Details Diff |
BUG: 0004323 add close button to DICOM widgets Without the hint, there was no way to close these windows on certain OS/window managers (e.g. ubuntu 14.04, 16.04). From: Steve Pieper <pieper@isomics.com> git-svn-id: http://svn.slicer.org/Slicer4/trunk@26047 3bd1e089-480b-0410-8dfb-8563597acbee |
||
| mod - Modules/Scripted/DICOMLib/DICOMWidgets.py | Diff File | ||
| Date Modified | Username | Field | Change |
|---|---|---|---|
| 2017-01-09 09:40 | fepegar | New Issue | |
| 2017-01-09 09:40 | fepegar | Status | new => assigned |
| 2017-01-09 09:40 | fepegar | Assigned To | => pieper |
| 2017-01-27 12:04 | pieper | Note Added: 0014323 | |
| 2017-01-27 12:04 | pieper | Status | assigned => acknowledged |
| 2017-01-30 07:45 | fepegar | Note Added: 0014324 | |
| 2017-01-30 10:46 | pieper | Note Added: 0014326 | |
| 2017-01-30 10:46 | pieper | Status | acknowledged => closed |
| 2017-01-30 10:46 | pieper | Resolution | open => not fixable |
| 2017-05-25 13:37 | pieper | Note Added: 0014491 | |
| 2017-05-25 13:37 | pieper | Status | closed => feedback |
| 2017-05-25 13:37 | pieper | Resolution | not fixable => reopened |
| 2017-05-25 13:38 | pieper | Note Added: 0014492 | |
| 2017-05-25 13:38 | pieper | Status | feedback => closed |
| 2017-05-25 13:38 | pieper | Resolution | reopened => fixed |
| 2017-05-25 13:38 | pieper | Fixed in Version | => Slicer 4.7.0 |
| 2017-06-08 01:51 | pieper | Changeset attached | => Slicer master be0c09f1 |