View Issue Details
ID | Project | Category | View Status | Date Submitted | Last Update |
---|---|---|---|---|---|
0004309 | Slicer4 | Core: Segmentation | public | 2016-11-28 16:31 | 2018-03-02 11:00 |
Reporter | lassoan | Assigned To | lassoan | ||
Priority | normal | Severity | minor | Reproducibility | always |
Status | closed | Resolution | fixed | ||
Product Version | Slicer 4.7.0 | ||||
Target Version | Slicer 4.7.0 | Fixed in Version | Slicer 4.7.0 | ||
Summary | 0004309: Model nodes exported from segments may appear in incorrect position when transformed | ||||
Description | How to reproduce:
| ||||
Tags | No tags attached. | ||||
@lassoan I am not able to reproduce following the following steps:
=> model is exported under the transform 1 (the one associated with the segmentation) Is this is the expected behavior ? |
|
I tested and I found the same as Jc. After exporting the segmentation to the same model hierarchy (in which the model was under a different transform than the segmentation), the model's parent transform was set to the same as the segmentation's. |
|
Thanks for testing this. The problem happens only when Segmentation is in the root (no transformation is applied) and the target Model node is under a transform. In that case the Model node's transform is not removed. I'll commit a fix shortly. |
|
Makes sense. Probably the SetAndObserveParentTransformNode was inside an "if (segmentationNode->GetParentTransformNode() != NULL)", and it was not propagated when the segmentation was in the root. |
|
That was exactly the problem. |
|
Fixed in r26423 |
|
Great, thanks! |
|
Date Modified | Username | Field | Change |
---|---|---|---|
2016-11-28 16:31 | lassoan | New Issue | |
2016-11-28 16:31 | lassoan | Status | new => assigned |
2016-11-28 16:31 | lassoan | Assigned To | => lassoan |
2017-10-04 21:59 | jcfr | Note Added: 0015254 | |
2017-10-04 21:59 | jcfr | Status | assigned => feedback |
2017-10-05 14:58 | pinter | Note Added: 0015255 | |
2017-10-05 16:38 | lassoan | Note Added: 0015258 | |
2017-10-05 16:49 | pinter | Note Added: 0015260 | |
2017-10-05 16:53 | lassoan | Note Added: 0015261 | |
2017-10-05 16:53 | lassoan | Status | feedback => resolved |
2017-10-05 16:53 | lassoan | Resolution | open => fixed |
2017-10-05 16:53 | lassoan | Fixed in Version | => Slicer 4.7.0 |
2017-10-05 16:53 | lassoan | Note Added: 0015262 | |
2017-10-05 16:54 | pinter | Note Added: 0015263 | |
2018-03-02 11:00 | jcfr | Status | resolved => closed |