View Issue Details

IDProjectCategoryView StatusLast Update
0004309Slicer4Core: Segmentationpublic2018-03-02 11:00
Reporterlassoan Assigned Tolassoan  
PrioritynormalSeverityminorReproducibilityalways
Status closedResolutionfixed 
Product VersionSlicer 4.7.0 
Target VersionSlicer 4.7.0Fixed in VersionSlicer 4.7.0 
Summary0004309: Model nodes exported from segments may appear in incorrect position when transformed
Description

How to reproduce:

  • Export segmentation to a model node => model appears in correct position
  • Place model node under a different transform
  • Export segmentation to the same model node => model appears in incorrect position (it would appear in correct position if it was still under the same transform as the segmentation node)
TagsNo tags attached.

Activities

jcfr

jcfr

2017-10-04 21:59

administrator   ~0015254

@lassoan I am not able to reproduce following the following steps:

  • Create Segmentation using Paint effect and show in 3D
  • Add segmentation under linear transform 1, update transform 1
  • Export segmentation to model
  • Add model under a new transform 2
  • update Segmentation
  • re-export segmentation

=> model is exported under the transform 1 (the one associated with the segmentation)
=> newly exported model is not related with transform 2 anymore

Is this is the expected behavior ?

pinter

pinter

2017-10-05 14:58

developer   ~0015255

I tested and I found the same as Jc. After exporting the segmentation to the same model hierarchy (in which the model was under a different transform than the segmentation), the model's parent transform was set to the same as the segmentation's.

lassoan

lassoan

2017-10-05 16:38

developer   ~0015258

Thanks for testing this. The problem happens only when Segmentation is in the root (no transformation is applied) and the target Model node is under a transform. In that case the Model node's transform is not removed. I'll commit a fix shortly.

pinter

pinter

2017-10-05 16:49

developer   ~0015260

Makes sense. Probably the SetAndObserveParentTransformNode was inside an "if (segmentationNode->GetParentTransformNode() != NULL)", and it was not propagated when the segmentation was in the root.

lassoan

lassoan

2017-10-05 16:53

developer   ~0015261

That was exactly the problem.

lassoan

lassoan

2017-10-05 16:53

developer   ~0015262

Fixed in r26423

pinter

pinter

2017-10-05 16:54

developer   ~0015263

Great, thanks!

Issue History

Date Modified Username Field Change
2016-11-28 16:31 lassoan New Issue
2016-11-28 16:31 lassoan Status new => assigned
2016-11-28 16:31 lassoan Assigned To => lassoan
2017-10-04 21:59 jcfr Note Added: 0015254
2017-10-04 21:59 jcfr Status assigned => feedback
2017-10-05 14:58 pinter Note Added: 0015255
2017-10-05 16:38 lassoan Note Added: 0015258
2017-10-05 16:49 pinter Note Added: 0015260
2017-10-05 16:53 lassoan Note Added: 0015261
2017-10-05 16:53 lassoan Status feedback => resolved
2017-10-05 16:53 lassoan Resolution open => fixed
2017-10-05 16:53 lassoan Fixed in Version => Slicer 4.7.0
2017-10-05 16:53 lassoan Note Added: 0015262
2017-10-05 16:54 pinter Note Added: 0015263
2018-03-02 11:00 jcfr Status resolved => closed