View Issue Details

Related ChangesetsJump to NotesJump to History
IDProjectCategoryView StatusDate SubmittedLast Update
0004305Slicer4Core: Segmentationpublic2016-11-18 02:112017-06-10 08:51
Reporterjcfr Assigned Tolassoan  
PrioritynormalSeverityminorReproducibilityalways
Status closedResolutionfixed 
Product VersionSlicer 4.7.0 
Target VersionSlicer 4.7.0Fixed in VersionSlicer 4.7.0 
Summary0004305: vtkSegmentation.cxx: Is unused parameter "targetRepresentationName" warning a real issue ?
Description

/home/jcfr/Projects/Slicer/Libs/vtkSegmentationCore/vtkSegmentation.cxx:957:63: warning: unused parameter ‘targetRepresentationName’ [-Wunused-parameter]
bool vtkSegmentation::CreateRepresentation(const std::string& targetRepresentationName,
^

TagsNo tags attached.

Activities

pinter

pinter

2016-12-08 16:29

developer   ~0014267

That argument is not necessary because the second argument "path" contains that information as well. Probably it's best to simply remove the first argument. It's only used from qMRMLSegmentationConversionParametersWidget::applyConversion()
jcfr

jcfr

2016-12-08 16:38

administrator   ~0014268

Thanks to Csaba, fixed in 25597
See http://viewvc.slicer.org/viewvc.cgi/Slicer4?view=revision&revision=25597

Related Changesets

Import 2017-06-07 23:51:09: master 67a342fd

2016-12-08 16:24:28

jcfr

Details Diff 		STYLE: vtkSegmentation: Fix unused "targetRepresentationName" warning

Warning fixed is:

/path/to/Slicer/Libs/vtkSegmentationCore/vtkSegmentation.cxx:957:63: warning: unused parameter ‘targetRepresentationName’ [-Wunused-parameter]
bool vtkSegmentation::CreateRepresentation(const std::string& targetRepresentationName,
^
Fixes 0004305

Suggested-by: Csaba Pinter <csaba.pinter@queensu.ca>

git-svn-id: http://svn.slicer.org/Slicer4/trunk@25597 3bd1e089-480b-0410-8dfb-8563597acbee
mod - Libs/vtkSegmentationCore/vtkSegmentation.cxx Diff File
mod - Libs/vtkSegmentationCore/vtkSegmentation.h Diff File
mod - Modules/Loadable/Segmentations/Widgets/qMRMLSegmentationConversionParametersWidget.cxx Diff File

Issue History

Date Modified Username Field Change
2016-11-18 02:11 jcfr New Issue
2016-11-18 02:11 jcfr Status new => assigned
2016-11-18 02:11 jcfr Assigned To => lassoan
2016-12-08 16:29 pinter Note Added: 0014267
2016-12-08 16:38 jcfr Note Added: 0014268
2016-12-08 16:38 jcfr Status assigned => resolved
2016-12-08 16:38 jcfr Fixed in Version => Slicer 4.7.0
2016-12-08 16:38 jcfr Resolution open => fixed
2016-12-08 16:38 jcfr Status resolved => closed
2017-06-10 08:51 jcfr Changeset attached => Slicer master 67a342fd