View Issue Details

Jump to NotesJump to History
IDProjectCategoryView StatusDate SubmittedLast Update
0004297Slicer4Core: Base Codepublic2016-11-08 14:452018-03-02 11:02
Reporterbpaniagua Assigned Tobpaniagua  
PrioritynormalSeveritymajorReproducibilityalways
Status closedResolutionfixed 
PlatformOSMac OS 10.11, Sci Linux 7.2OS Version
Product VersionSlicer 4.7.0 
Target VersionFixed in VersionSlicer 4.7.0 
Summary0004297: Applying transform to vtkPolyData using Transforms Module flips normals
Description

When applying a transform including a flip in one axis to a vtkPolyData, the normals of that vtkPolyData get flipped. SurfaceToolbox flip normals does not fix the problem in the vtkPolyData.

The only way I found to fix this problem is to use http://www.vtk.org/doc/nightly/html/classvtkPolyDataNormals.html to flip back the normals outwards.

Steps To Reproduce

Here is a screen capture video of the error reproduced, and how to fix it, using a command line tool that does the orientation of the normals https://github.com/NIRALUser/SPHARM-PDM/blob/master/Applications/MetaMeshTools/MeshMath.cxx#L4544-L4569

https://drive.google.com/open?id=0B_-M3LPWEF4zQ2I4VXFpb2wzN00

TagsNo tags attached.

Relationships

related to 0003122 closedjcfr Add ability to flip polygon normals - either use or clean up old code 

Activities

jcfr

jcfr

2016-11-09 16:52

administrator   ~0014247

Per our discussion:

  • Remove dead code from vtkSlicerModelsLogic (originally introduced in r12897 (ENH: bug 574: added Model Transform module))

  • Add method
    <pre>
    static vtkSlicerModelsLogic::FlipNormals(
    vtkMRMLModelNode inputModelNode,
    vtkMRMLModelNode     outputModelNode,
    bool autoOrientation = false)
    </pre>

  • Update SurfaceToolBox to use new code

  • May be worth looking into r25291 (STYLE: Remove unused loadable ModelMirror and ModelTransform logics). May be a "Mirror" category could be added to the surface toolbox ?

  • Update of the model display pipeline could be done as suggested in http://na-mic.org/Mantis/view.php?id=3122#c11764
lassoan

lassoan

2017-06-12 23:26

developer   ~0014792

Mirror and auto-orient normals options are now available in surface toolbox module.

Issue History

Date Modified Username Field Change
2016-11-08 14:45 bpaniagua New Issue
2016-11-08 14:45 bpaniagua Status new => assigned
2016-11-08 14:45 bpaniagua Assigned To => jcfr
2016-11-08 15:25 bpaniagua Assigned To jcfr => bpaniagua
2016-11-08 15:25 bpaniagua Steps to Reproduce Updated View Revisions
2016-11-09 16:20 jcfr Relationship added related to 0003122
2016-11-09 16:52 jcfr Note Added: 0014247
2017-06-12 23:26 lassoan Status assigned => resolved
2017-06-12 23:26 lassoan Resolution open => fixed
2017-06-12 23:26 lassoan Fixed in Version => Slicer 4.7.0
2017-06-12 23:26 lassoan Note Added: 0014792
2018-03-02 11:02 jcfr Status resolved => closed