0004291: SFLSSegmentor3D.txx : void function with return statement

ID	Project	Category	View Status	Date Submitted	Last Update

0004291	Slicer4	Module RobustStatisticsSegmenter	public	2016-11-01 14:07	2018-03-02 11:02

Reporter	nmset	Assigned To	jcfr
Priority	normal	Severity	major	Reproducibility	always
Status	closed	Resolution	fixed
Platform	Linux	OS	Linux	OS Version	kernel 4.8.4
Product Version
Target Version		Fixed in Version	Slicer 4.7.0

Summary	0004291: SFLSSegmentor3D.txx : void function with return statement
Description	After having painfully built Slicer, I consider that one issue needs to be reported. In file SFLSSegmentor3D.txx, function getZeroLayerAtIteration is declared void, but has a return statement. Using -fpermissive allows ignoring that.
Steps To Reproduce	vim <path_to>SFLSSegmentor3D.txx
Additional Information	(Sidenote : -std=c++98 is the key point on my system(g++ 6.2.1 20160830) that allowed the build to complete. All other C++ standards generated a build failure in BRAINSCommonLib, complaining VCL was built with another standard. There were other issues.)
Tags	No tags attached.

Import 2017-06-07 23:51:09: master daf00737 2016-11-12 03:46:01 jcfr Details Diff	COMP: RSS: Update getZeroLayerAtIteration() to return value. Fix 0004291 Suggested-by: S. EDAH-TALLY <chir.set@free.fr> Reported-by: S. EDAH-TALLY <chir.set@free.fr> git-svn-id: http://svn.slicer.org/Slicer4/trunk@25530 3bd1e089-480b-0410-8dfb-8563597acbee
	mod - Modules/CLI/RobustStatisticsSegmenter/SFLSSegmentor3D.h	Diff File
	mod - Modules/CLI/RobustStatisticsSegmenter/SFLSSegmentor3D.txx	Diff File

Date Modified	Username	Field	Change
2016-11-01 14:07	nmset	New Issue
2016-11-12 03:58	jcfr	Note Added: 0014249
2016-11-12 03:58	jcfr	Status	new => resolved
2016-11-12 03:58	jcfr	Fixed in Version	=> Slicer 4.7.0
2016-11-12 03:58	jcfr	Resolution	open => fixed
2016-11-12 03:58	jcfr	Assigned To	=> jcfr
2017-06-10 08:51	jcfr	Changeset attached	=> Slicer master daf00737
2018-03-02 11:02	jcfr	Status	resolved => closed

jcfr 2016-11-12 03:58 administrator ~0014249	Thanks for the report. This is now fixed in http://viewvc.slicer.org/viewvc.cgi/Slicer4?view=revision&revision=25530 As a side note, Slicer doesn't (yet) support c++11. Would it be helpful to update the build instruction ?