View Issue Details
ID | Project | Category | View Status | Date Submitted | Last Update |
---|---|---|---|---|---|
0004284 | Slicer4 | Core: Segmentation | public | 2016-10-20 10:41 | 2017-04-28 17:13 |
Reporter | fepegar | Assigned To | pinter | ||
Priority | normal | Severity | minor | Reproducibility | always |
Status | closed | Resolution | fixed | ||
Product Version | Slicer 4.6.0 | ||||
Target Version | Fixed in Version | Slicer 4.7.0 | |||
Summary | 0004284: Segment 0 is modified when modifying Segment 1 | ||||
Description | Steps: Segment 0 has almost disappeared, it looks like the difference between segment 1 and what segment 0 should be. | ||||
Tags | No tags attached. | ||||
I had a similar issue today after copying from one segment to a different one. And modifying the latter. |
|
Thanks, Fernando, for reporting this issue. We'll look into this ASAP. |
|
I cannot reproduce it using the latest nightly version. Please record a screen capture and attach it, along with the logs (menu: Help / Report a bug). Note that if "bypass masking" option is disabled and "Overwrite other segments" is "All segments" then it's expected that the segment overwrites all other segments (even the one that you've copied from). |
|
I agree with Andras. If Masking/Overwrite other segments is set to None, then smoothing only affects Segment_1. Segment_2 changes by default because the default masking setting does not allow overlaps. My opinion about setting the default masking to None (allow overwrites) is getting stronger and stronger. It seems that the advantage of having the old Editor behaviour by default is overshadowed by the surprises the users get, like this one. |
|
Depending on the use case, both overlap and overwrite behavior can be just as surprising. Maybe in the Logical effect we should enable overlap instead of temporarily disabling it (with the "bypass masking" checkbox)? |
|
slicer.log (11,235 bytes) |
|
I am using the latest nightly. What I'm doing: This seems to happen independently of the settings in the Masking area. What I expect: What I get: It gets funnier. After this, I click on Undo, click on segment A, apply interpolation and it happens on segment B, deleting again the info in segment A. I keep getting this error in the log (which I am attaching): Please let me know if you need any additional info. |
|
I'm not sure about Undo (it depends if you undo while auto-update is enabled, etc), but otherwise the behavior seems to be correct. You might have assumed that fill between contours is for the selected segment only, but it's actually for all visible segments (hide segments that you want to exclude from the interpolation). Also, masking settings are bypassed. Click on "more details" at the top of the effect options to see all details. How do you think we could make things simpler? |
|
I see. I did assume that Fill between contours was for the selected segment only. I understand now that I'm not dealing with a bug but with a misunderstanding of the module's logic. I feel like the term "bypass" might not be understandable for every user. Maybe "Ignore masking options" (as in the tool tip) would be clearer. Also, I think copying a segment is kind of a special operation in the sense that one doesn't expect the original thing that was copied to disappear. I'm not sure I'm being able to explain myself here. |
|
I've updated the effect help text according to your suggestions. Hopefully it'll be more clear. |
|
Date Modified | Username | Field | Change |
---|---|---|---|
2016-10-20 10:41 | fepegar | New Issue | |
2016-10-20 10:41 | fepegar | Status | new => assigned |
2016-10-20 10:41 | fepegar | Assigned To | => pinter |
2017-04-27 08:34 | fepegar | Note Added: 0014434 | |
2017-04-27 09:02 | pinter | Note Added: 0014435 | |
2017-04-27 09:15 | lassoan | Note Added: 0014436 | |
2017-04-27 10:32 | pinter | Note Added: 0014437 | |
2017-04-27 11:16 | lassoan | Note Added: 0014439 | |
2017-04-27 11:33 | fepegar | File Added: slicer.log | |
2017-04-27 11:35 | fepegar | Note Added: 0014442 | |
2017-04-27 11:47 | lassoan | Note Added: 0014443 | |
2017-04-28 06:46 | fepegar | Note Added: 0014454 | |
2017-04-28 17:12 | lassoan | Note Added: 0014464 | |
2017-04-28 17:12 | lassoan | Status | assigned => resolved |
2017-04-28 17:12 | lassoan | Fixed in Version | => Slicer 4.7.0 |
2017-04-28 17:12 | lassoan | Resolution | open => fixed |
2017-04-28 17:13 | lassoan | Status | resolved => closed |