View Issue Details
ID | Project | Category | View Status | Date Submitted | Last Update |
---|---|---|---|---|---|
0004239 | Slicer4 | Module Markups | public | 2016-07-28 08:06 | 2017-06-10 08:51 |
Reporter | fepegar | Assigned To | nicole | ||
Priority | high | Severity | crash | Reproducibility | always |
Status | closed | Resolution | fixed | ||
Platform | Linux | OS | Ubuntu | OS Version | 14.04 |
Product Version | Slicer 4.5.0-1 | ||||
Target Version | Fixed in Version | Slicer 4.6.0 | |||
Summary | 0004239: Slicer crashes when trying to delete many fiducial markups | ||||
Description | We mark neurons on 2D histological slices using the Markups module. Some lists could contain more than 400 neurons. Sometimes we try to delete a number of fiducials on the list and Slicer crashes, so all the work is gone. | ||||
Steps To Reproduce |
| ||||
Additional Information | Happens on Windows and Linux. Haven't tried on Mac. | ||||
Tags | markups, remove | ||||
TC2_882_ChAT_RH.fcsv (26,099 bytes) |
|
On Mac, Slicer hangs for a while but doesn't crash. Could you attach a stack trace/error log for the crash on linux or windows? |
|
I've sped up deleting fiducials with this commit: |
|
Hi Nicole, thanks for looking into this. What actually happens (Linux) is that Slicer becomes unresponsive and the windows gets white. So when I try to close it Ubuntu tells me it's unresponsive. The error log seems normal, but I can paste it here if you want. I just tried today's nightly on Linux and it took a while to delete my 100 fiducials, but at least it didn't crash. Is there some other way to keep speeding it up? Maybe disabling some events? We don't need many functionalities of the Markups for this project, and we only use the 2D views. |
|
Good to know, it was taking about 2 minutes to delete 100 fiducials on my Mac, but I let it run to time it, not trying to close it or interact with it. I didn't push that commit to the nightly yet as I wasn't sure if anything else was needed, so I'll do that now and the next nightly should show a significant speed up: |
|
I'll try again on Monday and let you know what happens. |
|
Merged as of svn 25253: |
|
It works perfectly. Thanks Nicole! |
|
Thanks for confirming! |
|
Import 2017-06-07 23:51:09: master a74feff8 2016-07-29 12:47:19 Details Diff |
ENH: Make it faster/easier to work with long fiducial lists Put Start/EndModify calls around removing a list of markups from the current node (speed up is significant when deleting 100 fiducials from a list of 272 fiducials) Automatically select the last loaded fiducial node when entering the Markups module if there are nodes loaded and none are selected. Adjust the right click context menu in the table: Use one line per markup, consolidating the label (use index if no label) and the coordinate (half the rows in the menu). Put the operations first in the menu in case so many are selected that part of the menu ends up off screen. Issue 0004239 From: Nicole Aucoin <nicole@bwh.harvard.edu> git-svn-id: http://svn.slicer.org/Slicer4/trunk@25253 3bd1e089-480b-0410-8dfb-8563597acbee |
||
mod - Modules/Loadable/Markups/Widgets/qSlicerSimpleMarkupsWidget.cxx | Diff File | ||
mod - Modules/Loadable/Markups/qSlicerMarkupsModuleWidget.cxx | Diff File |
Date Modified | Username | Field | Change |
---|---|---|---|
2016-07-28 08:06 | fepegar | New Issue | |
2016-07-28 08:06 | fepegar | Status | new => assigned |
2016-07-28 08:06 | fepegar | Assigned To | => nicole |
2016-07-28 08:06 | fepegar | File Added: TC2_882_ChAT_RH.fcsv | |
2016-07-28 08:06 | fepegar | Tag Attached: markups | |
2016-07-28 08:06 | fepegar | Tag Attached: remove | |
2016-07-28 08:07 | fepegar | Relationship added | related to 0004211 |
2016-07-28 08:09 | fepegar | Relationship added | related to 0001714 |
2016-07-28 08:09 | fepegar | Relationship added | related to 0003961 |
2016-07-28 08:10 | fepegar | Relationship deleted | related to 0003961 |
2016-07-28 15:21 | nicole | Note Added: 0014053 | |
2016-07-28 18:01 | nicole | Note Added: 0014054 | |
2016-07-29 06:24 | fepegar | Note Added: 0014055 | |
2016-07-29 10:26 | nicole | Note Added: 0014056 | |
2016-07-29 10:29 | fepegar | Note Added: 0014057 | |
2016-07-29 13:15 | nicole | Note Added: 0014058 | |
2016-07-29 13:15 | nicole | Status | assigned => resolved |
2016-07-29 13:15 | nicole | Fixed in Version | => Slicer 4.5.1 |
2016-07-29 13:15 | nicole | Resolution | open => fixed |
2016-08-01 06:20 | fepegar | Note Added: 0014062 | |
2016-08-01 06:20 | fepegar | Status | resolved => closed |
2016-08-01 06:20 | fepegar | Fixed in Version | Slicer 4.5.1 => Slicer 4.5.0-1 |
2016-08-01 06:21 | fepegar | Fixed in Version | Slicer 4.5.0-1 => Slicer 4.5.1 |
2016-08-01 11:51 | nicole | Note Added: 0014063 | |
2016-10-13 02:00 | jcfr | Fixed in Version | Slicer 4.5.1 => Slicer 4.6.0 |
2016-11-18 13:03 | fepegar | Relationship added | related to 0004306 |
2017-06-10 08:51 | pieper | Changeset attached | => Slicer master a74feff8 |