View Issue Details

IDProjectCategoryView StatusLast Update
0004216Slicer4Core: Documentation and Wikipublic2016-06-23 14:58
Reporterjcfr Assigned Togrundlett  
PrioritynormalSeverityminorReproducibilityhave not tried
Status closedResolutionfixed 
Product Version 
Target VersionSlicer 4.6.0Fixed in VersionSlicer 4.6.0 
Summary0004216: Wiki: Notify Slicer core developers when an account is created
Description

From Marianna to Steve, Jc, Ron, Nicole
Date: Fri, Jun 12, 2015

Since the email notification for slicer wiki account request is broken I am checking the requests periodically. [...]

// ----------------------
From Mike:
Date: Fri, Jun 12, 2015

Has the wiki mailing list issue been filed as a bug with help (or with Partners directly)?

// ----------------------
From Marianna:
Date: Fri, Jun 12, 2015

This is not a mailing list issue. It is the email notification for slicer wiki account requests (or in general all wiki account request). It is something to do with the LocalSetting.php file in the line of

$wgConfirmAccountContact = 'marianna@bwh.harvard.edu';

// ----------------------
From Mike:
Date: Fri, Jun 12, 2015

OK, has the wiki email notification issue been filed as a bug with help (or with Partners directly)?

// ----------------------
From Mike:
Date: Fri, Jun 14, 2015

Fabio made a change to the mail configuration on the web servers that might have fixed this problem. (Basically, he made sure that mail to localhost routes to the Partners mail gateway.)

Is there a quick way to test?

TagsNo tags attached.

Relationships

related to 0004222 closedgrundlett Wiki: Look into intermediary spam filtering associated with bwh mail system 

Activities

grundlett

grundlett

2016-06-21 14:40

administrator   ~0013999

There are over a million messages in root's email box on web1. There is a python script (cron) that generates mail every two minutes of the day. "/var/spool/mail/root": 1,288,345 messages 330,475 new 1,288,345 unread
U957841 root@d905-1.bwh.harv Fri Jan 17 10:22 28/1192 "Cron <root@d905-1> python < /usr/share/rhn/virtualization/poller.py" Since none of them have been read anyway, I purged them. Now I can test mailing on the machine and see whether notifications are working properly

grundlett

grundlett

2016-06-21 14:57

administrator   ~0014000

The poller.py script is generating an error and runs every two minutes.

It was touched in 2014, and the only thing the cron entry does is call poller.py (no notes)
-rw-r--r-- 1 root root 69 Sep 29 2014 /etc/cron.d/rhn-virtualization.cron

rpm -qf /usr/share/rhn/virtualization/poller.py

tells us that the file comes from rhn-virtualization-host-5.4.54-2.el5sat package

rpm -qi rhn-virtualization-host

shows us details about the package
Name : rhn-virtualization-host Relocations: (not relocatable)
Version : 5.4.54 Vendor: Red Hat, Inc.
Release : 2.el5sat Build Date: Mon 29 Sep 2014 03:28:29 AM EDT
Install Date: Tue 10 Feb 2015 02:29:49 PM EST Build Host: x86-022.build.eng.bos.redhat.com
Group : System Environment/Base Source RPM: rhn-virtualization-5.4.54-2.el5sat.src.rpm
Size : 234449 License: GPLv2
Signature : DSA/SHA1, Fri 19 Dec 2014 09:31:16 AM EST, Key ID 5326810137017186
Packager : Red Hat, Inc. <http://bugzilla.redhat.com/bugzilla>
URL : https://fedorahosted.org/spacewalk
Summary : RHN/Spacewalk Virtualization support specific to the Host system
Description :
This package contains code for RHN's and Spacewalk's Virtualization support
that is specific to the Host system (a.k.a. Dom0).

yum remove rhn-virtualization-host

Took care of the problem by removing the package and it's corresponding cron job that was doing nothing. If we want to setup virtualization at some point, then we can do so.

Subject: Cron <root@d905-1> python < /usr/share/rhn/virtualization/poller.py
Content-Type: text/plain; charset=UTF-8
Auto-Submitted: auto-generated
X-Cron-Env: <SHELL=/bin/sh>
X-Cron-Env: <HOME=/root>
X-Cron-Env: <PATH=/usr/bin:/bin>
X-Cron-Env: <LOGNAME=root>
X-Cron-Env: <USER=root>
Date: Tue, 21 Jun 2016 14:38:01 -0400 (EDT)

libvir: Xen Daemon error : unable to connect to 'localhost:8000': Connection refused
Traceback (most recent call last):
File "<stdin>", line 308, in ?
File "<stdin>", line 82, in poll_hypervisor
AttributeError: 'module' object has no attribute 'utf8_encode'

grundlett

grundlett

2016-06-21 15:12

administrator   ~0014001

Mail messages are going out as expected from the Wiki

Jun 21 14:57:12 d905-1 postfix/pickup[27492]: 2C88C855ECF: uid=0 from=<root>
Jun 21 14:57:12 d905-1 postfix/cleanup[27898]: 2C88C855ECF: message-id=<20160621185712.2C88C855ECF@d905-1.bwh.harvard.edu>
Jun 21 14:57:12 d905-1 postfix/qmgr[5327]: 2C88C855ECF: from=<root@d905-1.bwh.harvard.edu>, size=343, nrcpt=1 (queue active)
Jun 21 14:57:12 d905-1 postfix/smtp[27900]: 2C88C855ECF: to=<greg@equality-tech.com>, relay=phsmgout.partners.org[155.52.254.36]:25, delay=0.31, delays=0.05/0.02/0.24/0.01, dsn=2.0.0, status=sent (250 ok: Message 53279118 accepted)
Jun 21 14:57:12 d905-1 postfix/qmgr[5327]: 2C88C855ECF: removed

jcfr

jcfr

2016-06-21 15:18

administrator   ~0014002

going out as expected from the Wiki

Nice work

question: do you know if additional user could be added as wgConfirmAccountContact ?

Should we create a google group ?

See https://www.mediawiki.org/wiki/Extension:ConfirmAccount#Usage

jcfr

jcfr

2016-06-21 17:04

administrator   ~0014003

Archiving email sent to Greg:

I didn't get the email either.

Looking at the code, it looks like there are other options:

https://github.com/wikimedia/mediawiki-extensions-ConfirmAccount/blob/32dc740ef0d8233006221d244e98857fb32f7496/frontend/specialpages/actions/RequestAccount_body.php#L384-L408

Adding users to a group with "confirmaccount-notify" should do the job:

https://github.com/wikimedia/mediawiki-extensions-ConfirmAccount/blob/32dc740ef0d8233006221d244e98857fb32f7496/backend/ConfirmAccount.class.php#L312-L329

grundlett

grundlett

2016-06-21 17:35

administrator   ~0014004

Thanks JC, I did that actually. I assigned the 'confirmaccount-notify' permission to the sysop group so that all Administrators would get notified. And I also set myself to be the named contact in $wgConfirmAccountContact to simultaneously test the 'single user notification method'.

Then I made a fake request to test it. User "Foo"

I don't have permission to see the results in http://wiki.slicer.org/slicerWiki/index.php/Special:ConfirmAccounts but I can tell you that I did NOT receive the notification email. This is especially curious because email does work.

If the $wgConfirmAccountContact setting is not working, then it won't matter if that is a single person or a Google Groups list.

As an aside, I tried to use the maintenance script of createAndPromote to make myself a member of the bureaucrat group, but the script fails silently (even after I adjusted it for the fact that we're running an older version of PHP).

So, the issue might be bigger than just a setting. I believe the settings are all appropriate now.

$wgGroupPermissions['sysop']['confirmaccount-notify'] = true;
$wgConfirmAccountContact = 'greg@equality-tech.com';

So, to summarize the current status:
https://www.mediawiki.org/wiki/Extension:ConfirmAccount Account request process works from the user perspective (although not likely to be in a timely manner).

Requestor receives email notification / chance to verify email address

The problem is that nobody is notified internally of the account request...

Bureaucrats must still manually check http://wiki.slicer.org/slicerWiki/index.php/Special:ConfirmAccounts

Also, the bio page of the user does not seem to be created by the form (grundlett bio was >50 words on the account request yet is empty in the wiki)

jcfr

jcfr

2016-06-21 18:22

administrator   ~0014005

I don't have permission to see the results in http://wiki.slicer.org/slicerWiki/index.php/Special:ConfirmAccounts

User "grundlett" has been added to the bureaucrat group.

Let me know if you would like to also be added to the Administrator group.

$wgGroupPermissions['sysop']['confirmaccount-notify'] = true;

This is indeed confirmed by looking at http://wiki.slicer.org/slicerWiki/index.php/Special:ListGroupRights

no notification email

Looking at the code in [1], it is executed only "if this token is in the pending requests".

Now, if I look at your user rights or mine, I can see that there is a:

"Implicit member of: Autoconfirmed users"

In your case, I could read that before adding you to the "Bureaucrat" group.

Could the issue be incorrect settings associated with https://www.mediawiki.org/wiki/Manual:Autoconfirmed_users ?

[1] https://github.com/wikimedia/mediawiki-extensions-ConfirmAccount/blob/32dc740ef0d8233006221d244e98857fb32f7496/frontend/specialpages/actions/RequestAccount_body.php#L378

grundlett

grundlett

2016-06-22 13:36

administrator   ~0014010

Last edited: 2016-06-22 13:44

View 2 revisions

I set $wgMakeUserPageFromBio = true so that something useful would appear in User pages by default for new users.

Since we require a 50 word Bio in the account sign-up process, I think the user would assume that it is used. When the setting is 'false' then the Bio is hidden away in the database and not shown on the user's User:page. (FYI, you can lookup a user Biography at http://wiki.slicer.org/slicerWiki/index.php/Special:UserCredentials)

In the account review process, if an account is legitimate (thus approved), but there is some content that is explicitly or generally frowned upon (promotional copy) in the bio, then the reviewer/approver should make an edit to the user page with an explanation. The bio is plain text in the form.

p.s. I'm just hacking on the system and promoting what I think are reasonable best practices. I'm not the authority on how the Slicer wiki should operate. If anything I do is counter to SPL/Slicer standard practices then by all means let me know.

jcfr

jcfr

2016-06-22 14:26

administrator   ~0014011

hacking on the system and promoting what I think are reasonable best practices

Sounds very reasonable.

In the mean time, I added an entry in the FAQ to document what you reported:

http://wiki.slicer.org/slicerWiki/index.php/Documentation/Nightly/FAQ#Moderator:_How_to_review_and_approve_a_wiki_account_request_.3F

Consider updating as you see fit.

We will review and discuss them during the upcoming Developer hangout.
See http://wiki.slicer.org/slicerWiki/index.php/Developer_Meetings/20160628

grundlett

grundlett

2016-06-22 17:33

administrator   ~0014012

The ConfirmAccount process appears to be working as intended now.

I've confirmed that the data is correctly loaded into the database [Extension is working]

I've confirmed that the email sub-system is working. Direct mail is nearly instantaneous. (I also cleared the root user's mbox backlog which was not an issue on web2 where slicer wiki lives, but was an issue on web1 -- the /var/spool/mail/root file was huge)

Here is an example of a /var/log/maillog entry:
Jun 22 14:26:41 d905-2 sendmail[9495]: u5MIQfFd009493: to=<greg@equality-tech.com>, delay=00:00:00, xdelay=00:00:00, mailer=relay, pri=135137, relay=phsmgout.partners.org. [155.52.254.36], dsn=2.0.0, stat=Sent (ok: Message 43628316 accepted)

There was only one 'ConfirmAccount' message delivered/received by all Administrators (for new user "LiorG"). All other test requests were not received. The difference seems to be that LiorG verified his email address. Then I tested this assumption by requesting an account for 'runman' / admin@rundlett.com. This Account Request worked flawlessly.

Below, I've included the source of the one delivered message (in response to the email address verification event).

The SPF is neutral -- which indicates we can improve the SPF records for this domain.

There is some intermediary spam filtering taking place (X-IronPort-Anti-Spam-Filtered), and that process is opaque. There could be some spam filter at Partners which could potentially filter ConfirmAccount or other messages before they are delivered to intended recipients.

Delivered-To: greg@equality-tech.com
Received: by 10.37.210.80 with SMTP id j77csp2109208ybg;
Wed, 22 Jun 2016 06:06:51 -0700 (PDT)
X-Received: by 10.55.165.67 with SMTP id o64mr38244889qke.51.1466600811167;
Wed, 22 Jun 2016 06:06:51 -0700 (PDT)
Return-Path: <help@bwh.harvard.edu>
Received: from phsmx16.partners.org (phsmx16.partners.org. [155.52.251.97])
by mx.google.com with ESMTPS id h10si18129593qth.66.2016.06.22.06.06.50
for <greg@equality-tech.com>
(version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128);
Wed, 22 Jun 2016 06:06:51 -0700 (PDT)
Received-SPF: neutral (google.com: 155.52.251.97 is neither permitted nor denied by best guess record for domain of help@bwh.harvard.edu) client-ip=155.52.251.97;
Authentication-Results: mx.google.com;
spf=neutral (google.com: 155.52.251.97 is neither permitted nor denied by best guess record for domain of help@bwh.harvard.edu) smtp.mailfrom=help@bwh.harvard.edu
IronPort-PHdr: =?us-ascii?q?9a23=3AIFH2UhBCPkn5FGZnBSwbUyQJP3N1i/DPJgcQr6Af?=
=?us-ascii?q?oPdwSP/7rsbcNUDSrc9gkEXOFd2CrakV06yO6eu8AyQp2tWojjMrSNR0TRgLiM?=
=?us-ascii?q?EbzUQLIfWuLgnFFsPsdDEwB89YVVVorDmROElRH9viNRWJ+iXhpQAbFhi3Dwdp?=
=?us-ascii?q?POO9QteU1JXvkbjosMGJKyxzxxODIppKZC2sqgvQssREyaBDEY0WjiXzn31TZu?=
=?us-ascii?q?5NznlpL1/A1zz158O34YIxu38I46FppIZ9V77ndfE4UaBAF2ZhdH8q+4vwsRjI?=
=?us-ascii?q?QBHJ4WETFX4SkxFFGTfE7xC9X5H9vzu8ruplnxKCMMb3RLRmYS6v4apxRRnjhT?=
=?us-ascii?q?xUCzls/3vaheR9lb9SpBO9tlljzoXUJoqSMalQZKTYKOgeRGFMRPlQVC0JVoOx?=
=?us-ascii?q?a5MnBfUBe+ZRtZf0vVdIoBejU1r/TNjzwyNF0yellZYx1P4sRFnL?=
X-IronPort-Anti-Spam-Filtered: true
X-IronPort-Anti-Spam-Result: =?us-ascii?q?A2E9BwDNjGpX/x4JroZEGhwBAYM/N32lW?=
=?us-ascii?q?AEBAQEBAQaUUIFsDhIFC4dcEwEBAQEBAQEBAmInQQ4BgWIPSQEBAQEBAQEBAUw?=
=?us-ascii?q?CCG0gCQYBCQEJOi4CERUCAog9Yw4tsiaGKYZqgz0gBYEBhF6GN4JwEQFbDYI1g?=
=?us-ascii?q?loFmH2CII1gAY1PkBwBM4Fugh4gM4QghRuBNQEBAQ?=
X-IPAS-Result: =?us-ascii?q?A2E9BwDNjGpX/x4JroZEGhwBAYM/N32lWAEBAQEBAQaUUIF?=
=?us-ascii?q?sDhIFC4dcEwEBAQEBAQEBAmInQQ4BgWIPSQEBAQEBAQEBAUwCCG0gCQYBCQEJO?=
=?us-ascii?q?i4CERUCAog9Yw4tsiaGKYZqgz0gBYEBhF6GN4JwEQFbDYI1gloFmH2CII1gAY1?=
=?us-ascii?q?PkBwBM4Fugh4gM4QghRuBNQEBAQ?=
Received: from love.bwh.harvard.edu (HELO d905-2.bwh.harvard.edu) ([134.174.9.30])
by phsmx16-out.partners.org with ESMTP/TLS/DHE-RSA-AES256-SHA; 22 Jun 2016 09:06:47 -0400
Received: from d905-2.bwh.harvard.edu (localhost.localdomain [127.0.0.1])
by d905-2.bwh.harvard.edu (8.13.8/8.13.8) with ESMTP id u5MD8xFc032262
for <greg@equality-tech.com>; Wed, 22 Jun 2016 09:08:59 -0400
Received: (from apache@localhost)
by d905-2.bwh.harvard.edu (8.13.8/8.13.8/Submit) id u5MD8xKi032257;
Wed, 22 Jun 2016 09:08:59 -0400
X-Authentication-Warning: d905-2.bwh.harvard.edu: apache set sender to help@bwh.harvard.edu using -f
To: greg@equality-tech.com
Subject: SlicerWiki account request
X-PHP-Originating-Script: 48:UserMailer.php
From: SlicerWiki <help@bwh.harvard.edu>
Date: Wed, 22 Jun 2016 09:08:59 -0400
Message-ID: <slicer_slicerWiki_wiki.576a8deb38da82.09909332@www.slicer.org>
X-Mailer: MediaWiki mailer
List-Unsubscribe: <https://www.slicer.org/slicerWiki/index.php/Special:Preferences>
MIME-Version: 1.0
Content-type: text/plain; charset=UTF-8
Content-transfer-encoding: 8bit

"LiorG" has requested an account and is waiting for confirmation.
The email address has been confirmed. You can confirm the request here "https://www.slicer.org/slicerWiki/index.php/Special:ConfirmAccounts&quot;.

grundlett

grundlett

2016-06-22 17:35

administrator   ~0014013

The next request that comes in where the requestor verifies his/her email address should be received by all Users in the Administrator group. This enables the team to act on New Account requests in a timely manner.

jcfr

jcfr

2016-06-22 18:07

administrator   ~0014014

Nice detective work :) and thanks for the report.

I confirm I receive account requests. Closing.

grundlett

grundlett

2016-06-23 14:58

administrator   ~0014016

The wording on the Account Reqest page was a bit off
https://www.slicer.org/slicerWiki/index.php/Special:RequestAccount

looking up the interface message keys
https://www.slicer.org/slicerWiki/index.php/Special:RequestAccount?uselang=qqx

I found the key for the initial field group and edited the instructions describing the process, as well as adding a parenthetical comment to the bio section

https://www.slicer.org/slicerWiki/index.php/MediaWiki:Requestaccount-acc-text
https://www.slicer.org/slicerWiki/index.php/MediaWiki:Requestaccount-bio-text-i

Issue History

Date Modified Username Field Change
2016-06-20 16:52 jcfr New Issue
2016-06-20 16:52 jcfr Status new => assigned
2016-06-20 16:52 jcfr Assigned To => jcfr
2016-06-20 17:04 jcfr Summary Wiki: Notify Slicer core developers => Wiki: Notify Slicer core developers when account are created
2016-06-20 17:04 jcfr Summary Wiki: Notify Slicer core developers when account are created => Wiki: Notify Slicer core developers when an account is created
2016-06-20 17:07 jcfr Assigned To jcfr => grundlett
2016-06-21 14:40 grundlett Note Added: 0013999
2016-06-21 14:57 grundlett Note Added: 0014000
2016-06-21 15:12 grundlett Note Added: 0014001
2016-06-21 15:18 jcfr Note Added: 0014002
2016-06-21 17:04 jcfr Note Added: 0014003
2016-06-21 17:35 grundlett Note Added: 0014004
2016-06-21 18:22 jcfr Note Added: 0014005
2016-06-22 13:36 grundlett Note Added: 0014010
2016-06-22 13:44 grundlett Note Edited: 0014010 View Revisions
2016-06-22 14:26 jcfr Note Added: 0014011
2016-06-22 17:33 grundlett Note Added: 0014012
2016-06-22 17:35 grundlett Note Added: 0014013
2016-06-22 17:35 grundlett Status assigned => resolved
2016-06-22 17:35 grundlett Resolution open => fixed
2016-06-22 18:06 jcfr Relationship added related to 0004222
2016-06-22 18:07 jcfr Note Added: 0014014
2016-06-22 18:07 jcfr Status resolved => closed
2016-06-22 18:07 jcfr Fixed in Version => Slicer 4.6.0
2016-06-22 18:07 jcfr Target Version => Slicer 4.6.0
2016-06-23 14:58 grundlett Note Added: 0014016