View Issue Details
ID | Project | Category | View Status | Date Submitted | Last Update |
---|---|---|---|---|---|
0004182 | Slicer4 | Core: Extensions | public | 2016-05-03 09:41 | 2017-08-03 14:38 |
Reporter | msmolens | Assigned To | jcfr | ||
Priority | normal | Severity | minor | Reproducibility | always |
Status | closed | Resolution | fixed | ||
Product Version | Slicer 4.5.0-1 | ||||
Target Version | Fixed in Version | Slicer 4.6.2 | |||
Summary | 0004182: Running slicerExtensionWizard on Windows fails to set up proper environment | ||||
Description | Running the extension wizard on Windows from the Git Bash prompt provided by Git for Windows (https://git-for-windows.github.io/) gives the following error:
As reported on mailing list: The specific AttributeError results from a minor bug in the ExtensionWizard itself. But the root cause is that the PATH that reaches Python is incorrect, so Python doesn't find required DLLs. | ||||
Steps To Reproduce | Install Git for Windows | ||||
Additional Information | The following call in slicerExtensionWizard sets the PATH, along with other environment variables:
The MSYS2 environment that Git for Windows uses converts the contents of PATH to Unix format when launching a process, such as when slicerExtensionWizard runs Python. That conversion corrupts the PATH. A Windows path like "C:/foo/bar" is converted to two separate paths (/C and /c/foo/bar) because MSYS2 considers the colon as a separator. This wasn't a problem with the older Git Bash, provided by msysGit, because its MSYS didn't perform this conversion. MSYS2 provides some control over this path conversion for command-line arguments (MSYS2_ARG_CONV_EXCL, MSYS_NO_PATHCONV), but there is no such control for the PATH environment variable. | ||||
Tags | No tags attached. | ||||
A followup issue with the --publish option on Windows is: |
|
There is an active PR that will most likely address this here: https://github.com/Slicer/Slicer/pull/496 |
|
Tested with Slicer at revision 25977 (http://viewvc.slicer.org/viewvc.cgi/Slicer4?view=revision&revision=25977) and Git for Windows 64-bit with the following version: The AttributeError and path interpretation problems are no longer issues, and the command line extension wizard functions as expected, after the following minor related changes: |
|
http://viewvc.slicer.org/viewvc.cgi/Slicer4?view=revision&revision=26012 |
|
Date Modified | Username | Field | Change |
---|---|---|---|
2016-05-03 09:41 | msmolens | New Issue | |
2016-05-03 09:41 | msmolens | Status | new => assigned |
2016-05-03 09:41 | msmolens | Assigned To | => jcfr |
2016-06-01 12:54 | msmolens | Note Added: 0013912 | |
2016-06-01 13:17 | johan.andruejol | Note Added: 0013914 | |
2016-10-13 02:04 | jcfr | Product Version | Slicer 4.5.1 => Slicer 4.5.0-1 |
2017-04-27 13:31 | msmolens | Note Added: 0014444 | |
2017-04-27 13:31 | msmolens | Status | assigned => resolved |
2017-04-27 13:31 | msmolens | Resolution | open => fixed |
2017-05-15 12:33 | msmolens | Note Added: 0014481 | |
2017-08-03 14:38 | jcfr | Status | resolved => closed |
2017-08-03 14:38 | jcfr | Fixed in Version | => Slicer 4.6.2 |