View Issue Details

Jump to NotesJump to History
IDProjectCategoryView StatusDate SubmittedLast Update
0004180Slicer4Core: Building (CMake, Superbuild)public2016-04-28 15:012018-03-02 11:02
Reporterfedorov Assigned Todzenanz  
PrioritynormalSeveritytweakReproducibilityalways
Status closedResolutionfixed 
Product Version 
Target VersionFixed in VersionSlicer 4.7.0 
Summary0004180: Extension template is incorrect for loadable module generator
Description

Loadable module template is using a wrong cmake macro:

slicerMacroBuildQtModule

should be replaced with

slicerMacroBuildLoadableModule

and related modifications ...

https://github.com/Slicer/Slicer/blob/master/Utilities/Templates/Modules/Loadable/CMakeLists.txt#L49

Steps To Reproduce

Apparently, people don't develop loadable extensions in Slicer (or don't use the template generator)

TagsNo tags attached.

Relationships

has duplicate 0003332 closeddzenanz Rename file "SlicerMacroBuildQtModule.cmake" into "SlicerMacroBuildLoadableModule.cmake" 

Activities

jcfr

jcfr

2016-05-02 00:16

administrator   ~0013864

Change the severity back to "tweak"

The older macro is still available for backward compatibility and hasn't been removed:

http://wiki.slicer.org/slicerWiki/index.php/Roadmap#Pending

https://github.com/Slicer/Slicer/blob/1865f51e5450f243f71314a9a568541afad76d0f/CMake/SlicerMacroBuildQtModule.cmake#L280
jcfr

jcfr

2016-06-01 13:10

administrator   ~0013913

Note:

(1) The template here should be modified: https://github.com/Slicer/Slicer/tree/master/Utilities/Templates/Modules/Loadable

(2) Then, the example of extension in https://github.com/Slicer/Slicer/tree/master/Extensions should be regenerated building the "SlicerGenerateExtensionTemplates" target.
dzenanz

dzenanz

2017-04-27 15:07

developer   ~0014450

Fix submitted: https://github.com/Slicer/Slicer/pull/715
jcfr

jcfr

2017-10-15 23:57

administrator   ~0015314

Fixed in r26472
See http://viewvc.slicer.org/viewvc.cgi/Slicer4?view=revision&revision=26472

Issue History

Date Modified Username Field Change
2016-04-28 15:01 fedorov New Issue
2016-04-28 15:01 fedorov Status new => assigned
2016-04-28 15:01 fedorov Assigned To => jcfr
2016-05-02 00:14 jcfr Severity block => tweak
2016-05-02 00:16 jcfr Note Added: 0013864
2016-06-01 11:58 user731 Assigned To jcfr => bpaniagua
2016-06-01 13:10 jcfr Note Added: 0013913
2017-04-27 15:07 dzenanz Note Added: 0014450
2017-04-27 15:08 dzenanz Assigned To bpaniagua => dzenanz
2017-09-12 09:52 dzenanz Relationship added has duplicate 0003332
2017-10-15 23:57 jcfr Status assigned => resolved
2017-10-15 23:57 jcfr Resolution open => fixed
2017-10-15 23:57 jcfr Fixed in Version => Slicer 4.7.0
2017-10-15 23:57 jcfr Note Added: 0015314
2018-03-02 11:02 jcfr Status resolved => closed