View Issue Details
ID | Project | Category | View Status | Date Submitted | Last Update |
---|---|---|---|---|---|
0004139 | Slicer4 | Module BRAINS | public | 2016-01-26 16:07 | 2018-03-02 11:06 |
Reporter | criskross | Assigned To | jcfr | ||
Priority | high | Severity | crash | Reproducibility | always |
Status | closed | Resolution | fixed | ||
Platform | Windows and MAC OS X | OS | OS Version | ||
Product Version | Slicer 4.5.0-1 | ||||
Target Version | Slicer 4.6.0 | Fixed in Version | Slicer 4.6.0 | ||
Summary | 0004139: Slicer crashes while doing registration using BrainsFit and creating transform output | ||||
Description | When executing registration by using BrainsFit, slicer crashes | ||||
Steps To Reproduce | download sample data (MRBrainTumor1, MRBrainTumor2) | ||||
Additional Information | =============================== ITKv4 Registration: Starting Transform Estimations for Rigid(1 of 1).=============================== 0 -1.65112 [ 0.000149534 -5.78744e-05 0.000330727 0.0241069 -0.0209527 -0.0384617 ] General Registration (BRAINS) completed without errors CreateVTKTransformFromITK - SetVTKLinearTransformFromITK conversionSuccess:0 | ||||
Tags | No tags attached. | ||||
Is this in the nightly or in the 4.5 release (or both?) |
|
Actually is in the nightly. There was no selector for nightly. Last stable version of Slicer works fine |
|
Regression most likely introduced by the recent update of ITK/BRAINS. |
|
I was able to reproduce the problem. |
|
To reproduce, open the python interpreter and copy the following: <pre> fixed = logic.downloadMRBrainTumor1() slicer.util.selectModule("BRAINSFit") widget = slicer.modules.brainsfit.widgetRepresentation() cmdLineNode.SetParameterAsNode("fixedVolume", fixed) outputTransform = slicer.vtkMRMLLinearTransformNode() cmdLineNode.SetParameterAsNode("linearTransform", outputTransform) outputVolume = slicer.vtkMRMLScalarVolumeNode() cmdLineNode.SetParameterAsNode("outputVolume", outputVolume) cmdLineNode.SetParameterAsBool("useRigid", True) widget.apply() |
|
Commit r24875 introduced the regression. See http://viewvc.slicer.org/viewvc.cgi/Slicer4?view=revision&revision=24875 Will work on a fix later. |
|
Without this commit .. i get the following output: Note: I added few extra print statements SetVTKBSplineParametersFromITKGeneric - bsplineItk NULL |
|
The issue is that the corresponding static cast didn't account for all type of linear transform. |
|
Issue fixed in the following topic: https://github.com/jcfr/Slicer/tree/4139-fix-crash-vtkITKTransformConverter Now integrating the python snipped in a test and will integrate. |
|
Fix integrated in r24902 For future reference, a simpler version of the python code has been <pre> fixed = sampleDatalogic.downloadMRBrainTumor1() outputTransform = slicer.vtkMRMLLinearTransformNode() outputVolume = slicer.vtkMRMLScalarVolumeNode() parameters = { |
|
Import 2017-06-07 23:51:09: master 7e41e8af 2016-01-27 23:21:57 Details Diff |
BUG: Fix registration addressing regression in vtkITKTransformConverter. Fixes 0004139 This commit allows BRAINSFit registration to complete by addressing a regression introduced in r24875 (BUG: Fix transform tests by not using dynamic_cast in vtkITKTransformConverter) It basically ensure the comparison of transform name includes all derived type associated with itk::MatrixOffsetTransformBase The python code allowing to reproduce the issue is reported below and has been integrated into a self-test named "BRAINSFitRigidRegistrationCrashIssue4139" 8<---8<---8<---8<---8<---8<---8<---8<---8<---8<---8<---8<---8<--- import SampleData from SampleData import SampleDataLogic sampleDatalogic = SampleDataLogic() fixed = sampleDatalogic.downloadMRBrainTumor1() moving = sampleDatalogic.downloadMRBrainTumor2() outputTransform = slicer.vtkMRMLLinearTransformNode() slicer.mrmlScene.AddNode(outputTransform) outputVolume = slicer.vtkMRMLScalarVolumeNode() slicer.mrmlScene.AddNode(outputVolume) parameters = { 'fixedVolume' : fixed, 'movingVolume' : moving, 'linearTransform' : outputTransform, 'outputVolume' : outputVolume, 'useRigid' : True } cmdLineNode = slicer.cli.runSync(slicer.modules.brainsfit, parameters=parameters) 8<---8<---8<---8<---8<---8<---8<---8<---8<---8<---8<---8<---8<--- Reported-by: Christian Herz <christian.herz@mevis.fraunhofer.de> Suggested-by: Hans Johnson <hans-johnson@uiowa.edu> git-svn-id: http://svn.slicer.org/Slicer4/trunk@24902 3bd1e089-480b-0410-8dfb-8563597acbee |
||
add - Applications/SlicerApp/Testing/Python/BRAINSFitRigidRegistrationCrashIssue4139.py | Diff File | ||
mod - Applications/SlicerApp/Testing/Python/CMakeLists.txt | Diff File | ||
mod - Libs/MRML/Core/vtkITKTransformConverter.h | Diff File |
Date Modified | Username | Field | Change |
---|---|---|---|
2016-01-26 16:07 | criskross | New Issue | |
2016-01-26 16:07 | criskross | Status | new => assigned |
2016-01-26 16:07 | criskross | Assigned To | => hjmjohnson |
2016-01-26 16:32 | pieper | Note Added: 0013766 | |
2016-01-26 16:41 | jcfr | Assigned To | hjmjohnson => jcfr |
2016-01-26 16:41 | jcfr | Target Version | => Slicer 4.6.0 |
2016-01-26 16:43 | criskross | Note Added: 0013768 | |
2016-01-26 16:44 | jcfr | Note Added: 0013769 | |
2016-01-26 17:26 | jcfr | Note Added: 0013770 | |
2016-01-26 17:26 | jcfr | Note Edited: 0013770 | View Revisions |
2016-01-26 17:26 | jcfr | Note Edited: 0013770 | View Revisions |
2016-01-26 17:28 | jcfr | Steps to Reproduce Updated | View Revisions |
2016-01-26 17:28 | jcfr | Steps to Reproduce Updated | View Revisions |
2016-01-26 22:35 | jcfr | Note Added: 0013779 | |
2016-01-27 00:40 | jcfr | Note Added: 0013784 | |
2016-01-27 00:42 | jcfr | Note Added: 0013785 | |
2016-01-27 00:42 | jcfr | Note Edited: 0013785 | View Revisions |
2016-01-27 00:44 | jcfr | Note Added: 0013786 | |
2016-01-27 22:31 | jcfr | Note Added: 0013790 | |
2016-01-27 23:23 | jcfr | Note Added: 0013791 | |
2016-01-27 23:23 | jcfr | Status | assigned => resolved |
2016-01-27 23:23 | jcfr | Fixed in Version | => Slicer 4.6.0 |
2016-01-27 23:23 | jcfr | Resolution | open => fixed |
2016-01-28 14:47 | pieper | Relationship added | duplicate of 0004141 |
2016-01-29 14:29 | pieper | Relationship deleted | 0004141 |
2017-06-10 08:51 | jcfr | Changeset attached | => Slicer master 7e41e8af |
2018-03-02 11:06 | jcfr | Status | resolved => closed |