View Issue Details

Related ChangesetsJump to NotesJump to History
IDProjectCategoryView StatusDate SubmittedLast Update
0004128Slicer4Module Editorpublic2016-01-18 16:262018-03-02 11:07
Reporterjonieva Assigned Topieper  
PrioritynormalSeverityminorReproducibilityalways
Status closedResolutionfixed 
PlatformMacOSJosemiteOS Version10.11.2
Product VersionSlicer 4.5.0-1 
Target VersionFixed in VersionSlicer 4.6.0 
Summary0004128: Error when closing the scene
Description

It looks like there's a problem with the Editor when the scene is being
cleared.

You get this error:

slicer.mrmlScene.Clear(0)
Traceback (most recent call last):
File
"/Applications/Slicer.nightly.2016.01.18.app/Contents/lib/Slicer-4.5/qt-scripted-modules/EditorLib/EditBox.py",
line 107, in _onParameterNodeModified
EditUtil.setEraseEffectEnabled(EditUtil.isEraseEffectEnabled())
File
"/Applications/Slicer.nightly.2016.01.18.app/Contents/lib/Slicer-4.5/qt-scripted-modules/EditorLib/EditUtil.py",
line 217, in isEraseEffectEnabled
return EditUtil.getLabel() == 0;
File
"/Applications/Slicer.nightly.2016.01.18.app/Contents/lib/Slicer-4.5/qt-scripted-modules/EditorLib/EditUtil.py",
line 152, in getLabel
return int(EditUtil.getParameterNode().GetParameter('label'))
ValueError: invalid literal for int() with base 10: ''

I tried to return a default value of 0 when parameter "label" is empty and
there is no error any more, just a warning:
"Warning: effect not a valid action"

Steps To Reproduce
  • Open Slicer
  • Go to Editor module
  • Go to python console and type slicer.mrmlScene.Clear(0)
TagsNo tags attached.

Relationships

related to 0004006 closednicole Loading an MRB with a manual scene view disables Editor effects 

Activities

pieper

pieper

2016-01-19 15:32

administrator   ~0013728

Discussed on the mailing list here:

http://massmail.spl.harvard.edu/public-archives/slicer-devel/2016/019496.html

Issue is related to this change:

https://github.com/Slicer/Slicer/commit/b1bb1b7c30bd76258414b2c6ba527f80f583c49a
pieper

pieper

2016-01-22 13:23

administrator   ~0013738

http://viewvc.slicer.org/viewvc.cgi/Slicer4?view=revision&revision=24887

Related Changesets

Import 2017-06-07 23:51:09: master 51c9e67b

2016-01-22 13:22:22

pieper

Details Diff 		BUG: 0004128 python ValueError on scene close after visiting Editor

Accessing the state of the parameter node during scene close
was causing an access to an incompletely build parameter node.

Important to note that node events can be invoked on singletons
during scene operations.

From: Steve Pieper <pieper@isomics.com>

git-svn-id: http://svn.slicer.org/Slicer4/trunk@24887 3bd1e089-480b-0410-8dfb-8563597acbee
mod - Modules/Scripted/EditorLib/EditBox.py Diff File
mod - Modules/Scripted/EditorLib/EditUtil.py Diff File

Issue History

Date Modified Username Field Change
2016-01-18 16:26 jonieva New Issue
2016-01-18 16:26 jonieva Status new => assigned
2016-01-18 16:26 jonieva Assigned To => pieper
2016-01-19 15:32 pieper Note Added: 0013728
2016-01-22 12:43 pieper Relationship added related to 0004006
2016-01-22 13:23 pieper Note Added: 0013738
2016-01-22 13:23 pieper Status assigned => resolved
2016-01-22 13:23 pieper Fixed in Version => Slicer 4.5.1
2016-01-22 13:23 pieper Resolution open => fixed
2016-10-13 02:01 jcfr Fixed in Version Slicer 4.5.1 => Slicer 4.6.0
2017-06-10 08:51 pieper Changeset attached => Slicer master 51c9e67b
2018-03-02 11:07 jcfr Status resolved => closed