View Issue Details

IDProjectCategoryView StatusLast Update
0004074Slicer4Core: MRMLpublic2017-03-24 16:24
Reporterpinter Assigned Topinter  
PrioritynormalSeverityminorReproducibilityalways
Status closedResolutionfixed 
Product Version 
Target VersionSlicer 4.7.0Fixed in VersionSlicer 4.7.0 
Summary0004074: User-defined order of nodes in tree hierarchies
Description

The mechanism that defines a node order in tree branches is now broken and needed to be fixed. It is the SortingValue member of vtkMRMLHierarchyNode.

There are two issues

  • SortingValue is not changed on drag&drop any more (SetIndexInParent should be called but it's not). It should either be handled at the lower level functions like dropMimeData where we have the row number, or in reparent, but then we need to pass the row number so that it can be used for setting the SortingValue (see desiredNodeIndex in qMRMLSceneModel.cxx, which does not work any more)
  • In parenting the sorting values are handled as integers that can be increased freely (see MaximumSortingValue), and in SetIndexInParent it is handled as a floating point value ranging from 0 to 1. This seems to be a problem (see SetIndexInParent where in case of 0 new index, sorting value is just decreased by one, although it could have a wide range of integers)
Additional Information

SlicerRT ticket with some extra information:
https://www.assembla.com/spaces/slicerrt/tickets/619-allow-re-ordering-nodes-in-subject-hierarchy

TagsNo tags attached.

Activities

pinter

pinter

2017-03-24 16:24

developer   ~0014381

Re-ordering of nodes is handled in subject hierarchy 2.0. See labs page for details:
https://www.slicer.org/wiki/Documentation/Labs/SubjectHierarchy#Subject_hierarchy_2.0

Issue History

Date Modified Username Field Change
2015-11-03 10:38 pinter New Issue
2015-11-03 10:38 pinter Status new => assigned
2015-11-03 10:38 pinter Assigned To => alexy
2015-11-03 10:38 pinter Assigned To alexy => nicole
2015-11-03 10:49 nicole Target Version => Slicer 4.6.0
2016-10-12 03:56 jcfr Target Version Slicer 4.6.0 => Slicer 4.7.0
2017-03-24 16:24 pinter Note Added: 0014381
2017-03-24 16:24 pinter Status assigned => closed
2017-03-24 16:24 pinter Assigned To nicole => pinter
2017-03-24 16:24 pinter Resolution open => fixed
2017-03-24 16:24 pinter Fixed in Version => Slicer 4.7.0