View Issue Details

Related ChangesetsJump to NotesJump to History
IDProjectCategoryView StatusDate SubmittedLast Update
0004047Slicer4Module Editorpublic2015-09-15 14:232018-03-02 11:06
Reporternicole Assigned Tonicole  
PrioritynormalSeverityfeatureReproducibilityhave not tried
Status closedResolutionfixed 
Product Version 
Target VersionSlicer 4.6.0Fixed in VersionSlicer 4.6.0 
Summary0004047: Add semantic color information to color selector in editor
Description

Add information (non-editable) to the Editor Module under the color picker Label widgets that show the color name, value and color to show the terminology that has been looked up:
Category: [ ] Modifier: [ ]
Region: [ ] Modifier: [ ]
When the user picks a color, the information is updated, but the boxes won't show if the color table isn't linked to terminology (or should we show generic values?). Add this information to the label map via node attributes.

Additional Information

Cross linking github issues with mantis bug tracker:
https://github.com/fedorov/Reporting/issues/52

TagsNo tags attached.

Activities

nicole

nicole

2015-10-30 13:09

administrator   ~0013471

Work in progress topic branch:
https://github.com/naucoin/Slicer/tree/4047-Add-semantic-color-information-to-color-selector-in-editor

2015-11-04 05:48

 

SlicerEditor-Terminology-0.tif (71,732 bytes)

2015-11-04 05:49

 

TerminologyDisplay.tiff (208,512 bytes)
nicole

nicole

2015-11-12 15:12

administrator   ~0013606

Slicer pull request:
https://github.com/Slicer/Slicer/pull/408
nicole

nicole

2015-11-16 11:26

administrator   ~0013621

Comments on the pull request from JC to be considered for post-RSNA API refactoring:

By changing to something like:

std::string GetSegmentedProperty(int label, int property, const char *lutName = DEFAULT_LUT_NAME);

Where property would be any value from an enum like:

enum StandardTermProperties
{
Value = 0,
Meaning,
SchemeDesignator
}
You would simplify you API.

Adding a bool IsValidStandardTermProperty(int) could then be used to check the input ..
nicole

nicole

2015-11-16 13:26

administrator   ~0013622

Commited to trunk as:
https://github.com/Slicer/Slicer/commit/1f0a534f1979e008a371d6873438633be58ae227
http://viewvc.slicer.org/viewvc.cgi/Slicer4?view=revision&revision=24742
jcfr

jcfr

2016-10-12 02:33

administrator   ~0014155

As reported in the last comment, since the corresponding feature has been integrated in r24742, I am resolving

Related Changesets

Import 2017-06-07 23:51:09: master 1f0a534f

2015-11-16 17:46:35

naucoin

Details Diff 		ENH: Add terminology information to color picker in Editor

Added terminology files, read them on start up, associate
with the generic anatomy colors node.
Add accessors to the color logic as well as basic methods to
allow creating new terminologies (used by the Reporting extension).
Created Python callable utility methods to allow scripted access[1].
Add read only widgets to the Editor, shown if the selected
color node has terminology associated with it (using
node attributes).
Added testing for the terminology functionality to vtkSlicerColorLogicTest (rather than
in vtkMRMLColorLogicTest1 since the Colors module logic adds the terminology files).
Pass the color logic to the color model so that it can look up
terminology information to set the tool tips on the color table
entries.
Minor changes to respond to feedback on the pull request (CMake,
references, default terminology).
[1] Utility accessor functions:
- GetTerminologyFromLabel takes in the strings defining the color label
categorization and the standard term elements and returns the specific term.
- Get the colon concatenated full standard term values via
GetSegmentedPropertyCategory, GetSegmentedPropertyType, GetSegmentedPropertyTypeModifier,
GetAnatomicRegion, GetAnatomicRegionModifier

Issue 0004047

git-svn-id: http://svn.slicer.org/Slicer4/trunk@24742 3bd1e089-480b-0410-8dfb-8563597acbee
mod - Base/Logic/Resources/CMakeLists.txt Diff File
add - Base/Logic/Resources/ColorFiles/Terminology/AnatomicRegionAndModifier.xml Diff File
add - Base/Logic/Resources/ColorFiles/Terminology/GenericAnatomyColors-SNOMED.csv Diff File
add - Base/Logic/Resources/ColorFiles/Terminology/SegmentationCategoryTypeModifier.xml Diff File
mod - Libs/MRML/Logic/Testing/Cxx/CMakeLists.txt Diff File
add - Libs/MRML/Logic/Testing/Cxx/vtkMRMLColorLogicTest2.cxx Diff File
mod - Libs/MRML/Logic/vtkMRMLColorLogic.cxx Diff File
mod - Libs/MRML/Logic/vtkMRMLColorLogic.h Diff File
mod - Libs/MRML/Widgets/qMRMLColorModel.cxx Diff File
mod - Libs/MRML/Widgets/qMRMLColorModel.h Diff File
mod - Libs/MRML/Widgets/qMRMLColorModel_p.h Diff File
mod - Modules/Loadable/Colors/Logic/Testing/Cxx/vtkSlicerColorLogicTest1.cxx Diff File
mod - Modules/Loadable/Colors/Logic/vtkSlicerColorLogic.cxx Diff File
mod - Modules/Loadable/Colors/Logic/vtkSlicerColorLogic.h Diff File
mod - Modules/Loadable/Colors/qSlicerColorsModuleWidget.cxx Diff File
mod - Modules/Scripted/EditorLib/EditColor.py Diff File

Import 2017-06-07 23:51:09: master fe937b8f

2015-11-16 18:24:44

naucoin

Details Diff 		BUG: Fix error in terminology install command

Remove the extra ColorFiles directory in the install path.

Issue 0004047


git-svn-id: http://svn.slicer.org/Slicer4/trunk@24743 3bd1e089-480b-0410-8dfb-8563597acbee
mod - Base/Logic/Resources/CMakeLists.txt Diff File

Import 2017-06-07 23:51:09: master ab8c7439

2015-11-17 11:08:25

naucoin

Details Diff 		COMP: fixing windows build errors in vtkMRMLColorLogic

This commit is to fix the build error introducted in r24742 (ENH: Add terminology
information to color picker in Editor)
42>44>c:\d\n\slicer-1\libs\mrml\logic\vtkMRMLColorLogic.h(73) : error C2679: binary '<<' : no operator found which takes a right-hand operand of type 'std::string' (or there is no acceptable conversion)

Issue 0004047



git-svn-id: http://svn.slicer.org/Slicer4/trunk@24746 3bd1e089-480b-0410-8dfb-8563597acbee
mod - Libs/MRML/Logic/vtkMRMLColorLogic.cxx Diff File
mod - Libs/MRML/Logic/vtkMRMLColorLogic.h Diff File

Import 2017-06-07 23:51:09: master d3c73329

2015-11-19 14:59:29

naucoin

Details Diff 		STYLE: Refactor terminology tests for fine grain error reporting

Moved the repeated code into the ParseTerm test method and pass in
expected success flag and term values.
Updated the color logic for more clear print outs.
Use the CheckString utility to encapsulate the string comparisons
on the terminology methods.
Group terminology tests together and provide better
descriptive strings.

Issue 0004047

git-svn-id: http://svn.slicer.org/Slicer4/trunk@24753 3bd1e089-480b-0410-8dfb-8563597acbee
mod - Libs/MRML/Logic/Testing/Cxx/vtkMRMLColorLogicTest2.cxx Diff File
mod - Libs/MRML/Logic/vtkMRMLColorLogic.cxx Diff File
mod - Modules/Loadable/Colors/Logic/Testing/Cxx/vtkSlicerColorLogicTest1.cxx Diff File

Issue History

Date Modified Username Field Change
2015-09-15 14:23 nicole New Issue
2015-09-15 14:23 nicole Status new => assigned
2015-09-15 14:23 nicole Assigned To => nicole
2015-10-28 13:57 nicole Target Version Slicer 4.5.0-1 => Slicer 4.5.1
2015-10-30 13:09 nicole Note Added: 0013471
2015-11-04 05:48 nicole File Added: SlicerEditor-Terminology-0.tif
2015-11-04 05:49 nicole File Added: TerminologyDisplay.tiff
2015-11-12 15:12 nicole Note Added: 0013606
2015-11-16 11:26 nicole Note Added: 0013621
2015-11-16 13:26 nicole Note Added: 0013622
2016-10-12 02:33 jcfr Note Added: 0014155
2016-10-12 02:33 jcfr Status assigned => resolved
2016-10-12 02:33 jcfr Fixed in Version => Slicer 4.6.0
2016-10-12 02:33 jcfr Resolution open => fixed
2016-10-13 01:27 jcfr Target Version Slicer 4.5.1 => Slicer 4.6.0
2017-06-10 08:51 Changeset attached => Slicer master d3c73329
2017-06-10 08:51 Changeset attached => Slicer master ab8c7439
2017-06-10 08:51 Changeset attached => Slicer master fe937b8f
2017-06-10 08:51 Changeset attached => Slicer master 1f0a534f
2018-03-02 11:06 jcfr Status resolved => closed