View Issue Details

Related ChangesetsJump to NotesJump to History
IDProjectCategoryView StatusDate SubmittedLast Update
0004013Slicer4Core: Usabilitypublic2015-06-30 13:022018-03-02 11:07
Reporterfedorov Assigned Tofedorov  
PrioritynormalSeverityfeatureReproducibilityN/A
Status closedResolutionfixed 
Product Version 
Target VersionFixed in VersionSlicer 4.5.0-1 
Summary0004013: Add support for DCMTK private dictionary
Description

See discussion here: http://slicer-devel.65872.n3.nabble.com/Enabling-support-for-DCMTK-private-dictionary-td4034305.html

Summary:

DCMTK includes descriptions of private tags in
dcmdata/data/private.dic, which is built based on the information
available in DICOM conformance statements, and contributions from the
DCMTK community. It is possible to enable support of this dictionary
by setting environment variable DCMDICTPATH.

As an example, here is the output of dcmdump for a Philips DWI
dataset, without private dictionary support:

(2001,1003) ?? 00\00\48\44 # 4, 1
Unknown Tag & Data

and with the private dictionary support enabled:

(2001,1003) FL 800 # 4, 1
DiffusionBFactor

So this motivates enabling private dictionary by default, and I would
like to enable it (this was discussed with Steve Pieper, and we agreed
it's a good idea).

TagsNo tags attached.

Activities

pieper

pieper

2015-06-30 13:45

administrator   ~0013164

Let me know if you want me to do this - or if you have it handled that's even better!
fedorov

fedorov

2015-06-30 13:46

developer   ~0013165

Steve, if you could review this pull request, this would be great https://github.com/Slicer/Slicer/pull/299

I forgot to add here.
fedorov

fedorov

2015-07-30 12:07

developer   ~0013205

Integrated in http://viewvc.slicer.org/viewvc.cgi/Slicer4?view=revision&revision=24473.

TODO: add a test
jcfr

jcfr

2015-08-03 22:09

administrator   ~0013212

Follow up commit added in r24483

See http://viewvc.slicer.org/viewvc.cgi/Slicer4?view=revision&revision=24483
fedorov

fedorov

2015-08-25 05:51

developer   ~0013245

pull request with the test: https://github.com/Slicer/Slicer/pull/322

(the test is failing in the built version)
jcfr

jcfr

2015-09-08 13:28

administrator   ~0013262

Thanks to Andriy. Test added in r24521
See http://viewvc.slicer.org/viewvc.cgi/Slicer4?view=revision&revision=24521

Related Changesets

Import 2017-06-07 23:51:09: master 1f134eca

2015-09-08 16:49:49

jcfr

Details Diff 		ENH: Add test for DCMTK private dictionary. See issue 0004013

Philips phantom DWI dataset is included. The test runs dcmdump command,
and looks for the description of tag (2001,1003), which should be
DiffusionBFactor, and can only be recognized when private dictionary
support is enabled in DCMTK.

Co-authored-by: Jean-Christophe Fillion-Robin <jchris.fillionr@kitware.com>
Tested-by: Jean-Christophe Fillion-Robin <jchris.fillionr@kitware.com>

From: Andrey Fedorov <fedorov@bwh.harvard.edu>

git-svn-id: http://svn.slicer.org/Slicer4/trunk@24521 3bd1e089-480b-0410-8dfb-8563597acbee
mod - Applications/SlicerApp/Testing/Python/CMakeLists.txt Diff File
add - Applications/SlicerApp/Testing/Python/DCMTKPrivateDictTest.py Diff File
add - Testing/Data/Input/philips_ingenia_4_1_3_dwi.dcm Diff File

Issue History

Date Modified Username Field Change
2015-06-30 13:02 fedorov New Issue
2015-06-30 13:02 fedorov Status new => assigned
2015-06-30 13:02 fedorov Assigned To => pieper
2015-06-30 13:02 fedorov Assigned To pieper => fedorov
2015-06-30 13:45 pieper Note Added: 0013164
2015-06-30 13:46 fedorov Note Added: 0013165
2015-07-30 12:07 fedorov Note Added: 0013205
2015-08-03 22:09 jcfr Note Added: 0013212
2015-08-25 05:51 fedorov Note Added: 0013245
2015-09-08 13:28 jcfr Note Added: 0013262
2015-09-08 13:28 jcfr Status assigned => resolved
2015-09-08 13:28 jcfr Fixed in Version => Slicer 4.5.0-1
2015-09-08 13:28 jcfr Resolution open => fixed
2017-06-10 08:51 jcfr Changeset attached => Slicer master 1f134eca
2018-03-02 11:07 jcfr Status resolved => closed