View Issue Details

Jump to NotesJump to History
IDProjectCategoryView StatusDate SubmittedLast Update
0003971Slicer4Module Markupspublic2015-02-27 14:102015-09-09 08:29
Reporteruser731Assigned Tonicole  
PrioritynormalSeverityminorReproducibilityhave not tried
Status closedResolutionfixed 
Product VersionSlicer 4.4.0 
Target VersionSlicer 4.5.0-1Fixed in VersionSlicer 4.5.0-1 
Summary0003971: Error in vtkWidgetRepresentation when activating 2D projection on markup
Description

To reproduce:

  • Create a markup
  • Open markup module and activate the 2D projection option

-> Error:
ERROR: In c:\d\p\slicer-440-package\vtkv6\interaction\widgets\vtkWidgetRepresentation.h, line 176
vtkPointHandleRepresentation2D (0000000010537080): Subclass should allow enable/disable picking

See https://github.com/Slicer/Slicer/pull/238

Additional Information

I suggest the patch I uploaded (basically deleted the DisablePicking call line 797 of vtkMRMLMarkupsFiducialDisplayableManager2D.cxx)

TagsNo tags attached.

Activities

user731

2015-02-27 14:10

  ~0012944

I am not sure that the submitted patch is the best way to go.
Could someone review this ?
nicole

nicole

2015-03-02 06:24

administrator   ~0012947

I want to dig into this a bit, we use point handle representations in light box view and I need to double check if we make any enable/disable picking calls on them.
nicole

nicole

2015-03-02 11:06

administrator   ~0012950

DisablePicking is only implemented in vtkOrientedPolygonalHandleRepresentation3D which is what I'm currently using to display the fiducials glyph + text. For the projections, it's using a point handle representation and that call is not defined on it.
The DisablePicking call also needs to be removed for the light box case, I'll put a line note on github.

user731

2015-03-02 13:18

  ~0012952

Fixed in revision 24009
nicole

nicole

2015-03-03 07:12

administrator   ~0012955

Tested and verified that the error message is gone.

Issue History

Date Modified Username Field Change
2015-02-27 14:10 user731 New Issue
2015-02-27 14:10 user731 Status new => assigned
2015-02-27 14:10 user731 Assigned To => nicole
2015-02-27 14:10 user731 File Added: 0001-ENH-Add-forgotten-style-fix-up.patch
2015-02-27 14:10 user731 Note Added: 0012944
2015-03-02 06:11 jcfr File Deleted: 0001-ENH-Add-forgotten-style-fix-up.patch
2015-03-02 06:14 user731 File Added: 0001-ENH-Do-no-disable-the-picking-in-2D-since-the-widget.patch
2015-03-02 06:24 nicole Note Added: 0012947
2015-03-02 06:28 jcfr Target Version => Slicer 4.4.1
2015-03-02 10:36 jcfr File Deleted: 0001-ENH-Do-no-disable-the-picking-in-2D-since-the-widget.patch
2015-03-02 10:36 jcfr Description Updated
2015-03-02 11:06 nicole Note Added: 0012950
2015-03-02 13:18 user731 Note Added: 0012952
2015-03-02 13:46 jcfr Status assigned => resolved
2015-03-02 13:46 jcfr Fixed in Version => Slicer 4.4.1
2015-03-02 13:46 jcfr Resolution open => fixed
2015-03-03 07:12 nicole Note Added: 0012955
2015-03-03 07:12 nicole Status resolved => closed
2015-09-09 08:29 jcfr Fixed in Version Slicer 4.4.1 => Slicer 4.5.0-1
2015-09-09 08:29 jcfr Target Version Slicer 4.4.1 => Slicer 4.5.0-1