0003906: VTK fails to build

ID	Project	Category	View Status	Date Submitted	Last Update

0003906	Slicer4	Core: Building (CMake, Superbuild)	public	2014-11-27 08:07	2018-03-02 11:06

Reporter	gregsharp	Assigned To	jcfr
Priority	normal	Severity	minor	Reproducibility	always
Status	closed	Resolution	fixed
Platform	Linux	OS	Debian	OS Version	Jessie
Product Version
Target Version	Slicer 4.5.0-1	Fixed in Version	Slicer 4.5.0-1

Summary	0003906: VTK fails to build
Description	There is a recent change in Mesa which causes Slicer's VTK not to compile. Here is the error message: [ 35%] Building CXX object Rendering/OpenGL/CMakeFiles/vtkRenderingOpenGLObjects.dir/vtkXOpenGLRenderWindow.cxx.o In file included from /usr/include/GL/glx.h:333:0, from /home/gsharp/build/slicer-4/Slicer-build/VTKv6/Rendering/OpenGL/vtkXOpenGLRenderWindow.cxx:30: /usr/include/GL/glxext.h:480:143: error: ‘GLintptr’ has not been declared typedef void ( PFNGLXCOPYBUFFERSUBDATANVPROC) (Display dpy, GLXContext readCtx, GLXContext writeCtx, GLenum readTarget, GLenum writeTarget, GLintptr readOffset, GLintptr writeOffset, GLsizeiptr size); Here is an example patch: https://bugs.debian.org/cgi-bin/bugreport.cgi?bug=765938
Tags	No tags attached.

pieper 2014-12-17 08:42 administrator ~0012790	Shouldn't this be fixed in VTK proper and then cherrypicked into github.com:Slicer/VTK?

gregsharp 2014-12-17 09:47 developer ~0012792	That is logical.

gregsharp 2014-12-23 05:23 developer ~0012806	Would the following patch be the right one to cherry-pick? http://www.vtk.org/gitweb?p=VTK.git;a=commit;h=800282f2

pieper 2014-12-23 06:20 administrator ~0012807	I suspect so, yes. Could you cherry pick it into your Slicer-superbuild/VTK directory and then see if the build succeeds in Slicer-superbuild/VTK-build ? That would confirm that we should pick it into github.com:Slicer/VTK.

gregsharp 2014-12-23 07:56 developer ~0012810	Indeed, this patch allows VTK to compile. It is needed for either VTK5 or VTK6, but I only tested VTK6.

jcfr 2015-01-08 12:45 administrator ~0012865	Fixed in r23861 [1] [1] http://viewvc.slicer.org/viewvc.cgi/Slicer4?view=revision&revision=23861

Import 2017-06-07 23:51:09: master f5f25071 2015-01-08 17:23:50 jcfr Details Diff	COMP: Update VTK to fix build error on Debian "Jessie". Fixes 0003906 Co-authored-by: "Sharp, Gregory C." <GCSHARP@mgh.harvard.edu> This commit fixes the following build error: // ---------------- [ 35%] Building CXX object Rendering/OpenGL/CMakeFiles/vtkRenderingOpenGLObjects.dir/vtkXOpenGLRenderWindow.cxx.o In file included from /usr/include/GL/glx.h:333:0, from /home/gsharp/build/slicer-4/Slicer-build/VTKv6/Rendering/OpenGL/vtkXOpenGLRenderWindow.cxx:30: /usr/include/GL/glxext.h:480:143: error: ‘GLintptr’ has not been declared typedef void ( PFNGLXCOPYBUFFERSUBDATANVPROC) (Display dpy, GLXContext readCtx, GLXContext writeCtx, GLenum readTarget, GLenum writeTarget, GLintptr readOffset, GLintptr writeOffset, GLsizeiptr size); // ---------------- $ git shortlog ea7cdc4..563cc62 --no-merges Marcus D. Hanwell (1): Actually define GLX_GLXEXT_LEGACY to prevent the include git-svn-id: http://svn.slicer.org/Slicer4/trunk@23861 3bd1e089-480b-0410-8dfb-8563597acbee
	mod - SuperBuild/External_VTKv6.cmake		Diff File

Date Modified	Username	Field	Change
2014-11-27 08:07	gregsharp	New Issue
2014-11-27 08:07	gregsharp	Status	new => assigned
2014-11-27 08:07	gregsharp	Assigned To	=> jcfr
2014-12-17 08:42	pieper	Note Added: 0012790
2014-12-17 09:47	gregsharp	Note Added: 0012792
2014-12-23 05:23	gregsharp	Note Added: 0012806
2014-12-23 06:20	pieper	Note Added: 0012807
2014-12-23 07:56	gregsharp	Note Added: 0012810
2015-01-08 12:45	jcfr	Note Added: 0012865
2015-01-08 12:45	jcfr	Status	assigned => resolved
2015-01-08 12:45	jcfr	Fixed in Version	=> Slicer 4.4.1
2015-01-08 12:45	jcfr	Resolution	open => fixed
2015-01-08 12:45	jcfr	Target Version	=> Slicer 4.4.1
2015-09-09 08:29	jcfr	Fixed in Version	Slicer 4.4.1 => Slicer 4.5.0-1
2015-09-09 08:29	jcfr	Target Version	Slicer 4.4.1 => Slicer 4.5.0-1
2017-06-10 08:51	jcfr	Changeset attached	=> Slicer master f5f25071
2018-03-02 11:06	jcfr	Status	resolved => closed