View Issue Details

IDProjectCategoryView StatusLast Update
0003899Slicer4Module Markupspublic2015-09-09 08:29
Reporterpinter Assigned Tonicole  
PrioritynormalSeverityminorReproducibilityalways
Status closedResolutionfixed 
Product VersionSlicer 4.4.0 
Target VersionFixed in VersionSlicer 4.5.0-1 
Summary0003899: Markup disappears when moving out then back in to view in slice views
Description
  1. Load MRHead
  2. Add markups fiducial anywhere on the volume
  3. Pan the slice view so that markup gets out of view
  4. Pan the slice view that markup should be moved back in to view
    Markup doesn't show up, only when I go to Markups module and hide it then show again.
TagsNo tags attached.

Activities

nicole

nicole

2014-11-21 09:47

administrator   ~0012714

Is this happening on a Linux system?
Does the fiducial show up in the MRHead eye at the end of running Testing -> Test Cases -> FiducialLayoutSwitchBug1914?

pinter

pinter

2014-11-21 09:49

developer   ~0012715

I used Windows. The test you mentioned shows the fiducial but fails

Running the aglorithm
Conventional view
Getting MR Head Volume
<b>File already exists in cache - reusing it.</b>
<b>Requesting load</b> <i>MRHead</i> from C:/Users/pinter/AppData/Local/Temp/RemoteIO/MR-head.nrrd...

<b>Load finished</b>

Placed a fiducial
Panned and zoomed
Starting seed display coords = 317, 21, 0
Fiducial starting position
Red Slice only
Conventional layout
Ending seed display coords = 269, 19, 0
Fiducial ending position
Difference between starting and ending seed display coordinates = 48.0416
Display coordinate difference is too large!
Expected < 1.0 but got 48.0416
Test failed!

nicole

nicole

2014-11-21 10:04

administrator   ~0012716

Hrm, the test also fails on my Mac, but with a much smaller difference (16), I have a feeling that it should be scaled to the Slicer window size.
I was finally able to reproduce the panning disappearing fids, but only if I panned so that the fiducial was very very far off screen, and only in certain directions in certain windows (about a full window's width off). There might be something in the light box code that's getting triggered since the RAS to display calculation could be thinking that it's so far off that it should be in the next lightbox view, but I have to dig into it and see why it's not coming back when you pan back - looking at the fix for bug 1914, there could be a CTK issue.

pinter

pinter

2014-11-21 10:07

developer   ~0012717

Interesting. For me, even if I move the fiducial barely outside, it doesn't appear when I move it back.

nicole

nicole

2014-11-21 11:15

administrator   ~0012718

Out of curiosity, what's the resolution of your monitor? And how big do you have Slicer set to be? These are the results of the python commands I have with my monitor set to 1440x900:

slicer.util.mainWindow().size
QSize (1051, 768, at: 0x7fa6cfa1be80)
lm = slicer.app.layoutManager()
lm.sliceWidget('Red').size
QSize (174, 329, at: 0x7fa6cfeb8850)

pinter

pinter

2014-11-21 11:20

developer   ~0012719

1920*1080, Slicer is full screen (account for header and taskbar)

pinter

pinter

2014-11-21 11:20

developer   ~0012720

But it doesn't make a difference for me. As I said even a few pixels out of view, lost forever (until hidden/shown again)

pinter

pinter

2014-11-21 11:33

developer   ~0012721

I was able to reproduce it on Mac relatively easily, although it is not as deterministic as on Windows.
If you move the markup in and out a few times (max 8), it disappears. You don't even need to drag it far away.

skylstra

skylstra

2015-03-30 08:01

reporter   ~0012995

This doesn't seem to be reproducible anymore on Mac or Windows.

pinter

pinter

2015-03-30 08:07

developer   ~0012996

Thanks!
Confirmed, it works well now for me too.
I'm closing it as fixed, as a commit definitely fixed it at some point. Not sure which, but it doesn't matter much now.

jcfr

jcfr

2015-03-30 09:48

administrator   ~0012997

I also confirm the issue is not reproducible on Ubuntu 14.04 (debug build based of r24129)

pinter

pinter

2015-03-30 09:52

developer   ~0012999

Jc, did you reopen on purpose?

jcfr

jcfr

2015-03-30 10:05

administrator   ~0013000

@Csaba: I guess I also marked the issue as resolved. Closing it again now... sorry for the noise.

Issue History

Date Modified Username Field Change
2014-11-20 13:09 pinter New Issue
2014-11-20 13:09 pinter Status new => assigned
2014-11-20 13:09 pinter Assigned To => nicole
2014-11-20 17:34 jcfr Product Version => Slicer 4.4.0
2014-11-21 09:47 nicole Note Added: 0012714
2014-11-21 09:49 pinter Note Added: 0012715
2014-11-21 10:04 nicole Note Added: 0012716
2014-11-21 10:07 pinter Note Added: 0012717
2014-11-21 11:15 nicole Note Added: 0012718
2014-11-21 11:20 pinter Note Added: 0012719
2014-11-21 11:20 pinter Note Added: 0012720
2014-11-21 11:33 pinter Note Added: 0012721
2015-03-30 08:01 skylstra Note Added: 0012995
2015-03-30 08:07 pinter Note Added: 0012996
2015-03-30 08:07 pinter Status assigned => closed
2015-03-30 08:07 pinter Resolution open => fixed
2015-03-30 08:07 pinter Fixed in Version => Slicer 4.4.1
2015-03-30 09:48 jcfr Note Added: 0012997
2015-03-30 09:48 jcfr Status closed => resolved
2015-03-30 09:52 pinter Note Added: 0012999
2015-03-30 10:05 jcfr Note Added: 0013000
2015-03-30 10:05 jcfr Status resolved => closed
2015-09-09 08:29 jcfr Fixed in Version Slicer 4.4.1 => Slicer 4.5.0-1