View Issue Details

Related ChangesetsJump to NotesJump to History
IDProjectCategoryView StatusDate SubmittedLast Update
0003893Slicer4Module SubjectHierarchypublic2014-11-12 06:402018-03-02 11:07
Reporterpinter Assigned Topinter  
PrioritynormalSeverityminorReproducibilityhave not tried
Status closedResolutionfixed 
Product Version 
Target VersionFixed in VersionSlicer 4.5.0-1 
Summary0003893: Volume visibility control broken in subject hierarchy
Description

The feature is basically broken, needs to be fixed. Probably a complete overhaul would be better, to make it intuitive and usable.

Andras' description:
"I couldn’t really figure out the logic in the eye icon behavior for volumes. The eye remains “open” for volumes that are not visible at all. If I click on several volumes then the earlier ones got swapped out from the slice viewers. When I want to see them again and click on their (still “open”) eye icon then the eye closes and the volume does not appear, so I have to click again to see it. I think either the earlier behavior should be restored for volumes (special icon for volumes that does not show the visibility state and clicking on that icon always shows the volume); or the open/closed state of the eye should be determined from the actual visibility of the volume (e.g., close the icon if it is not shown in any viewer)."

TagsNo tags attached.

Activities

pinter

pinter

2014-11-13 12:06

developer   ~0012693

Solution: Fix it with the logic of the first implementation

  • If volume is not shown (eye closed, clicked to open)
    If there is an empty slot (None selected for background or foreground), then select volume there
     If both slots are occupied, then set background to foreground and show volume in background
  • If volume shown, then simply select None instead of it
pinter

pinter

2014-11-19 08:42

developer   ~0012710

Fixed in http://viewvc.slicer.org/viewvc.cgi/Slicer4?view=revision&revision=23793

Related Changesets

Import 2017-06-07 23:51:09: master 1bfbbc79

2014-11-19 13:23:40

pinter

Details Diff 		BUG: Volume visibility controls for subject hierarchy fixed.

The visibility controls did not work well in subject hierarchy, now it is fixed. Also fixed bug when importing scene: due to the automatic subject hierarchy node creation duplicate SH nodes were created when scene was imported. Simplified DICOM object naming in subject hierarchy: the name of the loadable is used instead of assembling the very same name from the same tags.

Fixes 0003893

git-svn-id: http://svn.slicer.org/Slicer4/trunk@23793 3bd1e089-480b-0410-8dfb-8563597acbee
mod - Modules/Loadable/SubjectHierarchy/Widgets/qMRMLSceneSubjectHierarchyModel.cxx Diff File
mod - Modules/Loadable/SubjectHierarchy/qSlicerSubjectHierarchyModule.cxx Diff File
mod - Modules/Loadable/Volumes/SubjectHierarchyPlugins/qSlicerSubjectHierarchyVolumesPlugin.cxx Diff File
mod - Modules/Scripted/DICOM/DICOMLib/DICOMPlugin.py Diff File

Issue History

Date Modified Username Field Change
2014-11-12 06:40 pinter New Issue
2014-11-12 06:40 pinter Status new => assigned
2014-11-12 06:40 pinter Assigned To => pinter
2014-11-13 12:06 pinter Note Added: 0012693
2014-11-19 08:42 pinter Note Added: 0012710
2014-11-19 08:42 pinter Status assigned => resolved
2014-11-19 08:42 pinter Fixed in Version => Slicer 4.4.1
2014-11-19 08:42 pinter Resolution open => fixed
2015-09-09 08:29 jcfr Fixed in Version Slicer 4.4.1 => Slicer 4.5.0-1
2017-06-10 08:51 pinter Changeset attached => Slicer master 1bfbbc79
2018-03-02 11:07 jcfr Status resolved => closed