View Issue Details

IDProjectCategoryView StatusLast Update
0003813Slicer4Module OpenIGTLinkIFpublic2017-06-10 08:51
Reportertokuda Assigned Totokuda  
PrioritynormalSeverityminorReproducibilityalways
Status closedResolutionfixed 
Product VersionSlicer 4.3.1-2 
Target VersionSlicer 4.4.0Fixed in VersionSlicer 4.4.0 
Summary0003813: Continuous changing of connector node state while waiting for connection
Description

Andras Lasso reported:

Slicer hangs if it is in waiting-for-connection state for a a few minutes because OpenIGTLinkIF constantly changes the state of the connector node while waiting for connection.

Root cause: igtlcon->WaitForConnection() does not delete the socket, just closes it, so (igtlcon->Socket.IsNotNull()) is always true. This causes a STATE_WAIT_CONNECTED and STATE_WAIT_CONNECTION state change at each reconnect attempt, which results unnecessary Modified event invocations.

TagsNo tags attached.

Activities

tokuda

tokuda

2014-08-21 13:59

developer   ~0012409

Fixed by Andras Lasso:

https://github.com/openigtlink/OpenIGTLinkIF/pull/43

jcfr

jcfr

2014-08-21 15:10

administrator   ~0012410

Fixed in r23609
See http://viewvc.slicer.org/viewvc.cgi/Slicer4?view=revision&revision=23609

Related Changesets

Import 2017-06-07 23:51:09: master 13db1aeb

2014-08-21 18:56:51

jcfr

Details Diff
BUG: Fix OpenIGTLinkIF performance issue with PlusRemote. Issue 0003813

$ git shortlog fb1a29..2ffd26 --no-merges
Andras Lasso (1):
ENH: Prevent continuous changing of connector node state while waiting for connection

Jean-Christophe Fillion-Robin (2):
STYLE: Remove end-of-line spaces
COMP: Fix uninitialized variable warning in vtkIGTLToMRMLTrajectory.

Co-authored-by: Andras Lasso <lasso@queensu.ca>

From: Junichi Tokuda <tokuda@bwh.harvard.edu>

git-svn-id: http://svn.slicer.org/Slicer4/trunk@23609 3bd1e089-480b-0410-8dfb-8563597acbee
mod - SuperBuild.cmake Diff File

Issue History

Date Modified Username Field Change
2014-08-20 12:23 tokuda New Issue
2014-08-20 12:23 tokuda Status new => assigned
2014-08-20 12:23 tokuda Assigned To => tokuda
2014-08-21 13:59 tokuda Note Added: 0012409
2014-08-21 13:59 tokuda Status assigned => resolved
2014-08-21 13:59 tokuda Resolution open => fixed
2014-08-21 15:10 jcfr Fixed in Version => Slicer 4.4.0
2014-08-21 15:10 jcfr Target Version => Slicer 4.4.0
2014-08-21 15:10 jcfr Note Added: 0012410
2014-08-21 15:14 tokuda Status resolved => closed
2017-06-10 08:51 jcfr Changeset attached => Slicer master 13db1aeb