View Issue Details

IDProjectCategoryView StatusLast Update
0003772Slicer4Core: Extensionspublic2017-06-10 08:51
Reporterjcfr Assigned Tojcfr  
PriorityhighSeverityminorReproducibilityhave not tried
Status closedResolutionfixed 
Product Version 
Target VersionSlicer 4.4.0Fixed in VersionSlicer 4.4.0 
Summary0003772: Env. path variable are not properly serialized in user settings
Description

Following r23036, environment variable specifying list of path are handled differently.

The way user Slicer revision specific settings are saved by the extensions manager after an extension is installed has not been updated.

For example, after installing dtiprocess, the settings contains:

// ----------------------
$ cat /home/jchris/.config/NA-MIC/Slicer-23473.ini

[Modules]
AdditionalPaths=/home/jchris/.config/NA-MIC/Extensions-23473/DTIProcess/lib/Slicer-4.3/cli-modules
[...]

[Extensions]
ManagerEnabled=true
ServerUrl=http://slicer.kitware.com/midas3
InstallPath=/home/jchris/.config/NA-MIC/Extensions-23473

[...]

[LibraryPaths]
1\path=/home/jchris/.config/NA-MIC/Extensions-23473/DTIProcess/lib/Slicer-4.3
2\path=/home/jchris/.config/NA-MIC/Extensions-23473/DTIProcess/lib/Slicer-4.3/cli-modules
size=2

[Paths]
1\path=/home/jchris/.config/NA-MIC/Extensions-23473/DTIProcess/lib/Slicer-4.3/cli-modules
size=1

[EnvironmentVariables]
PYTHONPATH=
// ----------------------

whereas the following is expected:

// ----------------------
$ cat /home/jchris/.config/NA-MIC/Slicer-23473.ini

[Modules]
AdditionalPaths=/home/jchris/.config/NA-MIC/Extensions-23473/DTIProcess/lib/Slicer-4.3/cli-modules
[...]

[Extensions]
ManagerEnabled=true
ServerUrl=http://slicer.kitware.com/midas3
InstallPath=/home/jchris/.config/NA-MIC/Extensions-23473

[...]

[LibraryPaths]
1\path=/home/jchris/.config/NA-MIC/Extensions-23473/DTIProcess/lib/Slicer-4.3
2\path=/home/jchris/.config/NA-MIC/Extensions-23473/DTIProcess/lib/Slicer-4.3/cli-modules
size=2

[Paths]
1\path=/home/jchris/.config/NA-MIC/Extensions-23473/DTIProcess/lib/Slicer-4.3/cli-modules
size=1

[PYTHONPATH]
size=0

// ----------------------

TagsNo tags attached.

Relationships

related to 0003771 closedjcfr After installing an extension, Slicer fails to load slicer/vtk/.. python module 
related to 0003730 closedjcfr Additional launcher setting are not added to the environment 

Activities

Related Changesets

Import 2017-06-07 23:51:09: master d4d57047

2014-07-24 02:16:04

jcfr

Details Diff
BUG: Properly serialize python paths when installing extension. Fixes 0003772

Following r23036 environment variable specifying list of path were
handled differently. This commit ensures that python paths associated
with extension are also serialized into the settings by following the
new convention introduced in r23036.

For example, before this commit, after installing an extension named
"Foo", the settings contained:

// ----------------------
[Modules]
AdditionalPaths=/home/jchris/.config/NA-MIC/Extensions-23473/Foo/lib/Slicer-4.3/qt-scripted-modules

[...]

[EnvironmentVariables]
PYTHONPATH=/home/jchris/.config/NA-MIC/Extensions-23473/Foo/lib/Slicer-4.3/qt-scripted-modules
// ----------------------

whereas the following is now written:

// ----------------------
[Modules]
AdditionalPaths=/home/jchris/.config/NA-MIC/Extensions-23473/Foo/lib/Slicer-4.3/qt-scripted-modules

[...]

[PYTHONPATH]
1\path=/home/jchris/.config/NA-MIC/Extensions-23473/Foo/lib/Slicer-4.3/qt-scripted-modules
size=1
// ----------------------

git-svn-id: http://svn.slicer.org/Slicer4/trunk@23482 3bd1e089-480b-0410-8dfb-8563597acbee
mod - Base/QTCore/Testing/Cxx/qSlicerExtensionsManagerModelTest.cxx Diff File
mod - Base/QTCore/qSlicerExtensionsManagerModel.cxx Diff File

Issue History

Date Modified Username Field Change
2014-07-22 13:57 jcfr New Issue
2014-07-22 13:57 jcfr Status new => assigned
2014-07-22 13:57 jcfr Assigned To => jcfr
2014-07-22 13:58 jcfr Priority normal => high
2014-07-22 13:58 jcfr Target Version => Slicer 4.4.0
2014-07-22 13:58 jcfr Relationship added related to 0003771
2014-07-22 13:58 jcfr Relationship added related to 0003730
2014-07-23 22:27 jcfr Note Added: 0012240
2014-07-23 22:27 jcfr Status assigned => resolved
2014-07-23 22:27 jcfr Fixed in Version => Slicer 4.4.0
2014-07-23 22:27 jcfr Resolution open => fixed
2014-09-17 22:57 jcfr Status resolved => closed
2017-06-10 08:51 jcfr Changeset attached => Slicer master d4d57047