View Issue Details

IDProjectCategoryView StatusLast Update
0003763Slicer4Core: Building (CMake, Superbuild)public2017-06-10 08:51
Reporterjcfr Assigned Tojcfr  
PrioritynormalSeverityminorReproducibilityhave not tried
Status closedResolutionfixed 
Product Version 
Target VersionSlicer 4.4.0Fixed in VersionSlicer 4.4.0 
Summary0003763: SimpleITK - Download of setuptools-2.2 failed because of powershell issue
Description

See enclosed screenshot

TagsNo tags attached.

Activities

2014-07-04 08:52

 

jcfr

jcfr

2014-07-04 14:12

administrator   ~0012143

Last edited: 2014-07-04 14:35

It turns that despite the fact Slicer build system already download setuptools, SimpleITK is also attempting to download its own.

This is explained because Slicer version is 1.4.2 and SimpleITK expects at least version 2.2. See [2]

By updating Slicer build system to download the most recent version of setup tools, it should avoid each project to download their own.

[1] https://github.com/Slicer/Slicer/blob/020a08d9a23318578f5fe5e0d5c39d0fe43b82c1/SuperBuild/External_python-setuptools.cmake#L21

[2] https://github.com/SimpleITK/SimpleITK/blob/3fe73688f9b670b590a0cd4d3ecc3c4a2a0f8029/Wrapping/PythonPackage/ez_setup.py#L33

jcfr

jcfr

2014-07-04 14:35

administrator   ~0012144

Fixed in r23421
See http://viewvc.slicer.org/viewvc.cgi/Slicer4?view=revision&revision=23421

// -------------------
OMP: Prevent windows build freeze when downloading setuptools 2.2

Updates setuptools from version 1.4.2 to 5.3

This commit fixes 0003763 by ensuring a recent version of setuptools
is used by all projects. Having a recent version of setuptools in the
python path will prevent SimpleITK (and other project) from trying
to download older setuptools will avoid the possible freeze.

This commit also patches the "setup.py" provided by pydicom to avoid
downloading an old version of distribute. This is done by removing the
first 3 lines of setup.py that were using an ancient distribute_setup.py.

Finally, after some testing recent version of setuptools (5.3 in the present
case) does NOT prevent incorrect update of "easy-install.pth" in case of
concurrent installs.
The issue distribute issue 389 [1] also mentioned in Slicer issue 0003757 [2]
is still current.

[1] https://bitbucket.org/tarek/distribute/issue/389/concurrent-installations-can-lose-updates
[2] http://www.na-mic.org/Bug/view.php?id=3757
// -------------------

Related Changesets

Import 2017-06-07 23:51:09: master 83dc5d5e

2014-07-04 18:02:10

jcfr

Details Diff
COMP: Prevent windows build freeze when downloading setuptools 2.2

Updates setuptools from version 1.4.2 to 5.3

This commit fixes 0003763 by ensuring a recent version of setuptools
is used by all projects. Having a recent version of setuptools in the
python path will prevent SimpleITK (and other project) from trying
to download older setuptools will avoid the possible freeze.

This commit also patches the "setup.py" provided by pydicom to avoid
downloading an old version of distribute. This is done by removing the
first 3 lines of setup.py that were using an ancient distribute_setup.py.

Finally, after some testing recent version of setuptools (5.3 in the present
case) does NOT prevent incorrect update of "easy-install.pth" in case of
concurrent installs.
The issue distribute issue 389 [1] also mentioned in Slicer issue 0003757 [2]
is still current.

[1] https://bitbucket.org/tarek/distribute/issue/389/concurrent-installations-can-lose-updates
[2] http://www.na-mic.org/Bug/view.php?id=3757

git-svn-id: http://svn.slicer.org/Slicer4/trunk@23421 3bd1e089-480b-0410-8dfb-8563597acbee
mod - SuperBuild/External_pydicom.cmake Diff File
mod - SuperBuild/External_python-setuptools.cmake Diff File

Issue History

Date Modified Username Field Change
2014-07-04 08:51 jcfr New Issue
2014-07-04 08:51 jcfr Status new => assigned
2014-07-04 08:51 jcfr Assigned To => jcfr
2014-07-04 08:52 jcfr File Added: Slicer-build-SimpleITK-windows-powershell-freeze.png
2014-07-04 08:52 jcfr Target Version => Slicer 4.4.0
2014-07-04 08:52 jcfr Description Updated
2014-07-04 14:12 jcfr Note Added: 0012143
2014-07-04 14:12 jcfr Status assigned => resolved
2014-07-04 14:12 jcfr Fixed in Version => Slicer 4.4.0
2014-07-04 14:12 jcfr Resolution open => fixed
2014-07-04 14:35 jcfr Note Edited: 0012143
2014-07-04 14:35 jcfr Note Added: 0012144
2014-07-18 05:19 jcfr Status resolved => closed
2017-06-10 08:51 jcfr Changeset attached => Slicer master 83dc5d5e