View Issue Details
ID | Project | Category | View Status | Date Submitted | Last Update |
---|---|---|---|---|---|
0003751 | Slicer4 | Module Transforms | public | 2014-06-27 11:55 | 2014-06-27 13:43 |
Reporter | alexy | Assigned To | alexy | ||
Priority | normal | Severity | major | Reproducibility | have not tried |
Status | resolved | Resolution | fixed | ||
Product Version | Slicer 4.3.1-2 | ||||
Target Version | Fixed in Version | ||||
Summary | 0003751: Hardening model transforms is broken after switch to VTK6 | ||||
Description | Hi Jc and all, I have been fixing the subject hierarchy logic test that was failing, and managed to get through one error, but then I discovered, that there might be a bug in the transform hardening. I tried doing that through the Slicer UI, and had the same thing:
There are two questions I’d like to ask:
For now I’ll commit the fix I made in the core, and see how this hardening issue unfolds.What is strange is that hardening doesn’t work for me on a model loaded from file and doing the steps I wrote in the previous email, but works with this python script: sphere = vtk.vtkSphereSource() However, if you call this again: then it doesn’t harden, but jumps back to its original place. Thanks, | ||||
Tags | No tags attached. | ||||
Seems like the following one line change fixes the issue just by analogy. But since I don't understand the purpose of this code can Jc or Julien review the change: Index: vtkMRMLModelNode.cxx--- vtkMRMLModelNode.cxx (revision 23387) -
|
|
Yes, that looks good. There was a typo in the code. Thanks for fixing it. |
|
Per Julian's note above, committed the fix. At revision: 23391 |
|
Date Modified | Username | Field | Change |
---|---|---|---|
2014-06-27 11:55 | alexy | New Issue | |
2014-06-27 11:56 | alexy | Assigned To | => finetjul |
2014-06-27 11:56 | alexy | Status | new => assigned |
2014-06-27 12:24 | alexy | Note Added: 0012106 | |
2014-06-27 13:36 | finetjul | Note Added: 0012107 | |
2014-06-27 13:42 | alexy | Assigned To | finetjul => alexy |
2014-06-27 13:43 | alexy | Note Added: 0012108 | |
2014-06-27 13:43 | alexy | Status | assigned => resolved |
2014-06-27 13:43 | alexy | Resolution | open => fixed |