View Issue Details

Jump to NotesJump to History
IDProjectCategoryView StatusDate SubmittedLast Update
0003731Slicer4Module Markupspublic2014-06-06 09:482014-06-10 11:34
Reporterlassoan Assigned Tonicole  
PrioritynormalSeverityminorReproducibilityalways
Status confirmedResolutionopen 
Product Version 
Target VersionFixed in Version 
Summary0003731: Markups CoordinateSystem info in fcsv file is incorrect
Description

The CoordinateSystem is not written correctly to fcsv files:

Example (saved by current nightly Slicer):

Markups fiducial file version = 4.3

CoordinateSystem = 0

columns = id,x,y,z,ow,ox,oy,oz,vis,sel,lock,label,desc,associatedNodeID

vtkMRMLMarkupsFiducialNode_0,43.0214,-0.157526,-10.2143,0,0,0,1,1,1,0,F-1,,vtkMRMLScalarVolumeNode2
vtkMRMLMarkupsFiducialNode_1,-23.4126,42.7955,-10.2143,0,0,0,1,1,1,0,F-2,,vtkMRMLScalarVolumeNode2

Ho to reproduce: start Slicer, add a fiducial, save the markup as fcsv file

TagsNo tags attached.

Activities

nicole

nicole

2014-06-06 10:09

administrator   ~0012034

The default coordinate system is RAS, which is encoded as 0. The value is written as a comment and parsed out from the comment in the storage node file, as well as recorded in the MRML scene file.
Can you expand on what you mean by "not written correctly"?
lassoan

lassoan

2014-06-06 10:37

developer   ~0012035

0 is written instead of RAS

I've never seen using magic numbers for storing enums in any ASCII file format. We should just do what all the other file format do (see NRRD, MetaIO, etc.) and store the orientation like this:

CoordinateSystem = RAS
nicole

nicole

2014-06-10 11:34

administrator   ~0012045

I have a fix coded up on a github branch:
https://github.com/naucoin/Slicer/commit/24cf3c8b821305de9c2a737b0b5dc4f88697c720

This issue isn't targeted for the 4.4 release, so unless that changes it will get integrated after the release.

Issue History

Date Modified Username Field Change
2014-06-06 09:48 lassoan New Issue
2014-06-06 09:48 lassoan Status new => assigned
2014-06-06 09:48 lassoan Assigned To => nicole
2014-06-06 10:09 nicole Note Added: 0012034
2014-06-06 10:09 nicole Status assigned => feedback
2014-06-06 10:37 lassoan Note Added: 0012035
2014-06-10 11:34 nicole Note Added: 0012045
2014-06-10 11:34 nicole Status feedback => confirmed