View Issue Details

Related ChangesetsJump to NotesJump to History
IDProjectCategoryView StatusDate SubmittedLast Update
0003708Slicer4Core: MRMLpublic2014-05-22 19:132017-06-10 08:51
Reporterjcfr Assigned Tojcfr  
PrioritynormalSeverityminorReproducibilityhave not tried
Status closedResolutionfixed 
Product Version 
Target VersionSlicer 4.4.0Fixed in VersionSlicer 4.4.0 
Summary0003708: vtkSlicerUnitsLogicTest1 is failing
Description

Reproducible with Slicer r23225

8<----8<----8<----8<----8<----8<----8<----8<----8<----8<----
267: Test command: /home/jchris/Projects/Slicer-1-SuperBuild-Qt485/Slicer-build/Slicer "--launcher-no-splash" "--launch" "/home/jchris/Projects/Slicer-1-SuperBuild-Qt485/Slicer-build/bin/qSlicerUnitsModuleCxxTests" "vtkSlicerUnitsLogicTest1" "/home/jchris/Projects/Slicer-1/Libs/MRML/Core/Testing/modelHierarchy.mrml"
267: Test timeout computed to be: 1800
267: test scene...
267: test selection node...
267: test close scene...
267: testCloseScene:
267: Not the right number of unit node. Expected 2 nodes, got instead 0 nodes.
1/1 Test 0000267: vtkSlicerUnitsLogicTest1 .........***Failed 2.00 sec
8<----8<----8<----8<----8<----8<----8<----8<----8<----8<----

TagsNo tags attached.

Activities

finetjul

finetjul

2014-05-23 05:03

administrator   ~0011945

I am not sure I am the best person for fixing it.
Something has changed in the handling of node references.
When scene->Clear(0) is called, the selection node (singleton) shall be reset.
It is indeed reset and its node references are being removed, however the Modified event is no longer fired (by vtkMRMLNode::CopyReferences ?)
jcfr

jcfr

2014-06-29 23:02

administrator   ~0012110

Fixed in r23395
See http://viewvc.slicer.org/viewvc.cgi/Slicer4?view=revision&amp;revision=23395

Related Changesets

Import 2017-06-07 23:51:09: master cbbcba94

2014-06-05 17:33:29

jcfr

Details Diff 		ENH: Simplify TestAddRefrencedNodeIDWithNoScene

This commit extends "CheckNthNodeReferenceID()" function by introducing
the extra parameter named "referencingNodeAddedToScene" and refactor the
test to use it.

Issue 0003708

git-svn-id: http://svn.slicer.org/Slicer4/trunk@23308 3bd1e089-480b-0410-8dfb-8563597acbee
mod - Libs/MRML/Core/Testing/vtkMRMLNodeTest1.cxx Diff File

Import 2017-06-07 23:51:09: master 56dee89a

2014-06-05 17:33:31

jcfr

Details Diff 		ENH: Simplify TestAddDelayedReferenceNode

This commit refactors the function "CheckNthNodeReferenceID"
to take an extra parameter named "expectedNodeReferenceID". This allows
the function to test the reference ID independently of the node reference
instance.

It also update the test to use convenience function where possible.

Issue 0003708

git-svn-id: http://svn.slicer.org/Slicer4/trunk@23309 3bd1e089-480b-0410-8dfb-8563597acbee
mod - Libs/MRML/Core/Testing/vtkMRMLNodeTest1.cxx Diff File

Import 2017-06-07 23:51:09: master ea190c7d

2014-06-06 15:41:14

jcfr

Details Diff 		ENH: Extend vtkMRMLNodeCallback API adding PrintSelf/GetReceivedEvents

This commit add the GetReceivedEvents and PrintSelf functions.
PrintSelf function displays the list of observed event that have been
invoked. This will be used in tests to display more information in case
the expected event count is different from the actual one.

Issue 0003708

git-svn-id: http://svn.slicer.org/Slicer4/trunk@23312 3bd1e089-480b-0410-8dfb-8563597acbee
mod - Libs/MRML/Core/vtkMRMLCoreTestingMacros.cxx Diff File
mod - Libs/MRML/Core/vtkMRMLCoreTestingMacros.h Diff File

Import 2017-06-07 23:51:09: master 8c968e31

2014-06-06 15:41:16

jcfr

Details Diff 		ENH: Add TestClearScene to vtkMRMLNodeTest1

This commit extends the test to check that the event invoked by
either a referencing or referenced node when clearing a scene are the expected
ones.

Issue 0003708

git-svn-id: http://svn.slicer.org/Slicer4/trunk@23313 3bd1e089-480b-0410-8dfb-8563597acbee
mod - Libs/MRML/Core/Testing/vtkMRMLNodeTest1.cxx Diff File

Import 2017-06-07 23:51:09: master 5963e8b1

2014-06-30 02:53:04

jcfr

Details Diff 		BUG: Restore original behavior of "Set(AndObserve)NthNodeReference" functions

This commit fixes test vtkSlicerUnitsLogicTest1 by partially reverting
commit r23192.

It restores the original behavior of the "Set(AndObserve)NthNodeReference"
functions. Instead of ensuring reference can be set and get at position
n, if n is larger than the number of reference nodes, the node ID
is added at the end of the list. If nodeReferenceID is 0, the node ID is
removed from the list.

Fixes 0003708

git-svn-id: http://svn.slicer.org/Slicer4/trunk@23395 3bd1e089-480b-0410-8dfb-8563597acbee
mod - Libs/MRML/Core/Testing/vtkMRMLNodeTest1.cxx Diff File
mod - Libs/MRML/Core/vtkMRMLNode.cxx Diff File
mod - Libs/MRML/Core/vtkMRMLNode.h Diff File

Issue History

Date Modified Username Field Change
2014-05-22 19:13 jcfr New Issue
2014-05-22 19:13 jcfr Status new => assigned
2014-05-22 19:13 jcfr Assigned To => alexy
2014-05-22 19:13 jcfr Assigned To alexy => finetjul
2014-05-22 19:13 jcfr Target Version => Slicer 4.4.0
2014-05-22 19:13 jcfr Description Updated
2014-05-23 05:01 finetjul Assigned To finetjul => jcfr
2014-05-23 05:03 finetjul Note Added: 0011945
2014-06-29 23:02 jcfr Note Added: 0012110
2014-06-29 23:02 jcfr Status assigned => resolved
2014-06-29 23:02 jcfr Fixed in Version => Slicer 4.4.0
2014-06-29 23:02 jcfr Resolution open => fixed
2014-07-14 09:18 jcfr Status resolved => closed
2017-06-10 08:51 jcfr Changeset attached => Slicer master 5963e8b1
2017-06-10 08:51 jcfr Changeset attached => Slicer master 8c968e31
2017-06-10 08:51 jcfr Changeset attached => Slicer master ea190c7d
2017-06-10 08:51 jcfr Changeset attached => Slicer master 56dee89a
2017-06-10 08:51 jcfr Changeset attached => Slicer master cbbcba94