0003682: Crash when NULL node reference is set

ID	Project	Category	View Status	Date Submitted	Last Update

0003682	Slicer4	Core: MRML	public	2014-05-08 11:48	2014-07-03 12:43

Reporter	pinter	Assigned To	alexy
Priority	normal	Severity	crash	Reproducibility	always
Status	closed	Resolution	fixed
Product Version	Slicer 4.3.1-2
Target Version		Fixed in Version	Slicer 4.4.0

Summary	0003682: Crash when NULL node reference is set
Description	The crash happens in vtkMRMLNode::SetNthNodeReferenceID (line 1218) when the referenced node ID is NULL. Although there is a block handling this case the referencedNode variable is NULL as it was initialized. There is no line in between where the variable is set, so it will always crash when the referenced ID is NULL.
Additional Information	Note: This is why it's dangerous to use the old C way to declare variables at the beginning of functions in C++ where declaration is allowed anywhere.
Tags	No tags attached.

Date Modified	Username	Field	Change
2014-05-08 11:48	pinter	New Issue
2014-05-08 11:48	pinter	Status	new => assigned
2014-05-08 11:48	pinter	Assigned To	=> alexy
2014-05-08 11:56	pinter	Note Added: 0011712
2014-07-03 12:43	pinter	Note Added: 0012137
2014-07-03 12:43	pinter	Status	assigned => closed
2014-07-03 12:43	pinter	Resolution	open => fixed
2014-07-03 12:43	pinter	Fixed in Version	=> Slicer 4.4.0

pinter 2014-05-08 11:56 developer ~0011712	I didn't fix it because I'm not sure what the correct fix is. I would most probably delete the line vtkMRMLNode:1218 referencedNode->UnRegister(this);

pinter 2014-07-03 12:43 developer ~0012137	I think rev23395 fixed this particular issue