View Issue Details

Jump to NotesJump to History
IDProjectCategoryView StatusDate SubmittedLast Update
0003660Slicer4Module Transformspublic2014-04-18 10:542014-06-14 16:30
Reporterfedorov Assigned Toalexy  
PrioritynormalSeverityblockReproducibilityalways
Status closedResolutionfixed 
Product Version 
Target VersionSlicer 4.4.0Fixed in VersionSlicer 4.4.0 
Summary0003660: Interaction with fiducials is broken when fiducials under a bspline transform
Description

See transform attached with 0003659 as an example.

Trying to drag a fiducial in 3d view makes the fiducial run away from the mouse pointer, and also changes the locations of other fiducials in the list!

Additional Information

Fixed faulty logic checking for coordinate changes in the vtkMRMLMarkupsFiducialDisplayableManager3D.cxx It fixed the "changes the locations of other fiducials in the list" reported above.
At revision: 23108

As for fiducials not following mouse exactly, this comes from the fact that transform(transformInvert(p)) != p

This can be tested by the following python code after loading a bspline transform:

scene = slicer.mrmlScene
inode = scene.GetNodeByID('vtkMRMLBSplineTransformNode1')
tfw = vtk.vtkGeneralTransform()
ttw = vtk.vtkGeneralTransform()
inode.GetTransformFromWorld(tfw)
inode.GetTransformToWorld(ttw)
tfw.TransformDoublePoint(16,-17,17)
(17.231535803917506, -28.471393104213476, 38.442742088607474)
ttw.TransformDoublePoint(17.231535803917506, -28.471393104213476, 38.442742088607474)
(16.03662155726421, -17.06461937470531, 17.127598865759985)

I am not sure if this is numeric accuracy or general property of non-linear transforms since the local transforms depend on the point position. Either way I suppose it is expected for non-linear transforms.

TagsNo tags attached.

Relationships

duplicate of 0003557 closednicole Transformed markups coordinate system is inconsistent 
related to 0003662 closednicole B-spline transform applied to a fiducial list does not change the coordinates of the fiducial 
related to 0003664 closedlassoan Applying b-spline transformation to the fiducial list is inconsistent with image resampling 

Activities

alexy

alexy

2014-05-17 07:04

developer   ~0011884

With the vtkITKBsplineTransform replaced with vtkBsplineTransform this problem seems to be solved.

Issue History

Date Modified Username Field Change
2014-04-18 10:54 fedorov New Issue
2014-04-18 10:54 fedorov Status new => assigned
2014-04-18 10:54 fedorov Assigned To => alexy
2014-04-18 13:08 jcfr Target Version => Slicer 4.4.0
2014-04-18 13:08 jcfr Relationship added related to 0003662
2014-04-18 13:09 jcfr Relationship added related to 0003664
2014-04-18 14:19 lassoan Relationship added duplicate of 0003557
2014-04-18 14:37 alexy Status assigned => feedback
2014-04-18 14:37 alexy Resolution open => fixed
2014-04-18 14:37 alexy Additional Information Updated
2014-05-17 07:04 alexy Note Added: 0011884
2014-05-17 07:04 alexy Status feedback => resolved
2014-06-14 16:30 fedorov Status resolved => closed
2014-06-14 16:30 fedorov Fixed in Version => Slicer 4.4.0