View Issue Details

Related ChangesetsJump to NotesJump to History
IDProjectCategoryView StatusDate SubmittedLast Update
0003658Slicer4Core: Base Codepublic2014-04-18 08:072017-06-10 08:51
Reportermatthew-woehlke Assigned Tomatthew-woehlke  
PrioritynormalSeverityminorReproducibilityalways
Status closedResolutionfixed 
Product Version 
Target VersionSlicer 4.4.0Fixed in VersionSlicer 4.4.0 
Summary0003658: opening settings dialog erases external changes to settings
Description

The Slicer settings dialog does not reflect changes to settings made outside of the dialog (e.g. new module search paths from installing extensions). Additionally, opening the dialog causes such changes to be discarded (even if previously written to disk!).

The latter may be a CTK bug, but fixing the former will likely also fix the latter, and is possibly more readily fixed in Slicer than in CTK.

TagsNo tags attached.

Activities

matthew-woehlke

matthew-woehlke

2014-04-18 09:31

developer   ~0011608

This requires https://github.com/commontk/CTK/pull/451 in order to fix.
jcfr

jcfr

2014-06-03 12:45

administrator   ~0012005

Last edited: 2014-06-03 12:49

Couldn't test on linux because of issue in Wizard. See here for details: http://www.na-mic.org/Bug/view.php?id=3603#c12006
jcfr

jcfr

2014-06-03 13:28

administrator   ~0012008

After cherryp-picking both the fix for issue [1] and the proposed change:

https://github.com/mwoehlke-kitware/Slicer/tree/3658-external-settings-changes

I confirm that the the settings are properly reloaded.

Looks good, please integrate.

[1] http://www.na-mic.org/Bug/view.php?id=3603#c12007
matthew-woehlke

matthew-woehlke

2014-06-03 13:29

developer   ~0012010

Fixed in r23303.

Related Changesets

Import 2017-06-07 23:51:09: master 81203284

2014-06-03 17:20:56

mwoehlke

Details Diff 		BUG: Don't nuke external settings changes

Update CTK to include recently added ctkSettingsDialog::reloadSettings
method. Use this to force a reload of settings prior to showing the
settings dialog. This is required in order for the dialog to show
changes that have been made externally (e.g. by installing extensions)
and, more importantly, to avoid overwriting the same when closing (even
canceling!) the dialog.

Issue 0003658

git-svn-id: http://svn.slicer.org/Slicer4/trunk@23303 3bd1e089-480b-0410-8dfb-8563597acbee
mod - Applications/SlicerApp/qSlicerAppMainWindow.cxx Diff File
mod - SuperBuild/External_CTK.cmake Diff File

Issue History

Date Modified Username Field Change
2014-04-18 08:07 matthew-woehlke New Issue
2014-04-18 08:07 matthew-woehlke Status new => assigned
2014-04-18 08:07 matthew-woehlke Assigned To => jcfr
2014-04-18 08:07 matthew-woehlke Assigned To jcfr => matthew-woehlke
2014-04-18 08:07 matthew-woehlke Status assigned => acknowledged
2014-04-18 09:31 matthew-woehlke Note Added: 0011608
2014-05-12 11:28 matthew-woehlke Status acknowledged => confirmed
2014-06-03 12:45 jcfr Note Added: 0012005
2014-06-03 12:45 jcfr Note Edited: 0012005
2014-06-03 12:49 jcfr Note Edited: 0012005
2014-06-03 12:49 jcfr Note Edited: 0012005
2014-06-03 13:28 jcfr Note Added: 0012008
2014-06-03 13:29 matthew-woehlke Note Added: 0012010
2014-06-03 13:29 matthew-woehlke Status confirmed => resolved
2014-06-03 13:29 matthew-woehlke Resolution open => fixed
2014-06-03 13:41 jcfr Target Version => Slicer 4.4.0
2014-06-04 06:05 jcfr Fixed in Version => Slicer 4.4.0
2014-06-04 06:07 jcfr Status resolved => closed
2017-06-10 08:51 Changeset attached => Slicer master 81203284