0003627: LandmarkRegistration - Fix test - MantisBT

ID	Project	Category	View Status	Date Submitted	Last Update

0003627	Slicer4	Module LandmarkRegistration	public	2014-03-11 12:33	2014-07-29 11:50

Reporter	jcfr	Assigned To	pieper
Priority	normal	Severity	minor	Reproducibility	have not tried
Status	closed	Resolution	fixed
Product Version
Target Version	Slicer 4.4.0	Fixed in Version	Slicer 4.4.0

Summary	0003627: LandmarkRegistration - Fix test
Description	Test is currently failing. See http://slicer.cdash.org/testDetails.php?test=5107651&build=205233 Two problems: 1) File "<string>", line 1 SyntaxError: can't assign to operator File "<string>", line 1 2) Traceback (most recent call last): File "/home/kitware/Dashboards/Nightly/Slicer-build-64bits-QT4.8.5-PythonQt-With-Tcl-CLI-Release-nightly/Slicer-build/lib/Slicer-4.3/qt-scripted-modules/RegistrationLib/Landmarks.py", line 166, in wrappedNodeAddedUpdate self.nodeAddedUpdate() File "/home/kitware/Dashboards/Nightly/Slicer-build-64bits-QT4.8.5-PythonQt-With-Tcl-CLI-Release-nightly/Slicer-build/lib/Slicer-4.3/qt-scripted-modules/RegistrationLib/Landmarks.py", line 186, in nodeAddedUpdate addedLandmark = self.logic.landmarksFromFiducials(self.volumeNodes) File "/home/kitware/Dashboards/Nightly/Slicer-build-64bits-QT4.8.5-PythonQt-With-Tcl-CLI-Release-nightly/Slicer-build/lib/Slicer-4.3/qt-scripted-modules/LandmarkRegistration.py", line 775, in landmarksFromFiducials addedFiducial = self.ensureFiducialInListForVolume(otherVolumeNode,landmarkName,landmarkPosition) File "/home/kitware/Dashboards/Nightly/Slicer-build-64bits-QT4.8.5-PythonQt-With-Tcl-CLI-Release-nightly/Slicer-build/lib/Slicer-4.3/qt-scripted-modules/LandmarkRegistration.py", line 703, in ensureFiducialInListForVolume fiducialSize = fiducialList.GetNumberOfMarkups() AttributeError: 'NoneType' object has no attribute 'GetNumberOfMarkups'
Tags	No tags attached.

jcfr 2014-05-22 09:50 administrator ~0011942	Fixed in 23226 See http://viewvc.slicer.org/viewvc.cgi/Slicer4?view=revision&revision=23226 For details, see https://github.com/pieper/LandmarkRegistration/commit/098c9ab9be0c261563596bfa004e11e714df6928

pieper 2014-05-22 10:56 administrator ~0011943	Unfortunately the test is still failing, probably due to the string Error showing up in the output. When the test changes the layout the events lead to some vtkErrorMacro conditions in the markups displayable manager. Also there's an odd python message that seems to be triggered by an event I haven't tracked down yet. 610: Show module (name): "LandmarkRegistration" 610: File "<string>", line 1 610: SyntaxError: can't assign to operator 610: File "<string>", line 1

Date Modified	Username	Field	Change
2014-03-11 12:33	jcfr	New Issue
2014-03-11 12:33	jcfr	Status	new => assigned
2014-03-11 12:33	jcfr	Assigned To	=> pieper
2014-03-11 12:33	jcfr	Target Version	=> Slicer 4.4.0
2014-03-11 12:34	jcfr	Description Updated
2014-05-22 09:50	jcfr	Note Added: 0011942
2014-05-22 09:50	jcfr	Status	assigned => resolved
2014-05-22 09:50	jcfr	Fixed in Version	=> Slicer 4.4.0
2014-05-22 09:50	jcfr	Resolution	open => fixed
2014-05-22 10:56	pieper	Note Added: 0011943
2014-05-22 10:56	pieper	Status	resolved => confirmed
2014-07-29 11:50	pieper	Status	confirmed => closed