View Issue Details
ID | Project | Category | View Status | Date Submitted | Last Update |
---|---|---|---|---|---|
0003592 | Slicer4 | Core: Base Code | public | 2014-02-14 12:13 | 2014-05-13 08:55 |
Reporter | spujol | Assigned To | jcfr | ||
Priority | normal | Severity | feature | Reproducibility | N/A |
Status | feedback | Resolution | open | ||
Product Version | Slicer 4.3.1-2 | ||||
Target Version | Fixed in Version | ||||
Summary | 0003592: DWI To DTI Estimation module | ||||
Description | In the tab "Estimation Parameters' can the descriptive text 'Estimation Parameters' next to LS and WLS be replaced by 'Estimation algorithms'. | ||||
Tags | No tags attached. | ||||
2014-02-16 05:36
|
|
@Sonia: The following topic fixes the issue. Instead of renaming into "Estimation Algorithms", I renamed it into "Estimation Methods". The option name now illustrate better the corresponding command line argument (--estimationMethod) Following you comment, the corresponding change will be either updated or integrated into Slicer trunk. See [1] and [2] [1] https://github.com/jcfr/Slicer/commit/afea4ad8babf45815a93f9dfb02269b38e333741 |
|
Sounds good. Can you please also change the name of the tab 'Estimation parameters' to 'Estimation Methods' ? Thanks! |
|
I thought about this but I think that since "Shift Negative Eigenvalues" is not a "method", the broader category "Estimation Parameters" still applies. What do you think ? |
|
Neither WLS, LS or 'Shift Negative Eigenvalues' are parameters that the user can adjust, so I'd be in favor in using the generic word Methods instead. |
|
Un-targeting this issue. To move forward, would it be possible to provide either a patch or well defined description of what should be renamed ? Thanks |
|
Date Modified | Username | Field | Change |
---|---|---|---|
2014-02-14 12:13 | spujol | New Issue | |
2014-02-14 12:13 | spujol | Status | new => assigned |
2014-02-14 12:13 | spujol | Assigned To | => jcfr |
2014-02-16 05:36 | jcfr | File Added: 3592-DWIToDTIEstimation-option-name.png | |
2014-02-16 05:37 | jcfr | Target Version | => Slicer 4.4.0 |
2014-02-16 05:39 | jcfr | Note Added: 0010598 | |
2014-02-16 05:39 | jcfr | Status | assigned => feedback |
2014-02-16 08:50 | spujol | Note Added: 0010599 | |
2014-02-16 10:49 | jcfr | Note Added: 0010600 | |
2014-02-16 19:26 | spujol | Note Added: 0010602 | |
2014-05-13 08:54 | jcfr | Target Version | Slicer 4.4.0 => |
2014-05-13 08:55 | jcfr | Note Added: 0011759 |