View Issue Details

Related ChangesetsJump to NotesJump to History
IDProjectCategoryView StatusDate SubmittedLast Update
0003576Slicer4Module Editorpublic2014-02-05 12:282017-06-10 08:51
Reporterjcfr Assigned Topieper  
PrioritynormalSeverityminorReproducibilityhave not tried
Status closedResolutionfixed 
Product VersionSlicer 4.3.1-2 
Target VersionSlicer 4.4.0Fixed in VersionSlicer 4.4.0 
Summary0003576: Erase tool is not cancelled after selecting an other effect
Description

To reproduce:

  • Load MRHead sample data
  • Go to Editor module
  • Select paint effect
  • paint on one of the slice
  • select erase effect
  • erase something
  • select back the paint effect
  • => The storedLabel is not restored

Good news is that I have patched.

TagsNo tags attached.

Activities

jcfr

jcfr

2014-02-05 12:35

administrator   ~0010562

Here is the topic: https://github.com/jcfr/Slicer/tree/3576-editor-restore-label-after-erase
jcfr

jcfr

2014-02-05 12:52

administrator   ~0010563

Fixed in r22862
See http://viewvc.slicer.org/viewvc.cgi/Slicer4?view=revision&revision=22862
pieper

pieper

2014-02-05 13:54

administrator   ~0010565

Nice work Jc!

Related Changesets

Import 2017-06-07 23:51:09: master 7ea10346

2014-02-05 17:36:13

jcfr

Details Diff 		BUG: Restore stored label when selecting editor effect different from erase

Selecting the "EraseLabel" effect was storing the current label into
the 'storedLabel' parameter node attribute but this one was never restored
when selecting an other effect.

This commit fix the issue by ensuring the stored label is restored and also
introduce two new functions: 'backupLabel' and 'restoreLabel'

Fixes 0003576

git-svn-id: http://svn.slicer.org/Slicer4/trunk@22862 3bd1e089-480b-0410-8dfb-8563597acbee
mod - Modules/Scripted/EditorLib/EditBox.py Diff File
mod - Modules/Scripted/EditorLib/EditUtil.py Diff File

Import 2017-06-07 23:51:09: master 898a900f

2014-02-06 17:12:42

jcfr

Details Diff 		BUG: Ensure label can be changed if it was been toggled.

Following commit r22862 fixing issue 0003576 to ensure label is restored
after switching effect, the label couldn't be changed after it being
toggled.

This commit now ensures that label is reset when eraseLabel has been
enabled and effect is switched.

See 0003576

git-svn-id: http://svn.slicer.org/Slicer4/trunk@22865 3bd1e089-480b-0410-8dfb-8563597acbee
mod - Modules/Scripted/EditorLib/EditBox.py Diff File
mod - Modules/Scripted/EditorLib/EditUtil.py Diff File

Issue History

Date Modified Username Field Change
2014-02-05 12:28 jcfr New Issue
2014-02-05 12:28 jcfr Status new => assigned
2014-02-05 12:28 jcfr Assigned To => pieper
2014-02-05 12:35 jcfr Note Added: 0010562
2014-02-05 12:35 jcfr Product Version => Slicer 4.3.1-2
2014-02-05 12:35 jcfr Target Version => Slicer 4.4.0
2014-02-05 12:52 jcfr Note Added: 0010563
2014-02-05 12:52 jcfr Status assigned => closed
2014-02-05 12:52 jcfr Resolution open => fixed
2014-02-05 12:52 jcfr Fixed in Version => Slicer 4.4.0
2014-02-05 13:54 pieper Note Added: 0010565
2017-06-10 08:51 jcfr Changeset attached => Slicer master 898a900f
2017-06-10 08:51 jcfr Changeset attached => Slicer master 7ea10346