0003428: Should reference to display node be copied.

ID	Project	Category	View Status	Date Submitted	Last Update

0003428	Slicer4	Core: MRML	public	2013-10-02 15:19	2014-03-07 09:04

Reporter	jcfr	Assigned To	alexy
Priority	normal	Severity	minor	Reproducibility	have not tried
Status	closed	Resolution	won't fix
Product Version	Slicer 4.3.0
Target Version	Slicer 4.4.0	Fixed in Version	Slicer 4.4.0

Summary	0003428: Should reference to display node be copied.
Description	When running the following snippet, the two nodes will be associated with the same display node. Is it something we should prevent ? ioManager = slicer.app.ioManager() ioManager.loadFile("/tmp/BrainAtlas2012/Data/Model_4017_left_inferior_rectus.vtk") print("------------------------") node = slicer.mrmlScene.GetNodeByID('vtkMRMLModelNode4') newNode = node.CreateNodeInstance() newNode.UnRegister(node) newNode.Copy(node) print(">>> Adding copied node") slicer.mrmlScene.AddNode(newNode) node.GetDisplayNodeID() newNode.GetDisplayNodeID()
Tags	No tags attached.

pieper 2014-03-07 06:10 administrator ~0011324	We don't think the methods need to change, but the documentation should be updated to make it clear what the expected behavior is. Right now all the references are copied (including display and storage node references). Rather than change this we need to make the ::Copy documentation more clear.

pieper 2014-03-07 09:04 administrator ~0011348	We decided that since references are being copied now it would be unwise to change the behavior.

Date Modified	Username	Field	Change
2013-10-02 15:19	jcfr	New Issue
2013-10-02 15:19	jcfr	Status	new => assigned
2013-10-02 15:19	jcfr	Assigned To	=> alexy
2013-10-02 15:20	jcfr	Target Version	=> Slicer 4.3.2
2013-10-02 15:22	jcfr	Description Updated
2013-10-02 15:33	jcfr	Relationship added	related to 0002608
2013-10-02 15:34	jcfr	Target Version	Slicer 4.3.2 => Slicer 4.4.0
2013-10-02 15:34	jcfr	Relationship replaced	child of 0002608
2013-10-02 15:45	jcfr	Summary	Should reference to displayable node be copied. => Should reference to display node be copied.
2013-10-02 15:45	jcfr	Description Updated
2014-03-07 06:10	pieper	Note Added: 0011324
2014-03-07 09:04	pieper	Note Added: 0011348
2014-03-07 09:04	pieper	Status	assigned => closed
2014-03-07 09:04	pieper	Resolution	open => won't fix
2014-03-07 09:04	pieper	Fixed in Version	=> Slicer 4.4.0
2014-03-07 09:06	pieper	Relationship added	parent of 0003617

parent of	0003617	assigned	alexy	improve documentation of Copy behavior on MRML nodes
child of	0002608	assigned	alexy	Extend vtkMRMLNode::Copy behavior
Not all the children of this issue are yet resolved or closed.