0003345: CLI point parameter for markups likely doesn't respect multiple=false attribute. - MantisBT

ID	Project	Category	View Status	Date Submitted	Last Update

0003345	Slicer4	Module Annotations	public	2013-08-29 11:16	2017-06-07 23:27

Reporter	blowekamp	Assigned To	nicole
Priority	normal	Severity	minor	Reproducibility	have not tried
Status	closed	Resolution	fixed
Product Version
Target Version	Slicer 4.3.0	Fixed in Version	Slicer 4.3.0

Summary	0003345: CLI point parameter for markups likely doesn't respect multiple=false attribute.
Description	I was looking at that to see how a single point was handled there as an example, when the multiple xml attribute was false: https://github.com/Slicer/Slicer/blob/master/Base/QTCLI/vtkSlicerCLIModuleLogic.cxx#L1410 I didn't see how the marksups WriteCLI method even get's this variable. Does it pass all point to in the Markups node? or did I miss something? I believe that if a CLI request a single point all of the point the markup node will be passed on the command line.
Tags	No tags attached.

nicole 2013-08-29 12:24 administrator ~0009708	If you have a markup or annotation that has more than 1 point, such as a ruler with 2 or an ROI with 6, should multiple = false just print the first point? Or in the case of a Markups list that contains multiple rulers, just print out all the points of the first (selected) ruler?

nicole 2013-08-29 13:02 administrator ~0009709	Have a proposed fix: https://github.com/naucoin/Slicer/commit/825be11d9b1688f814d2ca4a3a39fcc4c3bc051b The cli module logic handles writing out only one annotation (so an annotation ruler will get written out with both points), but the Markups handle writing out the first markup with all of it's points.

nicole 2013-08-30 10:42 administrator ~0009731	Fixed in svn 22369: http://viewvc.slicer.org/viewvc.cgi/Slicer4?view=revision&revision=22369

jcfr 2014-03-06 05:00 administrator ~0010849	Closing resolved issues that have not been updated in more than 3 months

Slicer: 2145-support-for-installing-extension-from-file 20882931 2013-08-30 14:41:01 naucoin Details Diff	BUG: update WriteCLI to fill a vector of strings, honor mutiple = false Because Markups define multiple markups (with potentially multiple points) in one node, it was writting multiple instances of a string + coordinates to the string stream passed in to WriteCLI. This causes a problem for the parsing of the arguments in CLIs such as FiducialRegistration which needed a separate string for each point. With this change, the markup points are writen into a vector of strings, one string for each point in each Markup. Added the multipleFlag to be passed to WriteCLI, and if it's false, only write the first selected markup to the output vector. If that markup has multiple points, it will write all of those points. Updated the Annotation control point to use the new WriteCLI signature, but because of the way the points are written, it will only write the first point in a multi point annotation (such as a ruler) if multiple is false, so it ignores it and the CLI module logic takes care of ensuring that only the first child in an annotation hierachy is written out. Write out a warning message if this is the case. Added a test for FiducialRegistration, updated the Markups node test 1 to test the single point flag. Removed trailing white spaces. Issue 0001910 0003345 0003340 git-svn-id: http://svn.slicer.org/Slicer4/trunk@22369 3bd1e089-480b-0410-8dfb-8563597acbee
	mod - Base/QTCLI/vtkSlicerCLIModuleLogic.cxx		Diff File
	mod - Libs/MRML/Core/vtkMRMLDisplayableNode.h		Diff File
	mod - Modules/CLI/FiducialRegistration/FiducialRegistration.cxx		Diff File
	mod - Modules/CLI/FiducialRegistration/Testing/CMakeLists.txt		Diff File
	add - Modules/CLI/FiducialRegistration/Testing/FiducialRegistrationTest.cxx		Diff File
	mod - Modules/Loadable/Annotations/MRML/vtkMRMLAnnotationControlPointsNode.cxx		Diff File
	mod - Modules/Loadable/Annotations/MRML/vtkMRMLAnnotationControlPointsNode.h		Diff File
	mod - Modules/Loadable/Markups/MRML/vtkMRMLMarkupsNode.cxx		Diff File
	mod - Modules/Loadable/Markups/MRML/vtkMRMLMarkupsNode.h		Diff File
	mod - Modules/Loadable/Markups/Testing/Cxx/vtkMRMLMarkupsNodeTest1.cxx		Diff File

Date Modified	Username	Field	Change
2013-08-29 11:16	blowekamp	New Issue
2013-08-29 11:16	blowekamp	Status	new => assigned
2013-08-29 11:16	blowekamp	Assigned To	=> nicole
2013-08-29 11:16	blowekamp	Relationship added	related to 0001910
2013-08-29 12:24	nicole	Note Added: 0009708
2013-08-29 13:02	nicole	Note Added: 0009709
2013-08-30 10:42	nicole	Note Added: 0009731
2013-08-30 10:42	nicole	Status	assigned => resolved
2013-08-30 10:42	nicole	Fixed in Version	=> Slicer 4.3.0
2013-08-30 10:42	nicole	Resolution	open => fixed
2014-03-06 05:00	jcfr	Note Added: 0010849
2014-03-06 05:02	jcfr	Status	resolved => closed
2014-03-06 06:16	jcfr	Target Version	=> Slicer 4.3.0
2017-06-07 23:27		Changeset attached	=> Slicer 2145-support-for-installing-extension-from-file 20882931