View Issue Details

Related ChangesetsJump to NotesJump to History
IDProjectCategoryView StatusDate SubmittedLast Update
0003318Slicer4Module Markupspublic2013-08-23 11:402017-06-07 23:27
Reporternicole Assigned Tonicole  
PrioritynormalSeveritymajorReproducibilityN/A
Status closedResolutionfixed 
Product Version 
Target VersionSlicer 4.3.0Fixed in VersionSlicer 4.3.0 
Summary0003318: Dragging fiducials outside of the 2D viewport drops them
Description

Restricting the dragging of fiducials to the viewport isn't working properly, it's possible to drag a fiducial out of the viewport and then not be able to interact with it any more.

Steps To Reproduce

Conventional view
Load MRHead
Place a fiducial with the mouse
Drag the fiducial past the right edge of the red slice viewer.
With the mouse button still down, move back into the viewport. The fiducial has been dropped, but you can't get out of drag mode in that viewer. If you switch layouts, sometimes you can get the fiducial to reappear, but it's offset from the mouse position (approximately by how much off the edge of the viewport that it was dragged).

In red slice only view, the edge check is working, but the fiducial gets offset from the mouse by approximately how much the mouse moved beyond the viewport.

TagsNo tags attached.

Activities

nicole

nicole

2013-08-27 09:22

administrator   ~0009617

Found the logic bug that was causing the fiducial to drop (needed to check two change conditions in the seed widget callback), needs the fix applied in 2d and 3d.

Working now on fixing the increasing offset between the mouse location and the fiducial that occurs after trying to drag a fiducial out of the viewport and then moving the mouse back toward the viewport.
nicole

nicole

2013-08-27 10:46

administrator   ~0009618

Dropping is fixed in svn 22339[1].

After consultation with Alex and Steve, leaving the mouse offset as is, since getting enter/exit events while the mouse button is down (dragging the fiducial) will be complex. The alternate solution involves possibly reimplementing the vtkSeedWidget.

In 3D, no check is currently done against the viewport bounds, the 3D viewer allows moving the fiducial out of the view port without getting into a bad interaction state, so leaving it as is.

[1]http://viewvc.slicer.org/viewvc.cgi/Slicer4?view=revision&revision=22339
jcfr

jcfr

2014-03-06 04:56

administrator   ~0010840

Closing resolved issues that have not been updated in more than 3 months

Related Changesets

Slicer: 2145-support-for-installing-extension-from-file eee567c0

2013-08-27 14:43:26

naucoin

Details Diff 		BUG: stop the dropping of fiducials dragged outside of 2d viewport

Check if the viewport coordinates have been restricted as well as if the display
coordinates were changed, as the second check wasn't fine grained enough
to detect when a restriction was made on a slow/small drag outside
of the viewport. This would lead to the fiducial being dropped
when it was outside the viewport.
Now the fiducial is stopped at the edge of the 2d viewport. When the
mouse comes back toward the view port, there is an offset between the
mouse position and the moving fiducial, but barring more user feedback,
we decided to leave this as is.

Issue 0003318


git-svn-id: http://svn.slicer.org/Slicer4/trunk@22339 3bd1e089-480b-0410-8dfb-8563597acbee
mod - Modules/Loadable/Markups/MRMLDM/vtkMRMLMarkupsDisplayableManager2D.cxx Diff File
mod - Modules/Loadable/Markups/MRMLDM/vtkMRMLMarkupsDisplayableManager2D.h Diff File
mod - Modules/Loadable/Markups/MRMLDM/vtkMRMLMarkupsFiducialDisplayableManager2D.cxx Diff File

Issue History

Date Modified Username Field Change
2013-08-23 11:40 nicole New Issue
2013-08-23 11:40 nicole Status new => assigned
2013-08-23 11:40 nicole Assigned To => nicole
2013-08-27 09:22 nicole Note Added: 0009617
2013-08-27 10:46 nicole Note Added: 0009618
2013-08-27 10:46 nicole Status assigned => resolved
2013-08-27 10:46 nicole Fixed in Version => Slicer 4.3.0
2013-08-27 10:46 nicole Resolution open => fixed
2014-03-06 04:56 jcfr Note Added: 0010840
2014-03-06 04:57 jcfr Status resolved => closed
2017-06-07 23:27 Changeset attached => Slicer 2145-support-for-installing-extension-from-file eee567c0