View Issue Details
| ID | Project | Category | View Status | Date Submitted | Last Update |
|---|---|---|---|---|---|
| 0003313 | Slicer4 | Module CropVolume | public | 2013-08-22 15:09 | 2017-06-10 08:51 |
| Reporter | fedorov | Assigned To | fedorov | ||
| Priority | high | Severity | crash | Reproducibility | always |
| Status | closed | Resolution | fixed | ||
| Product Version | |||||
| Target Version | Slicer 4.3.0 | Fixed in Version | Slicer 4.3.0 | ||
| Summary | 0003313: Crash on close scene after using the module | ||||
| Description | reported in http://massmail.spl.harvard.edu/public-archives/slicer-users/2013/006936.html | ||||
| Tags | No tags attached. | ||||
|
Slicer: 2145-support-for-installing-extension-from-file 2066dabb 2013-08-22 19:16:43 Details Diff |
BUG: fix the crash on scene close, see issue 0003313 Parameter node was referenced from a node selector event handler in the process of scene close. Since parameter node was deleted before the the node selectors were updated, this led to invalid reference. The fix eliminates references to parameter node from node selector event handlers, and does this only when user initiates the processing. git-svn-id: http://svn.slicer.org/Slicer4/trunk@22309 3bd1e089-480b-0410-8dfb-8563597acbee |
||
| mod - Modules/Loadable/CropVolume/qSlicerCropVolumeModuleWidget.cxx | Diff File | ||
|
Import 2017-06-07 23:51:09: master 5d8e51a1 2015-02-17 11:17:24 naucoin Details Diff |
BUG: update management of crop volume parameters node The module was holding a pointer to the parameter node that could get out of date on scene changes and cause crashes. Switch to using a mrml node combo box to manage the parameters node. Adjusted the UI file to allow the generic module widget test to pass. Update the widget more fully on enter and scene changes. Select a newly added input volume or ROI if none already selected. When picking a new input volume, or switching ot a new parameter set one, set it to be active in the slice viewers. Update the parameters node constructor, destructor, read/write xml, copy and print for missing calls. Make sure that the GUI updates the parameters node (was missing the input volume and ROI node IDs). Added a scene close to the self test, and add the CMake command to make it show up as a self test in the GUI. Added error checking, took out debugging print outs. Tested against issues: 0003947 0001764 0003313 Issue 0003947 git-svn-id: http://svn.slicer.org/Slicer4/trunk@23973 3bd1e089-480b-0410-8dfb-8563597acbee |
||
| mod - Modules/Loadable/CropVolume/MRML/vtkMRMLCropVolumeParametersNode.cxx | Diff File | ||
| mod - Modules/Loadable/CropVolume/Resources/UI/qSlicerCropVolumeModuleWidget.ui | Diff File | ||
| mod - Modules/Loadable/CropVolume/Testing/Python/CMakeLists.txt | Diff File | ||
| mod - Modules/Loadable/CropVolume/Testing/Python/CropVolumeSelfTest.py | Diff File | ||
| mod - Modules/Loadable/CropVolume/Testing/vtkMRMLCropVolumeParametersNodeTest1.cxx | Diff File | ||
| mod - Modules/Loadable/CropVolume/qSlicerCropVolumeModuleWidget.cxx | Diff File | ||
| mod - Modules/Loadable/CropVolume/qSlicerCropVolumeModuleWidget.h | Diff File | ||
| Date Modified | Username | Field | Change |
|---|---|---|---|
| 2013-08-22 15:09 | fedorov | New Issue | |
| 2013-08-22 15:16 | fedorov | Note Added: 0009557 | |
| 2013-08-22 15:17 | fedorov | Status | new => closed |
| 2013-08-22 15:17 | fedorov | Resolution | open => fixed |
| 2013-08-22 15:17 | fedorov | Status | closed => resolved |
| 2013-08-22 15:17 | fedorov | Assigned To | => fedorov |
| 2013-08-22 15:25 | jcfr | Target Version | => Slicer 4.3.0 |
| 2013-08-25 09:04 | fedorov | Note Added: 0009587 | |
| 2013-08-25 09:04 | fedorov | Status | resolved => closed |
| 2013-08-25 09:04 | fedorov | Fixed in Version | => Slicer 4.3.0 |
| 2015-02-03 09:10 | nicole | Relationship added | related to 0003947 |
| 2017-06-07 23:27 | fedorov | Changeset attached | => Slicer 2145-support-for-installing-extension-from-file 2066dabb |
| 2017-06-10 08:51 | Changeset attached | => Slicer master 5d8e51a1 |
